From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1A17C4295D for ; Wed, 6 Apr 2022 12:02:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7BADF68B2AA; Wed, 6 Apr 2022 15:02:10 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 23FC668AF88 for ; Wed, 6 Apr 2022 15:02:02 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649246528; x=1680782528; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=9Hz/PnhiJrQmxe00h+W7AgVV7LmmDndPT8opKN/K0y8=; b=FSzHaS7aRtG+NbebyR2ZLo/ADUAFELyUUHLUumZTjzTLy1MP7d1XiOge SCzbpb28jbSlfHcMZOY6QsJTF1ree8c6J3p33Vx9teqXDebIXOwg5zD+P nLBjX5WzgOuV9A/QFhxY8Ea9/IOTyDoEZT1Aw0N4bRTwkTBSGnz3wJ/YL CrLBGWNWqE+GqDwtAB7lPZmWJj5UJn3P+DSO0mTVL+65o6VDR8/I32epK nF35GNd4wUc52ruJA7sinXeBrMaMv/WTXT8SJ2C4jmKYNoRxWVuteZI5X LK4uhH4Iv/oPzAs4C82Dh0iShksz2BFuNbFHV9nqp+rCabf6/wSwpcc49 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10308"; a="258615551" X-IronPort-AV: E=Sophos;i="5.90,239,1643702400"; d="scan'208";a="258615551" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 05:01:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,239,1643702400"; d="scan'208";a="851242933" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga005.fm.intel.com with ESMTP; 06 Apr 2022 05:01:32 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Apr 2022 05:01:31 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Apr 2022 05:01:31 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Apr 2022 05:01:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PTzM0EDW334bKWF6588rIYAtNtGuKMN4Tn/I8/CBHZVbJ9rvtIWWkF/Q3XbTwQrzLVj9fgJ/Og+Cxhm38wYWr5DhYXZ+dDWZ4DaxweVtITtiM4ywYrhGK1j5DzMjyRxpK5Bs+k3ytAX5nwp5zEn+/mCMtb02cRle+QhsFT4ZgCauvHj9GVJEj/Z6MYmsO2ePyTx8hGB6odDMmIRmVrRevj7+nenaFNgHW9yCJlq9VGrcjSyiDmCuS40E6rP1XCBnUDZkmFy3qdWlowY6qRuRupF340ido7IsvvNAFy0+T3xzo6eqqZjDhfSUxbW0hmCCcLZxZ4RvwvTomVPRtOD5Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Hz/PnhiJrQmxe00h+W7AgVV7LmmDndPT8opKN/K0y8=; b=KhFxTHAi/JdHJJ+PVSnO0lxVODqxr+rtWB6O/RR0KiNXV1Lh9pwM4f1Cxu1ymjdORTyxdzCbtihHtXoTs/0+3fZZQIR/Qkpw8DumEbuknrGrX37GHQCMCzxlMLWOZSsAyZ3Ft0Q1QI7P4Yz27jhikelgBxE0ue9FIt8d6rDaZ7ciVFWioI8fCVsMNqK8tp1H5KtdiiQYb4lGWSTbFSDIqBs61C9epSUHcY38duQAonbK4cNHtSzrt3jj/yo/xZj9uBx86BAOn3HC235Sgw/7JPU9wyeeaPC8mKwg1OzZSYp9RvbCDlr1A8UlhfohNgJ3iXPWdjoqUQR8odFCnrayxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CH2PR11MB4407.namprd11.prod.outlook.com (2603:10b6:610:47::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr 2022 12:01:30 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25%5]) with mapi id 15.20.5144.021; Wed, 6 Apr 2022 12:01:30 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size Thread-Index: AQHYOpEcm1jg5zkYQEeAelY1P1CQRqzEwbgAgA9fhICACEeEAIAGfjaA Date: Wed, 6 Apr 2022 12:01:30 +0000 Message-ID: <2c173dc638a3c602c40d25214d6b37f40d914d02.camel@intel.com> References: <20220318062511.382951-1-wenbin.chen@intel.com> <20220318062511.382951-3-wenbin.chen@intel.com> <57a8a823dd8f53dec096f5747a552d88b20b5b77.camel@intel.com> <72913a067c2ee51247e2086020402f0676ab72b3.camel@intel.com> In-Reply-To: <72913a067c2ee51247e2086020402f0676ab72b3.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c933e41c-ede1-4a28-79a5-08da17c52fc8 x-ms-traffictypediagnostic: CH2PR11MB4407:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AIwd1Mok4f8MwjuHPrpOGX4IxJd9OG5fs84iq79YWtGd9quuq6XOQXDqPa62mIeUsJs035wIujeskp6DkwKc+qsneGWM3d8ucl2oQDu0h45qpPiJT4mTTvmUf/ejKd+OdmilSrK/L5/cJbDXgRM5ipyDSaeWUSqfiy2hRnVlgZwqvPwI4EAkKpYdtCCJaz9D5XeKCR6L1DcZNl8yCUMt1AUKo7yCerpR3/muFIQc3FV5qvYgo5apa2oiL430BmXf4FIFA8PiWcwAA6oCYrQQ4UjhKYBU1aNb9tcRElMHCQiM3TYuhbt32k4ZokToltgqOLhblWcPnKUe/Ombs2eQz6r8pM3BHjSz3wUc7hhfuipyiC/iaqE1FAjSWU6u+a20CWZSTX5eD9IWZXA+1Rq4tsn+6x6NcWACN7vF08QoqXxkLsHcaE3O9XImhY9BmJwJ3jAh0yFUqBPlL0PRAHB5xUEj+FiyXL8K+d5DzSMMOxyBsbfFNeacFWb+iFqkptGFA8DlZKGLUTacRyu2VxEeMRkkldnIMsoANqlk7oDNPeJvuuRc67N20hVeP+LWjVU062BkOAmASVUsCjD1qE9P3OWA83C8k2rS0jduZoen5jrDTU0JZImSswXGRy5IsHYD3i/TKjJ0PDI4D6HH3nmXDFeOtvUazuj2KdjkIAiC+k9hEAkKWSFx+x6iufnYBjzFtznKyKCI0MExAOxpt3msNtfNwX9jZw4IcuX9zmkXvXk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(6486002)(8676002)(64756008)(66476007)(76116006)(86362001)(66446008)(66556008)(26005)(508600001)(91956017)(66946007)(71200400001)(186003)(2616005)(6512007)(6506007)(6916009)(36756003)(38070700005)(8936002)(38100700002)(82960400001)(2906002)(122000001)(53546011)(83380400001)(316002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b1RhVXFmT0c3WW9ZNmFMNXJzM09tOTlveWlTczdYOGtEMzkvWldMR2F0VDNP?= =?utf-8?B?WVRXb3RyaFNPVjIzYmwrVllqL3YwYTV0VWpJUFlKSDlWSGtCelFIMkxTUGUr?= =?utf-8?B?STArTWNDekI5ODZ3REM0TEIrUjFtNWdCMWNVNTJRSytOQ1JWMUhVZm9TREpX?= =?utf-8?B?ZG5Od2Z3MHBhNnBxNk0zaVQ1dEE4TmVpQjQzUmwzNmdEVjd5WFBxc0o2Q3N6?= =?utf-8?B?d1BKQzFwb0c1Sk5IQnQrYmF5Sy9VVUVVY0FXdlMybWNyQUZwRVRZTUcrMGV6?= =?utf-8?B?ZCtzK0gxRVgwWjhwcEp1M2dXYmoxUlNNZjYvQWtZZGp0eTBxdk9CaEI2NUVX?= =?utf-8?B?dUlPMnVTTlRzQVVjTzhERy83K0ZVa3diZEdkbzYwbDZwdk5RYlV5STBNVzNO?= =?utf-8?B?U2Q0MXp0b1UzVTFsR25XUnZOUUViWGpLZ3MyRkNhSnM3bEptTXB4QXR2dlV0?= =?utf-8?B?QitKMlFmSldYaHFEMlAyOWR0bWVUOS9WcTVsRTNKaVRmM1FMQjR0Qk1VMHBG?= =?utf-8?B?cWRDTXB1WGZOc1RaNnZ3cDVVM2l5Skc0bGJHVGF2R2NIejkySmNpRVQ2cUIr?= =?utf-8?B?T3JBaTBGaExKMk1sZEY3WElsVmZpNW5pS2JZOVhveVkxelUxK3F6cG9rN2lW?= =?utf-8?B?azNOd0s1TmtDaVZWVGJzT21QcHNWYnRabGF1TlFDSVZQaU0xY1pab083NWpN?= =?utf-8?B?dkF2bkRyN1dpM3o1L1VOTnJmYWsyRzVOeDQ0bTJaeDk5VjljV0laN1N3Qmla?= =?utf-8?B?TWV2Vkw2Tm1lcmpSaUxuR0NjWk5tNHJPbEI2VUVGRHpuSXJTMlZsYzFpSjZV?= =?utf-8?B?N0VDWjRtejNQRlVXQkZlczFHeHFnTi9iQTJPbTIvTHd2TldWajF3bU81OGx5?= =?utf-8?B?WE02cW5PaWZZbTVJWENIc0w4K1lyN0h4N25PWGVzc0dVaFUwTWx4SWJ5OGtn?= =?utf-8?B?YnZpSzZsZ3VXbmhaY0llVTNLbnI4WnB4WWt5WEI2WEs4MGJORmU1NGxsYSs2?= =?utf-8?B?WURLbERmbi81V3V3TTZ4eXMxRTd5em42MDBXVkZnaFdTT2hFQzlRZmUzcjJt?= =?utf-8?B?MkVLekNYK29lQ0pPNmtlNTlMcXJsd0hqRUYydk9JcnBhMHpBZlFKQ3IrS0I4?= =?utf-8?B?aDFmNG4zTFR6dndjTlp3WDV3alpEemtlc1V1VHd1cExrcnduRGM4ZEpLZUJW?= =?utf-8?B?YXMrYWUyVXJYVCtrWi9jeHBHbVc1V2FCd0pyUFFtVUhiVVBaOUFkRjFLUkpG?= =?utf-8?B?WnJqblN6Z1JaSHAxaWxyWkgycjk3OTFXb3loRWkyQWVER2lVTnczUHgxWDZX?= =?utf-8?B?Zzk5MDN0c1IwdFMza1IxaDRlcC80NUlCbjFtYnZ0cHNSZEZCdllsZjRtdHFx?= =?utf-8?B?Zm9YVEhtUGJ6QUFJS1NWbGRaTzN4UkRBdmo4V3hBU0hwSDBXekRuSE5MSnBJ?= =?utf-8?B?QnZrQWU4U0VFbVhoQW9MY2pSN0lRTnlLNnNlaHZlaE81WG9BeHQ5N3o0d2hj?= =?utf-8?B?ekZZOGo3QVNMdHU5OFN2ekI3c2RqM2ptWGZjVEpIZWU3MjBYaHlRSzl5UlRp?= =?utf-8?B?dUp5bXV4eFpuZEFpYXlObVBKRUN1TlVYalZqSmc4WTREMUdkcW9PWVBvdlpX?= =?utf-8?B?WmVvZ3BGVmpDQkJEK09DUnBZYzNlVitxZW1pQ0dsYTByanAxR3luemY0dktk?= =?utf-8?B?QVFNb3dkQnA5YXoweklKUC9kS0N5bUZyWHN3bVJLeldUcEFSV0NKSDIrSWhO?= =?utf-8?B?SjQrVmlZZWlyWk5QYUxId3NGRWlHWTU5RE9JdXBaTjB1NGdKd2M1Z3VzRFJU?= =?utf-8?B?cXZTdWlMVEt0VDFjWjFhelJsR3pRR0xHMnJpNWhyVXBDQjh2NklXQUdUOFNm?= =?utf-8?B?dHZBSEx4NFczZVBkZHErTHlOcXRZMEw1KzJPcW52RXF3YkZONkk1L0NySGIr?= =?utf-8?B?YmFsUGJDTjlZUHRXS2o3RXNJU3ZueXJyanBhbktKOG1lZmRYNDY4WVRTN2Zy?= =?utf-8?B?Z0lwNkEyTHAyQ1RVRUdHMXhZZk4ydVBaY2VQbHhSbTE2ZElESjNxMlNvdFpW?= =?utf-8?B?RnBjL3l6RjRyT3pHY1d0TmNGM0hLanZFSXhOVDY3R0RlNnlMNUFFN2tiWm1x?= =?utf-8?B?OUxLRUVxUTkxTzN2TkpHVzFlS2JnL3YzcTR4THM3UVh3YVQrdHEvdEdRZTMx?= =?utf-8?B?Tm5SR2JaK0NBR1duTmNrTXBNNVg1NmV4R1laT3dIMWRibU1xWjZhSkd3UCt6?= =?utf-8?B?NTk2WFlrQ2JJNjRtdk0zV3h3S0pxSFJjeGY0VU0vVURnSXhRNFlaVmwwRDBh?= =?utf-8?B?NDFPZzFmdUxabVdPdUxJUjQ5dUd2NXU3MkVXTEdjY0dwTjc5azdOdzhiT2xs?= =?utf-8?Q?6eufp/jz3ywi9SwE=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c933e41c-ede1-4a28-79a5-08da17c52fc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 12:01:30.2747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oBXSrIyk67Z9DFBnQnCbmTQ1Y8kbd0U6V6NdFdOrM/jFLHFHnnbrag3nSuT5YcRpbqaNk1nlxRS9nWBOLDfORg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4407 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using suggested num to set init_pool_size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 2022-04-02 at 08:52 +0000, Xiang, Haihao wrote: > On Mon, 2022-03-28 at 02:26 +0000, Xiang, Haihao wrote: > > On Fri, 2022-03-18 at 07:40 +0000, Soft Works wrote: > > > > -----Original Message----- > > > > From: ffmpeg-devel On Behalf Of > > > > Wenbin Chen > > > > Sent: Friday, March 18, 2022 7:25 AM > > > > To: ffmpeg-devel@ffmpeg.org > > > > Subject: [FFmpeg-devel] [PATCH v2 3/3] libavcodec/qsvdec: using > > > > suggested num to set init_pool_size > > > > > > > > The init_pool_size is set to be 64 and it is too many. > > > > Use IOSurfQuery to get NumFrameSuggest which is the suggested > > > > number of frame that needed to be allocated when initializing the > > > > decoder. > > > > Considering that the hevc_qsv encoder uses the most frame buffer, > > > > async is 4 (default) and max_b_frames is 8 (default) and decoder > > > > may followed by VPP, use NumFrameSuggest + 16 to set init_pool_size. > > > > > > > > Signed-off-by: Wenbin Chen > > > > Signed-off-by: Guangxin Xu > > > > --- > > > > libavcodec/qsvdec.c | 14 ++++++++++++-- > > > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > > > > index 210bd0c1d5..9875d3d632 100644 > > > > --- a/libavcodec/qsvdec.c > > > > +++ b/libavcodec/qsvdec.c > > > > @@ -88,7 +88,7 @@ typedef struct QSVContext { > > > > uint32_t fourcc; > > > > mfxFrameInfo frame_info; > > > > AVBufferPool *pool; > > > > - > > > > + int suggest_pool_size; > > > > int initialized; > > > > > > > > // options set by the caller > > > > @@ -275,7 +275,7 @@ static int qsv_decode_preinit(AVCodecContext > > > > *avctx, QSVContext *q, enum AVPixel > > > > hwframes_ctx->height = FFALIGN(avctx- > > > > > coded_height, 32); > > > > > > > > hwframes_ctx->format = AV_PIX_FMT_QSV; > > > > hwframes_ctx->sw_format = avctx->sw_pix_fmt; > > > > - hwframes_ctx->initial_pool_size = 64 + avctx- > > > > > extra_hw_frames; > > > > > > > > + hwframes_ctx->initial_pool_size = q->suggest_pool_size + 16 + > > > > avctx->extra_hw_frames; > > > > frames_hwctx->frame_type = > > > > MFX_MEMTYPE_VIDEO_MEMORY_DECODER_TARGET; > > > > > > > > ret = av_hwframe_ctx_init(avctx->hw_frames_ctx); > > > > @@ -793,6 +793,9 @@ static int qsv_process_data(AVCodecContext *avctx, > > > > QSVContext *q, > > > > } > > > > > > > > if (q->reinit_flag || !q->session || !q->initialized) { > > > > + mfxFrameAllocRequest request; > > > > + memset(&request, 0, sizeof(request)); > > > > + > > > > q->reinit_flag = 0; > > > > ret = qsv_decode_header(avctx, q, pkt, pix_fmt, ¶m); > > > > if (ret < 0) { > > > > @@ -802,12 +805,19 @@ static int qsv_process_data(AVCodecContext > > > > *avctx, QSVContext *q, > > > > av_log(avctx, AV_LOG_ERROR, "Error decoding > > > > header\n"); > > > > goto reinit_fail; > > > > } > > > > + param.IOPattern = q->iopattern; > > > > > > > > q->orig_pix_fmt = avctx->pix_fmt = pix_fmt = > > > > ff_qsv_map_fourcc(param.mfx.FrameInfo.FourCC); > > > > > > > > avctx->coded_width = param.mfx.FrameInfo.Width; > > > > avctx->coded_height = param.mfx.FrameInfo.Height; > > > > > > > > + ret = MFXVideoDECODE_QueryIOSurf(q->session, ¶m, > > > > &request); > > > > + if (ret < 0) > > > > + return ff_qsv_print_error(avctx, ret, "Error querying IO > > > > surface"); > > > > + > > > > + q->suggest_pool_size = request.NumFrameSuggested; > > > > + > > > > ret = qsv_decode_preinit(avctx, q, pix_fmt, ¶m); > > > > if (ret < 0) > > > > goto reinit_fail; > > > > -- > > > > > > Thanks for the patch! I have that on my list for quite a while. > > > Will look at it shortly. > > > > Hi Softworz, > > > > This patchset LGTM and works well, do you have any comment ? > > Ping, I'll apply this patchset in a few days if no more comment. > Applied, thx -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".