Re: [FFmpeg-devel] [PATCH] avcodec/tiff: pass arguments to bytestream2_seek in the right order

From: Leo Izen <leo.izen@gmail.com>
To: FFmpeg Development <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/tiff: pass arguments to bytestream2_seek in the right order
Date: Fri, 9 Feb 2024 15:50:19 -0500
Message-ID: <2bc606d1-fbdc-4cf4-9069-36c257d8aa2b@gmail.com> (raw)
In-Reply-To: <20240131193717.407384-1-leo.izen@gmail.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 919 bytes --]

On 1/31/24 14:37, Leo Izen wrote:
> The function signature for bytestream2_seek is (gb, offset, whence);
> Before this patch, the code passed (gb, SEEK_SET, offset), which is
> incorrect.
> 
> Siged-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>   libavcodec/tiff.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index adb49e4525..3ce441aa2c 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -1701,7 +1701,7 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
>           break;
>       case TIFF_ICC_PROFILE:
>           gb_temp = s->gb;
> -        bytestream2_seek(&gb_temp, SEEK_SET, off);
> +        bytestream2_seek(&gb_temp, off, SEEK_SET);
>   
>           if (bytestream2_get_bytes_left(&gb_temp) < count)
>               return AVERROR_INVALIDDATA;

Will apply soon.

- Leo Izen (Traneptora)

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".