From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF6EB46440 for ; Wed, 16 Aug 2023 20:45:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD98C68C748; Wed, 16 Aug 2023 23:45:52 +0300 (EEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7450768C741 for ; Wed, 16 Aug 2023 23:45:46 +0300 (EEST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3fe167d4a18so65769295e9.0 for ; Wed, 16 Aug 2023 13:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20221208.gappssmtp.com; s=20221208; t=1692218746; x=1692823546; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ozhm7M3hD79qKKIwt2kB1xmtOSdWSK0jz4HxrTS/Myw=; b=CAXDEi6m+P2z7v4PgWHJYEgOVY/JmAOJVc3c+lFqxTRJBdF4GihjmN+B/TN8tapdpc eOG5UwMlA9NsDLxY4ELBldtNC0rFmFPNVfClWOsYcahODkzCcaLzyAjye2YxP8ppx37S tjvD5P3IBCG93wWKbYjOX7Hf/8pmjrgi3KKt42uQmQJgXi3JUGAI4mCGvA3PL6tpBXVJ /ovQi8e+WnxyWqqerOgX8sZpZLoKp75vh8Rfv0+rTH91OJMP6lKF/JEd4S86Z57J0uxh 8YbqtirHm5LE95DTVj+/sg/gaK4TAKMrkWunMsaiLuULJjqmXvPXmaR/Kc2QahI1L8DI USmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692218746; x=1692823546; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ozhm7M3hD79qKKIwt2kB1xmtOSdWSK0jz4HxrTS/Myw=; b=XZqOaLVkGq2NHEY5Py5v8JHrCMSRBF4bdUZ0atGEd2s4/ADwjBpkghqmQQ/5Y5tfn/ nQDXHrtIoyOq1otv9IZ5zXrsrPhXyATws/nfZaKhEksBnZH46Z3UdpX46RpFj2H8NeqE xIKTY9W6PLoIS4gxAELx6rzFT28QTUZxyzV9PkGuJ5F8rB4P1iG6V0Ko6qyvKv3MXDD3 W4TxkTFl55+KJ5NzaVHwCtInvIm3roPBQfR8e21VFVI5mYYSQAPkLjgTqob1d45WAiAt T+QiqMM83/7HBfDQ9mnqIkMWqH6fL+6QR57xMo+a/45KHlvMf18dxGnoCAcQvPExQVEP +wWg== X-Gm-Message-State: AOJu0YyOP3yzDn+hrcWJtFnYbmNIYY3L1vTR3OVY+Xa0OtArvIB4RNGe yWCaWKu2jSIdsN9gfhKfODBQWDwsX1Lhsi3e6BQ= X-Google-Smtp-Source: AGHT+IFugxgx51ntQaQFb12s6oUaeBbYyk9vPVwDIlPAKsetJVmR6YTEdWY3GjcDCzU1b4ES9DxaIQ== X-Received: by 2002:a05:600c:20c4:b0:3fc:a5:2c3a with SMTP id y4-20020a05600c20c400b003fc00a52c3amr2380947wmm.41.1692218745564; Wed, 16 Aug 2023 13:45:45 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust383.5-4.cable.virginm.net. [82.13.65.128]) by smtp.gmail.com with ESMTPSA id s14-20020a05600c044e00b003fe1a092925sm534181wmb.19.2023.08.16.13.45.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 13:45:45 -0700 (PDT) Message-ID: <2b67a6ca-2d76-b0dc-0ee5-e5b096745ab1@jkqxz.net> Date: Wed, 16 Aug 2023 21:45:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230803060132.501741-1-fei.w.wang@intel.com> <20230803060132.501741-6-fei.w.wang@intel.com> <336d0b1463430f3591a9444b60191cf00f595700.camel@intel.com> <1acd766d-e0dc-69f6-56e5-0d84e62f83c8@jkqxz.net> From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v3 6/6] lavc/vaapi_encode: Add VAAPI AV1 encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 16/08/2023 08:54, Wang, Fei W wrote: > On Sun, 2023-08-13 at 22:43 +0100, Mark Thompson wrote: >> On 10/08/2023 03:54, Wang, Fei W wrote: >>> On Mon, 2023-08-07 at 22:21 +0100, Mark Thompson wrote: >>>> On 03/08/2023 07:01, fei.w.wang-at-intel.com@ffmpeg.org wrote: >>>>> From: Fei Wang >>>>> >>>>> Signed-off-by: Fei Wang >>>>> --- >>>>> Changelog | 1 + >>>>> configure | 3 + >>>>> doc/encoders.texi | 13 + >>>>> libavcodec/Makefile | 1 + >>>>> libavcodec/allcodecs.c | 1 + >>>>> libavcodec/vaapi_encode.c | 125 +++- >>>>> libavcodec/vaapi_encode.h | 12 + >>>>> libavcodec/vaapi_encode_av1.c | 1229 >>>>> +++++++++++++++++++++++++++++++++ >>>>> libavcodec/version.h | 2 +- >>>>> 9 files changed, 1368 insertions(+), 19 deletions(-) >>>>> create mode 100644 libavcodec/vaapi_encode_av1.c >>>>> ... >>>>> + >>>>> + /** update obu size in bitstream */ >>>>> + if (fh_obu->header.obu_has_size_field) { >>>>> + obu_size_len = priv- >>>>>> attr_ext2.bits.obu_size_bytes_minus1 >>>>> + 1; >>>>> + for (i = 0; i < obu_size_len; i++) { >>>>> + byte = obu_size >> (7 * i) & 0x7f; >>>>> + if (i < obu_size_len - 1) >>>>> + byte |= 0x80; >>>>> + put_bits(&pbc_tmp, 8, byte); >>>>> + } >>>>> + flush_put_bits(&pbc_tmp); >>>>> + memmove(pbc_tmp.buf_ptr, pbc_tmp.buf_ptr + (8 - >>>>> obu_size_len), obu_size); >>>>> + *data_len -= (8 - obu_size_len) * 8; >>>>> + } >>>> >>>> Why is there an incomplete duplicate of the cbs_av1 header >>>> writing >>>> code here? >>> >>> To record some position/size in bitstream that needed for VAAPI. >>> Like >>> qp_index/loopfilter/cdef offset and cdef parameters size in bit. >>> It's >>> not reasonable to add the specific parameters into CBS. >> >> How about with < >> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-August/313228.html> >> ;? > > How to pass position info out of .trace_write_callback? If define own > write_callback function in vaapi_encode_av1.c, and it can easily get > the positions of each syntax element, but can't pass them back to VAAPI > AV1 encoder. A possible way is according > to CodedBitstreamContext.priv_data, but that will need to add lots of > xxx_offset into CodedBitstreamAV1Context. Right, it needs a context pointer in the callback because CBS hasn't previously had that. See new version. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".