From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95
Date: Mon, 19 Jun 2023 18:57:20 +0200
Message-ID: <2b5db55ba0a3776def39d6ea28cfe204935a79ef.camel@haerdin.se> (raw)
In-Reply-To: <e943597f-9b44-c621-85e5-0ff84c536d93@gmail.com>
mån 2023-06-19 klockan 11:42 -0400 skrev Leo Izen:
> On 6/8/23 07:44, Tomas Härdin wrote:
> > tor 2023-06-08 klockan 13:27 +0200 skrev Paul B Mahol:
> > > But does this break it on other platforms?
> >
> > That is a good question. What other RIFF decoders are there for
> > which
> > MSRLE support is important and depends on behavior different from
> > VfW?
> > mpv and vlc work just fine.
> >
> > /Tomas
> >
>
> mpv's RIFF decoder is really avformat, so this doesn't say much. VLC
> has
> its own though, iirc.
Yeah. Also we'd be hard pressed to find an msrle decoder that isn't
either ffmpeg, vlc or VfW
It might be necessary to do this same thing for more codecs. We only
tested msrle which was painful enough. I wouldn't be surprised if say
msvideo1 requires similar hacks. This patch is conservative until we
learn why VfW needs this.
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-19 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 11:22 Tomas Härdin
2023-06-08 11:23 ` [FFmpeg-devel] [PATCH 2/2] lavc/msrleenc: Add msrle encoder Tomas Härdin
2023-06-10 18:34 ` Andreas Rheinhardt
2023-06-08 11:27 ` [FFmpeg-devel] [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95 Paul B Mahol
2023-06-08 11:44 ` Tomas Härdin
2023-06-19 15:42 ` Leo Izen
2023-06-19 16:57 ` Tomas Härdin [this message]
2023-06-16 13:20 ` [FFmpeg-devel] [PATCH 3/3] Add Changelog entry Tomas Härdin
2023-06-20 12:38 ` Tomas Härdin
2023-06-19 12:26 ` [FFmpeg-devel] [PATCH 1/2] lavc/riffenc: Fix msrle support on Windows 95 Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b5db55ba0a3776def39d6ea28cfe204935a79ef.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git