From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 02A4F407F9 for ; Wed, 2 Mar 2022 16:17:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46A1068B2AC; Wed, 2 Mar 2022 18:17:52 +0200 (EET) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4B3A968A962 for ; Wed, 2 Mar 2022 18:17:46 +0200 (EET) Received: by mail-ot1-f44.google.com with SMTP id 40-20020a9d032b000000b005b02923e2e6so2101543otv.1 for ; Wed, 02 Mar 2022 08:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=SUMEVlmwGR+7Qng6ccqSlgiUicq1zUB84xCHWFYb5LU=; b=TCP9eK/NAjjID/0FI5zlUpY2GoEOf6JRFKfA8qegra1qMMA/OQYj8oMwmDh+t6Pzfd ff+kVBrnHYJgqObw5t5XuLS+aZDdUXHghtYx3rSJ1buKsDTMSECCzeweueCDvqSrBijP UZM+higj2hapWEi7jzZiSvyVAE5MEzeqd0O8f36WyTTFCT6t69K+//vpwhsPeYXXwMpx MwFPGQg9P9klFtWX9BSK4yEzSZGmreqx0ydCWnGYuC/yQHPtMwLFzOpUBFGjlawf/ECB 3RAExSYpsAtBIVwHBmqd1Z+LmomVyTE5M/kkdoNVtMp4EdR64Ii4j4s/NlMsaJH0FgvP Bijg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=SUMEVlmwGR+7Qng6ccqSlgiUicq1zUB84xCHWFYb5LU=; b=6PC5JQBAQKMiA4AXmq+SMqxoX85wqI1Hn/88qrSFC5nn8fuKaVS+ulYmfGgi3ukto7 TWchoMefduU9KB5vLbo3LZNrdnM0vDQNm3PDUDFdfezb1YTkG6OR9kDDE1RGzhw3q2iP wXqoOBx8Xc+QJk+m9sHmMtcE0xiJSvAjhalvTnT87eXpq0PmFLNBwTkwB8CHYnOBGzF2 Wub5Fo0Tp4BMqBQsm64ZjcWRQyljAEajNXuMn9a7hv/NwawtLPndkB6hDkJkMrHQoxJH pJ91f1mDWV4i5srqTbfHtoNZcnGVxcNvqi77NmjbzVP8aLQSDuZDdDOrEUHw4klJmRLs DOXg== X-Gm-Message-State: AOAM530dCF8g862pQToSjl1ctCNFEL5YdFRyE1y5lRzVmz94e3wHwyks my6tcZxCUThNMDzYVrfXO190jcbe1SxOWQ== X-Google-Smtp-Source: ABdhPJzWZYKGQVP2irbhAkGdBEew/VTj0/AVHXckCjTGblJ2GqQuGZNmzUCsB460mI+hbR7F0xtWWA== X-Received: by 2002:a9d:76c6:0:b0:5a1:b25d:1311 with SMTP id p6-20020a9d76c6000000b005a1b25d1311mr16398163otl.297.1646237864337; Wed, 02 Mar 2022 08:17:44 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id a10-20020a9d74ca000000b005af640e9377sm7937087otl.17.2022.03.02.08.17.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 08:17:43 -0800 (PST) Message-ID: <2b3b0b03-4f1f-5970-4614-838f8b7eb092@gmail.com> Date: Wed, 2 Mar 2022 13:17:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220302160438.4136064-1-george@nsup.org> From: James Almer In-Reply-To: <20220302160438.4136064-1-george@nsup.org> Subject: Re: [FFmpeg-devel] [PATCH] lavfi/af_aformat: remove support for comma-separated lists X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/2022 1:04 PM, Nicolas George wrote: > It has been deprecated for nine years. We need to make sure to add FF_API_ defines when we introduce this kind of deprecation in the future, as it forces people to at least look at them at every major bump. Nine years is definitely overkill. > > Signed-off-by: Nicolas George > --- > libavfilter/af_aformat.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > > I want to share the delimiter-seeking function with vf_format and add > support for '/'. > > > diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat.c > index ed3c75311a..d2599431dc 100644 > --- a/libavfilter/af_aformat.c > +++ b/libavfilter/af_aformat.c > @@ -62,19 +62,12 @@ AVFILTER_DEFINE_CLASS(aformat); > > #define PARSE_FORMATS(str, type, list, add_to_list, get_fmt, none, desc) \ > do { \ > - char *next, *cur = str, sep; \ > + char *next, *cur = str; \ > int ret; \ > \ > - if (str && strchr(str, ',')) { \ > - av_log(ctx, AV_LOG_WARNING, "This syntax is deprecated, use '|' to "\ > - "separate %s.\n", desc); \ > - sep = ','; \ > - } else \ > - sep = '|'; \ > - \ > while (cur) { \ > type fmt; \ > - next = strchr(cur, sep); \ > + next = strchr(cur, '|'); \ > if (next) \ > *next++ = 0; \ > \ LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".