From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 32B4947614 for ; Sun, 15 Oct 2023 01:09:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B4DF68C877; Sun, 15 Oct 2023 04:09:26 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D78B968B1FF for ; Sun, 15 Oct 2023 04:09:19 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 5DA93317C71 for ; Sun, 15 Oct 2023 03:09:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1697332157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D6mB5a7UoGseDFFbZ+1WmoixT6e/L47h5y+EWTEbnz0=; b=YBGy+cSgGVhNjGMjWGJviyrBrAP5BBRWNrRofhDN5pONfarIREWcxdaTOM1PKoJY/a3r4F /fwy2zRfo84FmrQrW2cGUAd4nv435SoXTEoOgtbQ8olsqBj7dz1Ky4IE/1diIpDoIJbYpy vMVovfVjubRnbxDqfohJW9BgE5U/QCdmEr0RxDdbza9bjjGUWIVumgOZjj2fJ3a9we/F+8 16x5GftyM79KUlDTo3+YoSalsuZfU3+b4/AJBkP+RwFusYRv93h7M9+QohySgBCnzjYdL5 y42rbUNpq++srcfyrXt0N+Demxc1lCH2a7VE/y0Vvi4bLbYlYUjd301QrvHy6w== Message-ID: <2b2a432b-7b28-4386-b5fe-d60dac09a4a2@rothenpieler.org> Date: Sun, 15 Oct 2023 03:09:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231014172428.382368-1-stefasab@gmail.com> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: <20231014172428.382368-1-stefasab@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 14.10.2023 19:24, Stefano Sabatini wrote: > Fix rendering of int values within a side data element, which was > broken since commit d2d3a83ad93, where the side data element was > correctly marked as a variable fields element. Logic to render a > string variable was implemented already, but it was not implemented > for the int fields path, which was enabled by that commit. > > Also, code and schema is changed in order to account for multiple > variable-fields elements - such as side data, contained within the > same parent. Previously it was assumed that a single variable-fields > element was contained within the parent, which was the case for tags, > but is not the case for side-data. > > Previously data was rendered as: > > > > > Now as: > > > > > > > > > > Isn't a change like that practically an ABI break, and thus would need to happen on a major bump? Alternatively, just leave the old fields as they were, they looks like they can coexist with the new ones. At least XML wise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".