Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH 3/4] aac: define a new profile for USAC
Date: Wed, 5 Jun 2024 15:08:48 +0200
Message-ID: <2b1be290-5247-43f6-8a8c-020c8ea9aae8@lynne.ee> (raw)
In-Reply-To: <GV1P250MB0737E7DB0519B7F24B1E90BF8FF92@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 1703 bytes --]

On 05/06/2024 07:33, Andreas Rheinhardt wrote:
> Lynne via ffmpeg-devel:
>> This allows users to determine whether a stream is USAC or not.
>> ---
>>   libavcodec/aac/aacdec_usac.c | 4 ++++
>>   libavcodec/avcodec.h         | 1 +
>>   libavcodec/defs.h            | 1 +
>>   libavcodec/profiles.c        | 1 +
>>   libavcodec/profiles.h        | 1 +
>>   5 files changed, 8 insertions(+)
>>
>> diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
>> index 7b36b49d63..5c3bb8d4ac 100644
>> --- a/libavcodec/aac/aacdec_usac.c
>> +++ b/libavcodec/aac/aacdec_usac.c
>> @@ -494,6 +494,8 @@ int ff_aac_usac_config_decode(AACDecContext *ac, AVCodecContext *avctx,
>>           }
>>       }
>>   
>> +    ac->avctx->profile = AV_PROFILE_AAC_USAC;
>> +
>>       ret = ff_aac_usac_reset_state(ac, oc);
>>       if (ret < 0)
>>           return ret;
>> @@ -1533,6 +1535,8 @@ int ff_aac_usac_decode_frame(AVCodecContext *avctx, AACDecContext *ac,
>>       ff_aac_output_configure(ac, ac->oc[1].layout_map, ac->oc[1].layout_map_tags,
>>                               ac->oc[1].status, 0);
>>   
>> +    ac->avctx->profile = AV_PROFILE_AAC_USAC;
>> +
>>       indep_flag = get_bits1(gb);
>>   
>>       nb_ch_el = 0;
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index 2da63c87ea..257e04fe2d 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -1652,6 +1652,7 @@ typedef struct AVCodecContext {
>>   #define FF_PROFILE_AAC_HE_V2 28
>>   #define FF_PROFILE_AAC_LD   22
>>   #define FF_PROFILE_AAC_ELD  38
>> +#define FF_PROFILE_AAC_USAC 41
> 
> Don't add new deprecated defines.

Didn't notice. Removed locally.


[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-06-05 13:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  3:08 [FFmpeg-devel] [PATCH 1/4] mpeg4audio: rename AOT_USAC_NOSBR to AOT_USAC Lynne via ffmpeg-devel
2024-06-05  3:08 ` [FFmpeg-devel] [PATCH 2/4] mpeg4audio: explicitly define each AOT Lynne via ffmpeg-devel
2024-06-05 16:16   ` James Almer
2024-06-05  3:08 ` [FFmpeg-devel] [PATCH 3/4] aac: define a new profile for USAC Lynne via ffmpeg-devel
2024-06-05  5:33   ` Andreas Rheinhardt
2024-06-05 13:08     ` Lynne via ffmpeg-devel [this message]
2024-06-05 16:18   ` James Almer
2024-06-05  3:08 ` [FFmpeg-devel] [PATCH 4/4] lavc: bump minor and add APIchanges entry for new USAC profile Lynne via ffmpeg-devel
2024-06-05 16:17   ` James Almer
2024-06-05 16:15 ` [FFmpeg-devel] [PATCH 1/4] mpeg4audio: rename AOT_USAC_NOSBR to AOT_USAC James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b1be290-5247-43f6-8a8c-020c8ea9aae8@lynne.ee \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=dev@lynne.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git