From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 91ECA4248D for ; Mon, 17 Jan 2022 20:27:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DF0068B073; Mon, 17 Jan 2022 22:27:30 +0200 (EET) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F6DF68B015 for ; Mon, 17 Jan 2022 22:27:23 +0200 (EET) Received: by mail-ot1-f44.google.com with SMTP id a10-20020a9d260a000000b005991bd6ae3eso7790828otb.11 for ; Mon, 17 Jan 2022 12:27:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=Tm3NysVUbu2LXLyuDb/kHpxM7m4Jp4RnUrjzWbMTZkQ=; b=E6gvlsfsOAe496Zc6Zz3+VDGSje7w5a6PJPR6p6VdGPsjClbcjQqLIeA+DABuIYoiq ZgPX6S4kojEVbbwhJk4+hG5v2dW/Pt7RTKhP4dJf9gn7UIwoFmYgRwz8GOHp+zRxVtsB 8fEnNRhl4Pbnk+qSt+1tdnOxY7goQSu8VJ2LCp/HKfQz04j+TqwaOO/Jwb4bwFTfbBgE yywgc5uTGD2XWIFVjYPDuZ3kVnKPM60YMxzrPm74cH47L39KYAT5PuCkoTgP1JgtQuXW WWZZqq28OyJlVR1K3iTktsn3T9fj8on84BQY/flYWeY9rTNEGezlQ1kaahd3YWqijLIm q3gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Tm3NysVUbu2LXLyuDb/kHpxM7m4Jp4RnUrjzWbMTZkQ=; b=XY9rT+I4QEvMZeUmzXnmjcMKrNc50NCsGc90Ck5DzF8jZUy9x2/LJeBwL6aTEQp1rZ Lq/JrYQpRDpBctwzftncw5Kj0MLRmp0grvU+nQI1kCAor4rwna8aghX4EeN+kjPtot4d JGZF9IPeNFjPDM41/XQjQ4FZUIRIBxpG4FjjWxKL+F8Tn7QHN1MlHVz8T0hFX6gD81ni xaGrYy8JrJK5JRmCW+YbZ4hehFx7eMSydA0A6331hPN2aN4LiAE7YRz0s1Yn3g6nBO8Q sl/1fu4ahPA1H9baCmt8s7Irg6zLlW4DbXEWXlQKt9t9KhQy4hv5In3r5Nc2A/l+B8TK TEfg== X-Gm-Message-State: AOAM532ECNEfh7VYrY35futJcnbkw9TTLGXtQ+VWxL7QfPMH3Kf4s80L +lnXqR/tgIk2PG226uZ+DuxDPc2+9SU= X-Google-Smtp-Source: ABdhPJxFwLlSHOj9yR9sidb/qduRVbbp/B+VRc0Id+4a5TnYQDMCwd9zKng6BvaDdhGIlvWAMqCnrQ== X-Received: by 2002:a05:6830:8c:: with SMTP id a12mr6516101oto.153.1642451241154; Mon, 17 Jan 2022 12:27:21 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id bb8sm6948799oib.9.2022.01.17.12.27.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 12:27:20 -0800 (PST) Message-ID: <2acf2a95-0ffa-b10d-224d-84598a707e42@gmail.com> Date: Mon, 17 Jan 2022 17:27:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220113015101.4-1-jamrial@gmail.com> <20220113015101.4-2-jamrial@gmail.com> <38842fd9-8a30-5ff0-e48c-4a70d405790c@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/17/2022 5:18 PM, Marton Balint wrote: > > > On Mon, 17 Jan 2022, James Almer wrote: > >> >> >> You're still thinking there's a distinction, when i already told you >> that there is none. I added the name field because people wanted to >> give non standard channel names, and maybe also change the standard >> ones too. It's not a label to go alongside a designation, it's *a* name. >> There are about 20 channels that have a standard name from waveformat >> and extensions, while the rest lack one. You can obviously have a non >> standard speaker setup with 50 channels, and all those extra speakers >> can surely have a name based on their position (Say, RTFC, to refer to >> "right of top front center"), so the field lets you give it to them if >> that's convenient for you and you want a pretty print output of the >> layout without seeing things like USR49. That's it. > > OK, but shouldn't the user be able to specify if it means a builtin name > or a custom name when specifying a channel name? > > That is why I suggested some additinal syntax for custom names in > av_channel_layout_index_from_string() and > av_channel_layout_channel_from_string(). Like "FL" is a builtin name, > "@name" is a custom name. > >> >> Yes, av_channel_layout_from_string() will not be able to parse the >> output of av_channel_layout_from_describe() if you gave channels a >> custom name, since they are specifically from that other layout. >> There's no way around that, as we can't make describe() output some >> string that from_string() can interpret for those because then >> describe() will be useless for printing the layout for human >> readability purposes. >> It is in fact a good reason to either remove the name field or stop >> making these helpers look at it, since describe() is meant to create >> strings from_string() can parse. >> >> I personally would do just that and keep the opaque fields alone. >> Otherwise I'll make the helpers stop looking at it, since after your >> request, non standard channels can be addressed as USR#, so you can >> create layout from strings with them just fine. > > Removing the custom names is fine with me. Maybe it's a compromise > nobody is particularly happy about. I will not remove it. It has its uses even if helpers don't make extended use of it at first. Advanced syntax can be implemented later. See my comments in v4. > > Regards, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".