From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3246644A8F for ; Wed, 2 Nov 2022 06:05:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCB1268BD4D; Wed, 2 Nov 2022 08:05:22 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8BEDA68BC71 for ; Wed, 2 Nov 2022 08:05:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667369120; x=1698905120; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=zl2P7L46qmfwvSHAHyrQydGa15ThFI2TW4Vs1F4asB4=; b=LEdvK/gjFTPQVCv2usywoyWVmPZSbBfpPHHeKp70Ujw34SCtsE4LI4Hi 7aTFeAnwsy1CBPbeL3x2Ul1BPDdDo3/SDoPxXrO4KHAe2xt6kKb18yUHU B93LQZx+My3tUrNOz1XHRufeWMtQzxGWcecf83qNQ7K9RR2UKssQfKXQr OPMuLqxqmEbnHdwblOHP0mcA6F3dfEH9JMRET5OVqAZOJh/LcZp4CiJqD Co/RtW+s6Jc35IodGnkXXGgulJkzZp2FC/eJq0zRRsaERIZKsXm+rlaQC qax9S5xPqovSgOxSMGHLmBYHk7cvw5wS5SAqnxOTxAl0xk4qud+T9oPzY w==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="308043080" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="308043080" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 23:05:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="776766992" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="776766992" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 01 Nov 2022 23:05:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 23:05:12 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 23:05:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 23:05:11 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 23:05:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmWLn2G4l/eP2N0XgV826HmStoIUuyFZ2N8QA6RgzFFYpH4g/lCYXBoz9sOW71xkVboXOGPIen3vJZDa3IrL4KvKxKA+viFCG76ju1qdtb5V/g+XjAeo7sTVZIbHc90CjlmE4IiJvbPXo2lGuempTk9mmVXEWkpmlzA7dbsvkUVL0+jVOieEX+TbolTzzhrGZmN0eG2uj2aptW6UobMxi1OzIHMFVAlsrIhxArB/J+oqudWnvui7f30NV09Cc0wP4WvJPPH8iTN1XAmq53AV4L43p0R76qHdrvjZ4MNJVtscfvT//aOk/lnaFgzNaD/J6iLKsR1nMKTkHkyRYD24YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zl2P7L46qmfwvSHAHyrQydGa15ThFI2TW4Vs1F4asB4=; b=eD/5ruVwb50jEhehVp0/YT32DshGB/bYslMpoi+WQn6hvA0yXCwNB5+SEDbDq3pCL6QpPBecyZpxsg2/fqr5dGKVjBOZiS/Em4GLL/RANAM8KAHj+DLfbMql+KH/kSHIiLX5hgMZixb2SHkeJvleKASfr+bcmGshnkcPXXOom2e38gJlraq1abVhqPNOayvMNDVWa7Q1Xk4RUgBbhpkAwoMERftjy04SQGen/025P2n7MIBQEqz9I2Tk1LokIJyP4/VYNYACXOH/9dg7G+7R8TzFzhuuzhhkgI/UdwGp/T/wCknUR3du+DZqHDPAZvahAXVhb03mSJyZXvxaYLXe8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 06:05:10 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8c4d:83ab:3e7a:3f23]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8c4d:83ab:3e7a:3f23%5]) with mapi id 15.20.5791.020; Wed, 2 Nov 2022 06:05:10 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 2/2] avcodec/vpp_qsv: Copy side data from input to output frame Thread-Index: AQHY5/0UxuRIJZ441EK+oHEhYKmTQ64pjRkAgAGIuACAABxQAA== Date: Wed, 2 Nov 2022 06:05:10 +0000 Message-ID: <2ac631bbe1ed7040d09896a01527465cbaa36456.camel@intel.com> References: <43eb3257afeb4d93bac31fe593e6edffb2a09e50.1666652664.git.ffmpegagent@gmail.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|PH0PR11MB5030:EE_ x-ms-office365-filtering-correlation-id: 4449ccb5-6198-4437-fb16-08dabc9832e0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1kw36Eiu3SkeBHilFSjv5QjDp/nS31khDB8xddygXeEyEcbobQkRCUaP7lytUc9+XpVdDVvAVIuvwzBnVEMx8M/gEIyv9nm8vZfwxI+KIt4TvaCibUdTZ04x/h89Js7l0nFuq36HqLNUYDdvfrYjuwsDMz9OYPlfyfSR/QCMEolsO4mRsNuBoy91xUIATXME7fOK6dZqNSyhfS9YUeORaU+q4+YO25EKJHgyDsNBTq5fwCXJoZzCYzi2MIdjdi4ca9PY69EMNIO6xgq4MIXHxRhu1Ip7rO4kE/HUS1tC0LdrOd2tOgYNz/0IPOA1Z9/JX/15IWh8/zsYZkVpLKxsH6FSCACw66TJHtqMkC3osyoE+32C2U5LpHAmw8pPCGQxpShQnKv2R/unddGoyDreuOQGpVgDcRZZrOt1W3JZoqUwvuIAZl7lrfU+Flv71kxIfr19pt+I7EVkqtOuBL6za6rDtennFe+buiWnrhx2s5i19ZVc9AWJ0lchz3VL9PZf0eIbfPUnL83PGm5P9Mf3iDDWElJakGoRHKHo7WUHQYSE1aLWx7NpEdZWnTKHkFpOeQZwjjakq74Qet+2el2d+tYVCe7MOLORByfB4U1UT2sdMka2oeJXZP0qBeRXachtvzsz2rbo5uwsg2uF7gzLrvss/CACBwtXJXq+vh8w1iqRaxjmL2z9q/ugz+qsGyXWzc2O3Rf8y+Ht7NyCijWAnrA4zwtXnUSnOecSkycvr8Ka+e00QW+jl+7IQP+KBRYNxYN4XsEn+iA1ODY/9xDhjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(136003)(376002)(396003)(39860400002)(451199015)(122000001)(83380400001)(71200400001)(2906002)(478600001)(82960400001)(4001150100001)(38100700002)(66946007)(38070700005)(64756008)(66556008)(66476007)(76116006)(66446008)(8676002)(91956017)(41300700001)(2616005)(186003)(86362001)(6506007)(6916009)(5660300002)(6486002)(316002)(36756003)(26005)(8936002)(6512007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WUVmVFFjd0pwelo5NlZNVTYwVHAvZ0dIa2I5cHRQUVM3aDE4aEFXVW9zNzJm?= =?utf-8?B?SU54YnRQTGhwT0pZOXV4ZzN1NC8vSytCM0pVTXFYLyt5a09CdmcyaXdWZlBD?= =?utf-8?B?aENZMU1WSUNqdFJxTS82VzNmMi9JODRNR0pDaDN5VzNwUFVINVU3NjQwOTNz?= =?utf-8?B?VTJWY0l2emh5V0RpLzVyQWwyUHM1ZGVIZzFSTHIvcnkxZHJ0cGJLSzJrMSt5?= =?utf-8?B?UzM1TzROT1FNT2FTZ1ZiVS9wQTNBNytzR2c0ckdXaEE1SEQxaGN2TGhOck5Z?= =?utf-8?B?bURHazNrdVkxaDkxeERDRGJvVnVZK1ZTblRRZzhnTUFRQWdaT2FLeWV4TzF3?= =?utf-8?B?enVpelR2Tm9UdGZ0ejZpeUZoS256akVPalJ1Wk96aFNVeDMvMFpZbGF6ZDRD?= =?utf-8?B?Z3FMMXVHUENUYnEwUEtiZTVSZ2FBMkk1SFZsL2hkQmIrem1qZTdHNFJETWlZ?= =?utf-8?B?b1Azb0lLQTdUdDhiUjdLZU9SdU1BMGdUdnNtYWxPd2Zmc01zdHVNZXdKWnhX?= =?utf-8?B?MnBSQ3RURHpVemRCSGYzbk9WVHhmNnYvZjNweFNlNUJyY2t2THhLZm1kclNl?= =?utf-8?B?S0ptWnJ5NUFGSlRmcmF0L2JMTWIwWHNnSXZFdTczSUhacld2aGZja1pRanA2?= =?utf-8?B?KzE0MU9uT2lvSnFvbk1EZzh6KzlPZVBqZFRsTzJFUGVac2MwRkYyM1N6cGNT?= =?utf-8?B?VExFek1hcTdrU1NWWTk3anVuTUlOdmNSaUtuNHpwb29QSm1RM1daV3FaVEdL?= =?utf-8?B?cVNrZlc3dXM2U0I3M0MzSDZUUFZJWGQ1SUF2SEI0U0JWYnNsTWhtRWcyNFQ5?= =?utf-8?B?dGo2MUw4bDRoeUcySk9tUEZHOUMrdnRKMGJnVm5FQUEveGltUWRVWmNEb3Vw?= =?utf-8?B?K3VKUUdOWG1LWm9OOXROTVdQbTI2N0JkYWpTOFNsVG96UTlrakRHS0NjaWIy?= =?utf-8?B?aE1qQVlma2dYaU1YR005cFJwSkpDcnZrYmRGZm94YUZNMU9ZenI4STgwTlVB?= =?utf-8?B?QVNocUxYdjhkbXplU3FqRlgzYThWbU5rTDlOSktwTUV0c0FtczhlT3VOQ1hQ?= =?utf-8?B?WnNRREhVVjQyc3FyMGdJUHUxdERnMHJOQVZYOHBCTWUzK05wSjRTOUVsUWxK?= =?utf-8?B?aGFjS1R0MDZTN3Y3UDk0cmpoOGNwWHBWb2s0eHNpcmRYV1AwZ3lsc2QwTnl6?= =?utf-8?B?eGM5UEpZZ291WTcwUzdSME1IaHcrNk14azJVeW14VDNTZWpGbWtteTlyNit2?= =?utf-8?B?ak1Ubnl0UWoza29SR3V6bFZHaWgyQ3hnODUzS2M3WDFCRlkwNEpUL0xic01u?= =?utf-8?B?Um9aMWlZZzAxa0doNjdEaWNzM2VwSlp0MFRFK0VoaWdWTkFBSENDbjVSQXNS?= =?utf-8?B?NExJb3ZEemR4N0pRcW54RDhWekpWUGZOcjY4VTlENjRIcngzMTlpTDdXZGNN?= =?utf-8?B?eGRDRi9ObHNCWXhkN24xV2UwdjdQQXE1Q0lIbTB5T2ZVUFZjZXFobFVac0RW?= =?utf-8?B?Q3BBK3lWemhDdnRuamtFYUFnanc1MzJZTmVHemMvU0gxYUVucmNhVC9aVzdo?= =?utf-8?B?WVErKzNSQzFhOHhLRXE0NEM0TXpIZDlMVExIdVYxWWlIOFVXamNMNW1tL1NE?= =?utf-8?B?emhnS1h3dXFVKytuS2hZT2l1VHVCS0xVck92WlVSUzJnOXFSZm1iSTY0QzRl?= =?utf-8?B?dTRlcGJML3AyQk9DaDFhVjdOTHFWREY1Rmx3b21wUXpiTW81akViV0hySnli?= =?utf-8?B?ZTM1djVIU0JBNzJ2VU84SHpmcmhVbXZDVXNZeU9DQit0U2l0ZlRLend5Nnpv?= =?utf-8?B?cVpqQk8xMnA0V2lPRjNvWVp2SkxzMDlnTW02Z1IwVlBIZ3FZZnRxenc5WW9r?= =?utf-8?B?VTJXcUdZN3RCcEVzNTkzai9nNzVjYnVXWjRYNEhRNm1MdTBuQnlsOVVnTkl5?= =?utf-8?B?QWdHcDI2bVg5YmhlblJLejd0NWlKK1llYXM5U2JLajg1ZjJzVDZPN2pTY2JS?= =?utf-8?B?c3F3dVc1d1dERndpbi9wUCs0UTczTmI4dnB2cGx3eGl0UGFBNk54MlZ5QjZS?= =?utf-8?B?UGQ4ZG82S1RQNVYyY0VGNFNKdmFUZ1d2SVkzd2pQL043UjRiVk05SWVDUDdn?= =?utf-8?B?WCtRZU9NbEJ6ZGM1Sk93cm1mVGh1NnRpeU1tWDczTm12MlBQeDY2M0VYUXhF?= =?utf-8?B?V3c9PQ==?= Content-ID: <622DB5D35AC10A4AA4CA9EB029E0DF6F@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4449ccb5-6198-4437-fb16-08dabc9832e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 06:05:10.0377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wpnQ8pHDjpY/tKEGAP/yK81JZE4ZesGdexhBHWoGfUUp8q416lq0yV5PujCOUb5nTe7BuOtX4TvURQFLqxUwQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5030 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vpp_qsv: Copy side data from input to output frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-11-02 at 05:23 +0100, Andreas Rheinhardt wrote: > Xiang, Haihao: > > On Mon, 2022-10-24 at 23:04 +0000, softworkz wrote: > > > From: softworkz > > > > > > Signed-off-by: softworkz > > > --- > > > libavfilter/qsvvpp.c | 6 ++++++ > > > libavfilter/vf_overlay_qsv.c | 19 +++++++++++++++---- > > > 2 files changed, 21 insertions(+), 4 deletions(-) > > > > > > diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c > > > index 8428ee89ab..ae9766d12f 100644 > > > --- a/libavfilter/qsvvpp.c > > > +++ b/libavfilter/qsvvpp.c > > > @@ -880,6 +880,12 @@ int ff_qsvvpp_filter_frame(QSVVPPContext *s, > > > AVFilterLink > > > *inlink, AVFrame *picr > > > return AVERROR(EAGAIN); > > > break; > > > } > > > + > > > + av_frame_remove_all_side_data(out_frame->frame); > > > + ret = av_frame_copy_side_data(out_frame->frame, in_frame->frame, > > > 0); > > > + if (ret < 0) > > > + return ret; > > > + > > > out_frame->frame->pts = av_rescale_q(out_frame- > > > > surface.Data.TimeStamp, > > > default_tb, outlink- > > > >time_base); > > > > > > diff --git a/libavfilter/vf_overlay_qsv.c b/libavfilter/vf_overlay_qsv.c > > > index d947a1faa1..04fd284b92 100644 > > > --- a/libavfilter/vf_overlay_qsv.c > > > +++ b/libavfilter/vf_overlay_qsv.c > > > @@ -231,13 +231,24 @@ static int process_frame(FFFrameSync *fs) > > > { > > > AVFilterContext *ctx = fs->parent; > > > QSVOverlayContext *s = fs->opaque; > > > + AVFrame *frame0 = NULL; > > > AVFrame *frame = NULL; > > > - int ret = 0, i; > > > + int ret = 0; > > > > > > - for (i = 0; i < ctx->nb_inputs; i++) { > > > + for (unsigned i = 0; i < ctx->nb_inputs; i++) { > > > ret = ff_framesync_get_frame(fs, i, &frame, 0); > > > - if (ret == 0) > > > - ret = ff_qsvvpp_filter_frame(s->qsv, ctx->inputs[i], frame); > > > + > > > + if (ret == 0) { > > > + if (i == 0) > > > + frame0 = frame; > > > + else { > > > + av_frame_remove_all_side_data(frame); > > > + ret = av_frame_copy_side_data(frame, frame0, 0); > > > + } > > > + > > > + ret = ret < 0 ? ret : ff_qsvvpp_filter_frame(s->qsv, ctx- > > > > inputs[i], frame); > > > + } > > > + > > > if (ret < 0 && ret != AVERROR(EAGAIN)) > > > break; > > > } > > > > Patchset LGTM, I'll push this patchset if no more comment or objection. > > > > Can you wait a few days on this? I'd like to take a look at #1. Sure ofc, I can wait until no more comments about this patchset. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".