[FFmpeg-devel] [PATCH 0/1] Make "File exists" exit w/ non-zero status

[FFmpeg-devel] [PATCH 0/1] Make "File exists" exit w/ non-zero status

[Dabrien 'Dabe' Murphy]

I'm not sure if it was by design or just an oversight, but it seems
"unexpected" that ffmpeg (without `-y`) to an existing file calls
`exit(0)`, even though it prints a "fatal" error...

The attached patch itself is trivial, but like I say, maybe there was
a reason for the current behavior that I'm just not aware of.

Cheers!


dabe (1):
   fftools/ffmpeg_opt: Exit with non-zero status when destination exists

  fftools/ffmpeg_opt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

-- 2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

[Dabrien 'Dabe' Murphy]

---
  fftools/ffmpeg_opt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 2c201c74b2..dddf7c6475 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -604,13 +604,13 @@ int assert_file_overwrite(const char *filename)
                  signal(SIGINT, SIG_DFL);
                  if (!read_yesno()) {
                      av_log(NULL, AV_LOG_FATAL, "Not overwriting - exiting\n");
-                    return AVERROR_EXIT;
+                    return AVERROR(EEXIST);
                  }
                  term_init();
              }
              else {
                  av_log(NULL, AV_LOG_FATAL, "File '%s' already exists. Exiting.\n", filename);
-                return AVERROR_EXIT;
+                return AVERROR(EEXIST);
              }
          }
      }
-- 2.45.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

[Gyan Doshi]

On 2024-07-15 06:26 pm, Dabrien 'Dabe' Murphy wrote:
> ---
>  fftools/ffmpeg_opt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 2c201c74b2..dddf7c6475 100644
> --- a/fftools/ffmpeg_opt.c
> +++ b/fftools/ffmpeg_opt.c
> @@ -604,13 +604,13 @@ int assert_file_overwrite(const char *filename)
>                  signal(SIGINT, SIG_DFL);
>                  if (!read_yesno()) {
>                      av_log(NULL, AV_LOG_FATAL, "Not overwriting - 
> exiting\n");
> -                    return AVERROR_EXIT;
> +                    return AVERROR(EEXIST);
>                  }
>                  term_init();
>              }
>              else {
>                  av_log(NULL, AV_LOG_FATAL, "File '%s' already exists. 
> Exiting.\n", filename);
> -                return AVERROR_EXIT;
> +                return AVERROR(EEXIST);

The former is not an error. The user was asked and the application 
behaved as per their reply.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

[Marth64]

Gyan:
> The former is not an error. The user was asked and the application
> behaved as per their reply.
Could it make sense to only return the AVERROR(EEXIST) if -nostdin is
passed (otherwise current behavior)?
I have observed this behavior too and think it's strange only in the
-nostdin case.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

[Gyan Doshi]

On 2024-07-16 09:40 am, Marth64 wrote:
> Gyan:
>> The former is not an error. The user was asked and the application
>> behaved as per their reply.
> Could it make sense to only return the AVERROR(EEXIST) if -nostdin is
> passed (otherwise current behavior)?

Agreed.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

[Marth64]

> On 2024-07-16 09:40 am, Marth64 wrote:
> > Gyan:
> >> The former is not an error. The user was asked and the application
> >> behaved as per their reply.
> > Could it make sense to only return the AVERROR(EEXIST) if -nostdin is
> > passed (otherwise current behavior)?
>
> Agreed.

Planning to send a patch for this in the next few days. Thank you.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

[Leo Izen]

On 2/5/25 11:14 AM, Marth64 wrote:
>> behaved as per their reply.
> Could it make sense to only return the AVERROR(EEXIST) if -nostdin is

If you do, you should consider not just -nostdin but also if reading 
from stdin like a pipe, e.g. ffmpeg -i - .... foo.mkv
this will exit with success if foo.mkv exists without asking on stdin 
(as you'd expect it to not, cause it's reading from stdin)

- Leo Izen (Traneptora)


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".