On 1/31/2025 11:01 PM, Michael Niedermayer wrote:
> On Fri, Jan 31, 2025 at 10:45:13PM -0300, James Almer wrote:
>> On 1/31/2025 10:43 PM, Michael Niedermayer wrote:
>>> On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote:
>>>> Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after
>>>> e78173557da898f18a78241cc3525b76694164b5 broke setting channel count.
>>>>
>>>> Should fix ticket #11434.
>>>>
>>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>>> ---
>>>>    libavdevice/alsa.h          |  4 ++++
>>>>    libavdevice/alsa_dec.c      | 24 +++++++++++++++++++-----
>>>>    libavdevice/version_major.h |  1 +
>>>>    3 files changed, 24 insertions(+), 5 deletions(-)
>>>
>>> seems not to build on its own (if its intended to)
>>
>> I can't test, so i wrote it blindly.
>>
>>>
>>> libavdevice/alsa_dec.c:163:59: error: ‘AV_OPT_TYPE_CH_LAYOUT’ undeclared here (not in a function); did you mean ‘AV_OPT_TYPE_CHLAYOUT’?
>>>     163 |     { "ch_layout",   "", offsetof(AlsaData, ch_layout),   AV_OPT_TYPE_CH_LAYOUT, {.str = "2C"}, INT_MIN, INT_MAX, AV_OPT_FLAG_DECODING_PARAM },
>>>         |                                                           ^~~~~~~~~~~~~~~~~~~~~
>>>         |                                                           AV_OPT_TYPE_CHLAYOUT
>>
>> Is that the only error? Can you check if it compiles if you fix that typo?
> 
> builds and passes fate
> 
> happy to be able to help

Applied, thanks.