From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option
Date: Sat, 1 Feb 2025 01:23:12 -0300
Message-ID: <2a946442-2cf0-458c-b2c7-63009093baf8@gmail.com> (raw)
In-Reply-To: <20250201020121.GK4991@pb2>
[-- Attachment #1.1.1: Type: text/plain, Size: 1484 bytes --]
On 1/31/2025 11:01 PM, Michael Niedermayer wrote:
> On Fri, Jan 31, 2025 at 10:45:13PM -0300, James Almer wrote:
>> On 1/31/2025 10:43 PM, Michael Niedermayer wrote:
>>> On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote:
>>>> Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after
>>>> e78173557da898f18a78241cc3525b76694164b5 broke setting channel count.
>>>>
>>>> Should fix ticket #11434.
>>>>
>>>> Signed-off-by: James Almer <jamrial@gmail.com>
>>>> ---
>>>> libavdevice/alsa.h | 4 ++++
>>>> libavdevice/alsa_dec.c | 24 +++++++++++++++++++-----
>>>> libavdevice/version_major.h | 1 +
>>>> 3 files changed, 24 insertions(+), 5 deletions(-)
>>>
>>> seems not to build on its own (if its intended to)
>>
>> I can't test, so i wrote it blindly.
>>
>>>
>>> libavdevice/alsa_dec.c:163:59: error: ‘AV_OPT_TYPE_CH_LAYOUT’ undeclared here (not in a function); did you mean ‘AV_OPT_TYPE_CHLAYOUT’?
>>> 163 | { "ch_layout", "", offsetof(AlsaData, ch_layout), AV_OPT_TYPE_CH_LAYOUT, {.str = "2C"}, INT_MIN, INT_MAX, AV_OPT_FLAG_DECODING_PARAM },
>>> | ^~~~~~~~~~~~~~~~~~~~~
>>> | AV_OPT_TYPE_CHLAYOUT
>>
>> Is that the only error? Can you check if it compiles if you fix that typo?
>
> builds and passes fate
>
> happy to be able to help
Applied, thanks.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-01 4:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 12:57 James Almer
2025-02-01 1:43 ` Michael Niedermayer
2025-02-01 1:45 ` James Almer
2025-02-01 2:01 ` Michael Niedermayer
2025-02-01 4:23 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a946442-2cf0-458c-b2c7-63009093baf8@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git