From: Brad Smith <brad-at-comstyle.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
Date: Fri, 11 Aug 2023 19:49:39 -0400
Message-ID: <2a356e6e-239a-b8f1-ffc9-8553dade6320@comstyle.com> (raw)
In-Reply-To: <ZNGUG6ImNlP70KVH@humpty.home.comstyle.com>
Just FYI, we have had this in the OpenBSD and FreeBSD packages for quite
awhile
to be able to build on powerpc64.
On 2023-08-07 9:02 p.m., Brad Smith wrote:
> lsws/ppc/yuv2rgb_altivec: Fix build in non-VSX environments with Clang
>
> libswscale/ppc/yuv2rgb_altivec.c:288:36: error: redeclaration of 'vec_xl' must have the 'overloadable' attribute
> ---
> libswscale/ppc/yuv2rgb_altivec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libswscale/ppc/yuv2rgb_altivec.c b/libswscale/ppc/yuv2rgb_altivec.c
> index 5e1033a973..6ef2441d8a 100644
> --- a/libswscale/ppc/yuv2rgb_altivec.c
> +++ b/libswscale/ppc/yuv2rgb_altivec.c
> @@ -284,7 +284,7 @@ static inline void cvtyuvtoRGB(SwsContext *c, vector signed short Y,
> * ------------------------------------------------------------------------------
> */
>
> -#if !HAVE_VSX
> +#if !HAVE_VSX && !defined(__clang__)
> static inline vector unsigned char vec_xl(signed long long offset, const ubyte *addr)
> {
> const vector unsigned char *v_addr = (const vector unsigned char *) (addr + offset);
> @@ -292,7 +292,7 @@ static inline vector unsigned char vec_xl(signed long long offset, const ubyte *
>
> return (vector unsigned char) vec_perm(v_addr[0], v_addr[1], align_perm);
> }
> -#endif /* !HAVE_VSX */
> +#endif /* !HAVE_VSX && !__clang__ */
>
> #define DEFCSP420_CVT(name, out_pixels) \
> static int altivec_ ## name(SwsContext *c, const unsigned char **in, \
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-08-11 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 1:02 Brad Smith
2023-08-11 23:49 ` Brad Smith [this message]
2023-08-12 15:19 ` Michael Niedermayer
2023-08-18 19:32 Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a356e6e-239a-b8f1-ffc9-8553dade6320@comstyle.com \
--to=brad-at-comstyle.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git