[FFmpeg-devel] Re: [PATCH] lavf/whip: improve RTP muxer error message

[Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

> On Jan 30, 2026, at 13:32, Devraj Ajmera via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
>> configure already deps the rtp_muxer via whip_muxer_select, so it should
> never hit this error.
> 
>> So maybe use av_unreachable() to replace current error handling?
> 
> That makes sense. Since configure already enforces the RTP dependency via
> whip_muxer_select, this code path should indeed be unreachable at runtime.
> 
> I have updated the code to replace the current error handling with
> av_unreachable() accordingly, and will send an updated patch reflecting
> this change.
> 
> Regards,
> Devraj
> 
> From 6f8fdbb6fdc448a93b7405e9e835e20c72183be0 Mon Sep 17 00:00:00 2001
> From: devraj ajmera <devrajajmera077@gmail.com>
> Date: Fri, 30 Jan 2026 10:06:27 +0530
> Subject: [PATCH] lavf/whip: mark RTP muxer lookup as unreachable
> 
> ---
>  libavformat/whip.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/whip.c b/libavformat/whip.c
> index c3507405fa..4ff32a1a3c 100644
> --- a/libavformat/whip.c
> +++ b/libavformat/whip.c
> @@ -1550,10 +1550,8 @@ static int create_rtp_muxer(AVFormatContext *s)
>  
>      const AVOutputFormat *rtp_format = av_guess_format("rtp", NULL, NULL);
>      if (!rtp_format) {
> -        av_log(whip, AV_LOG_ERROR,"Failed to guess RTP muxer, ensure RTP is enabled in build\n");
> -        ret = AVERROR(ENOSYS);
> -        goto end;
> -    }
> +    av_unreachable();
> +}

I think the av_unreachable() should be used with a reason

So maybe av_unreachable(“RTP muxer should be enabled”);

BTW, it seems you use wrong indent here.

>  
>      /* The UDP buffer size, may greater than MTU. */
>      buffer_size = MAX_UDP_BUFFER_SIZE;
> -- 
> 2.52.0.windows.1


_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org