From: Jack Lau <jacklau1222gm@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment
Date: Mon, 10 Feb 2025 11:33:28 +0800
Message-ID: <2F106CFD-4C9D-46B8-9D60-12D0537BB2F4@gmail.com> (raw)
In-Reply-To: <CAAhd_PWSeaSPLZdq+yqTetxdQsB0jFOHEbjbh44-s45ZsqT3rg@mail.gmail.com>
> On Feb 10, 2025, at 11:08, Marth64 <marth64@proxyid.net> wrote:
>
> I don't think its fair to shoot this down, its a simple but valid tidy up work.
> I find typos and such when browsing code distracting and readability
> important down the road.
> Not everyone's first language is English and grammar correction may
> not come instinctively.
>
> Thank you for the contribution Jack. Unless there is any objection on
> grounds of maintaining commit history, I'll adjust the grammar of
> "need to setting" -> "we need to set" and push this soon.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.
Hi Marth,
Thanks very much for your reply. I feel the warmth of the open-source community. I indeed did not notice this grammar issue, and I will be more careful next time.
It's hard to express my gratitude in words.🥹
Best regards,
Jack
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-02-10 3:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 0:33 Jack Lau via ffmpeg-devel
2025-02-10 0:54 ` Soft Works
2025-02-10 1:12 ` Jack Lau
2025-02-10 1:36 ` Soft Works
2025-02-10 1:46 ` Jack Lau
2025-02-10 3:08 ` Marth64
2025-02-10 3:33 ` Jack Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2F106CFD-4C9D-46B8-9D60-12D0537BB2F4@gmail.com \
--to=jacklau1222gm@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git