Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display - Rémi Denis-Courmont

From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display
Date: Fri, 07 Jun 2024 09:45:09 +0300
Message-ID: <2E76C656-4093-4901-B314-C61BAE6CDA15@remlab.net> (raw)
In-Reply-To: <CACW1+SZhSa==X144WtzT2FSzzd-sAEcEA8uGxraZ7w6FAKfxOA@mail.gmail.com>

Hi,

Le 7 juin 2024 06:33:20 GMT+03:00, Shiqi Zhu <hiccupzhu@gmail.com> a écrit :
>> Initialization and render in the same thread is one of the issues. Another
>> issue is SDL render should be run in main thread. Maybe it’s not the
>> duty of this filter to control which thread to be called, but this wouldn’t
>> work with ffmpeg cmd.
>>
>Yes, I agree with your opinion. The control of the filter should be
>left to the application, and the ffmpeg command should only serve the
>purpose of demonstrating functionality.

You can't require running on the main thread. There are no ifs or buts here; libavfilter simply can't require that from the calling application or upper-layer framework and therefore it also can't warrant it to SDL.

SDL is meant to be used by programs, notably games, not middleware thread-agnostic libraries like FFmpeg's libav*. I don't think that there is a point arguing *again*.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".