From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D1481479C8 for ; Mon, 27 Jan 2025 20:18:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4779568BCE2; Mon, 27 Jan 2025 22:18:54 +0200 (EET) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5848A68B44A for ; Mon, 27 Jan 2025 22:18:47 +0200 (EET) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-388cae9eb9fso2867203f8f.3 for ; Mon, 27 Jan 2025 12:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datarhei.com; s=google; t=1738009126; x=1738613926; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=7SSwlyaBzkDKFUvAH57l3OK76eA+nMU/AhxcP4ktKqs=; b=Uk6928WIaZoKPp9hU2dRSGbAro1SZ7k0u0o9x0BT+DUv8XhHfF4n9NNZRO4pvWnr6k XlNbaigv5a8V23DAUGcQYj2GALcs/Xd7KuOgWRMGcma/DJsqjw5y7g/p0fwQHhv65UNT WcTiTsxktXud1V4f+ncjcRMpfRP7QMjUa1XkzSdljSl+LdbMqWpH6/9oniZmihTACCM5 sXLT9uNO4lrmpsROmLMTz+zLCyrsZmMu0Kcx4WEeBbELoi5kgk1kQ61nGu4QJK9LAVQ/ Gw9QgR9dpugmDETi7UwWPZs4VeYMHeZ+ZAzWFV8m5CVOYVvmam7MeF6qADf2/O1FYAJs 3GBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738009126; x=1738613926; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7SSwlyaBzkDKFUvAH57l3OK76eA+nMU/AhxcP4ktKqs=; b=pcWw1YPtmt4yqR5+VJ4/R91VAcQPBo69FkHzgWIvbLr2Aq9o8sRfnFxIOCZCxc2lFA 48b/bFbMS7OE7wdDuLkEYSmKHSRDXobo1Oz1KL7z9YSQlXuS6qd6ff2tGhAseooPR84x AmwQRdMcR14AZDugt6bLnRfnVHwqo1Jw55EJP1d6nmfiYRQrblIA56Hw9yaV7SA332uV RQPnBcfPmqowrctS6rknEJrK1RF79fzHhU7ZiGgd8J7nirjbwo25/omgNKUDtdQvUnQq QkpIA9wbhiElX2kMYwNLN6A9XIbImXYQtCPMNRR1ejUX14ghAjJ8f6fOEe9e4XlONnZV B3og== X-Gm-Message-State: AOJu0YzpSBpTCX8fFVJg6XIgGuiYtqK/ZVgFutprFYT9AZJjeYzQdADG +BdDLONYA3FeoZMzkXVI+wF+gThLmEoCmOq0pNbSpMs2Vu6TuEvqnP/sp5WfmUXnSM9rV4PBDqM = X-Gm-Gg: ASbGncvTQqePJ5CBmuow9Q1tAlvn3U5pFx+VrNSDE4KDoaER8FxIhUnpUtoMr2Ros+3 VVbwtXQzt3OCJXDVR0KNQUkyDL3JknazMy4N04wITXcu66cq8ip9rIE5jfCfEkYh+v3g0kaOI74 kmxXBEzKPf8ooV1FsT/fLeCncapZ3rryiQ3e/fPRu4mKiJwrluRt721xucGj+6yeJUeoBS+WEau agmnhwb0lobjVg2Oal/TbxXzTfHcIuVECMGmI4ITRXGfDxQxFJi05yQrlBajeRZC1JSS7VUcFyy Sicxtpo/t4XrLPSicM1OB3wj X-Google-Smtp-Source: AGHT+IFGRWqpk7mtQC3+LaOqxJcXU6Wp8D5H5CrmaQdnsU3W/X0IjLKujnPGYi0HpvwPLzildRUvqQ== X-Received: by 2002:a5d:4590:0:b0:385:ee40:2d75 with SMTP id ffacd0b85a97d-38bf566283emr27379003f8f.20.1738009125935; Mon, 27 Jan 2025 12:18:45 -0800 (PST) Received: from smtpclient.apple ([2a04:ee41:4:b3b0:49c0:cd01:9cb2:8ed6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188a77sm12274538f8f.51.2025.01.27.12.18.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jan 2025 12:18:45 -0800 (PST) From: Ingo Oppermann Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Mon, 27 Jan 2025 21:18:35 +0100 References: <20250124115910.3550-1-ingo@datarhei.com> To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <2D38272E-B448-4731-A4DB-BA4B2E37E1F4@datarhei.com> X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH v1] avformat/hlsenc: fix hls_time not respected X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On 27 Jan 2025, at 11:41, Gyan Doshi wrote: > > > > On 2025-01-27 01:56 pm, Ingo Oppermann wrote: >>> On 24 Jan 2025, at 16:30, Gyan Doshi wrote: >>> >>> >>> >>> On 2025-01-24 05:29 pm, Ingo Oppermann wrote: >>>> This fixes the criterion when to split the segments based on the elapsed time >>>> for the current segment instead of using the theoretical elapsed time since >>>> start based on hls_time and the number of written segments. >>>> >>>> hls_time is used to define the minimum length of a segment, however this is >>>> not respected in all cases when a stream has variable GOP sizes. >>>> >>>> Imagine a stream starts with a key frame every 10 seconds for e.g. 40 seconds. >>>> After that, key frames will come every second. This will result in segments >>>> that are first 10 seconds, then 1 second for some time and later 2 seconds as >>>> expected. >>> Better to make it flexible like how the segment muxer does it, by having an optional minimum segment duration parameter. Then it's upto the user. >>> See d39b34123d. >> According to the documentation "hls_time" is already supposed to be the minimum duration of a segment: "Segment will be cut on the next key frame after this time has passed." (https://ffmpeg.org/ffmpeg-formats.html#Options-26). > > In practice, the logic used is that segment X, counting from 0, should start at X*hls_time. It's not best practice to change long-standing behaviour without a fallback or workaround. Your patch doesn't offer that. > HLS is usually a multiple representation format, so this may adversely affect rendition switchability. Adding an option like segment muxer won't change the outcome of existing command lines but will still allow you the behaviour you're looking for. That's true. Changing the current behaviour might break existing processes that are based on this specific behaviour. I'll add a new option then. > > Regards, > Gyan > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".