From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 01C854376E for ; Wed, 25 Jan 2023 05:17:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF8DC68BEAA; Wed, 25 Jan 2023 07:17:46 +0200 (EET) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A767268BC9B for ; Wed, 25 Jan 2023 07:17:38 +0200 (EET) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4P1sXv3TDCz9sV3 for ; Wed, 25 Jan 2023 06:17:35 +0100 (CET) Message-ID: <29fe7152-55a9-8354-b018-60d4ac6e8681@gyani.pro> Date: Wed, 25 Jan 2023 10:47:20 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230125010744.255455-1-stefasab@gmail.com> From: Gyan Doshi In-Reply-To: <20230125010744.255455-1-stefasab@gmail.com> X-Rspamd-Queue-Id: 4P1sXv3TDCz9sV3 Subject: Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-01-25 06:37 am, Stefano Sabatini wrote: > --- > doc/ffmpeg.texi | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index 67b3294256..122f7e3387 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi > @@ -1823,8 +1823,21 @@ results, but increase memory use and latency. > > The default value is 10 seconds. > > -@item -dts_delta_threshold > -Timestamp discontinuity delta threshold. > +@item -dts_delta_threshold @var{threshold} > +Timestamp discontinuity delta threshold, expressed as a floating point > +number of @var{AV_TIME_BASE} units. This is a CLI option and those users don't deal with AV_TIME_BASE . More useful to say it's in seconds. > + > +If a timestamp discontinuity is detected whose absolute value is > +greater than @var{threshold} * @var{AV_TIME_BASE}, ffmpeg will remove the > +discontinuity by decreasing/increasing the current DTS and PTS by the > +corresponding delta value. Might want to mention that this only applies to AV_FMT_DISCONT demuxers, or rather give a few examples, like MPEG-TS, HLS..etc. For all other formats that users normally work with, clarify that only dts_error_threshold is relevant. > + > +Timestamp discontinuity correction can be inhibited by setting a big value for > +@var{threshold}, and is automatically disabled when employing the > +@code{-copy_ts} option. For copy_ts, it is still applied for all negative deltas except the smallest. Not blocking, but I'm reworking this code at present. Shouldn't really affect this patch. See https://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305539.html Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".