Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description
Date: Wed, 25 Jan 2023 10:47:20 +0530
Message-ID: <29fe7152-55a9-8354-b018-60d4ac6e8681@gyani.pro> (raw)
In-Reply-To: <20230125010744.255455-1-stefasab@gmail.com>



On 2023-01-25 06:37 am, Stefano Sabatini wrote:
> ---
>   doc/ffmpeg.texi | 17 +++++++++++++++--
>   1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 67b3294256..122f7e3387 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@ -1823,8 +1823,21 @@ results, but increase memory use and latency.
>   
>   The default value is 10 seconds.
>   
> -@item -dts_delta_threshold
> -Timestamp discontinuity delta threshold.
> +@item -dts_delta_threshold @var{threshold}
> +Timestamp discontinuity delta threshold, expressed as a floating point
> +number of @var{AV_TIME_BASE} units.
This is a CLI option and those users don't deal with AV_TIME_BASE . More 
useful to say it's in seconds.

> +
> +If a timestamp discontinuity is detected whose absolute value is
> +greater than @var{threshold} * @var{AV_TIME_BASE}, ffmpeg will remove the
> +discontinuity by decreasing/increasing the current DTS and PTS by the
> +corresponding delta value.

Might want to mention that this only applies to AV_FMT_DISCONT demuxers, 
or rather give a few examples, like MPEG-TS, HLS..etc.
For all other formats that users normally work with, clarify that only 
dts_error_threshold is relevant.

> +
> +Timestamp discontinuity correction can be inhibited by setting a big value for
> +@var{threshold}, and is automatically disabled when employing the
> +@code{-copy_ts} option.

For copy_ts, it is still applied for all negative deltas except the 
smallest.

Not blocking, but I'm reworking this code at present. Shouldn't really 
affect this patch. See 
https://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305539.html

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-01-25  5:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  1:07 Stefano Sabatini
2023-01-25  5:17 ` Gyan Doshi [this message]
2023-02-06  1:25   ` Stefano Sabatini
2023-02-06  4:31     ` Gyan Doshi
2023-02-08 23:41     ` Michael Niedermayer
2023-02-11  2:30       ` Stefano Sabatini
2023-02-11 16:28         ` Stefano Sabatini
2023-02-11 16:56           ` Gyan Doshi
2023-02-20 17:57         ` Anton Khirnov
2023-02-28 21:32           ` Stefano Sabatini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29fe7152-55a9-8354-b018-60d4ac6e8681@gyani.pro \
    --to=ffmpeg@gyani.pro \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git