Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files

From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files
Date: Wed, 19 Mar 2025 15:43:29 +0530
Message-ID: <29680afd-d1f3-411a-bd2d-2ac812511fd2@gyani.pro> (raw)
In-Reply-To: <6be2af6-5630-c39c-4cc-b95d2f1b94b1@martin.st>

On 2025-03-19 02:54 pm, Martin Storsjö wrote:
> On Tue, 18 Mar 2025, Gyan Doshi wrote:
>
>> ---
>> configure | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure b/configure
>> index d84e32196d..14f7bcde0e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5230,12 +5230,6 @@ else
>>     ar_o='$@'
>> fi
>>
>> -if $ar 2>&1 | grep -qi  "@.*file"; then
>> -    ar_objs="true"
>> -else
>> -    ar_objs=""
>> -fi
>> -
>> add_cflags $extra_cflags
>> add_cxxflags $extra_cxxflags
>> add_objcflags $extra_objcflags
>> @@ -7759,6 +7753,13 @@ case $ld_type in
>>     ;;
>> esac
>>
>> +{
>> +ar_out=${FFTMPDIR}/test$LIBSUF
>> +respfile="@/dev/null"
>> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
>> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || 
>> ar_objs=""
>> +}
>> +
>> enable frame_thread_encoder
>
> LGTM, thanks!

Thanks. Pushed as b75b568b3d290ce827b80568ced1d68c277309e6

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".