[FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required

[FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required

[J. Dekker]

Signed-off-by: J. Dekker <jdek@itanimul.li>
---
 libavfilter/riscv/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/riscv/Makefile b/libavfilter/riscv/Makefile
index 0b968a9c0d..277dde2aed 100644
--- a/libavfilter/riscv/Makefile
+++ b/libavfilter/riscv/Makefile
@@ -1,2 +1,2 @@
-OBJS += riscv/af_afir_init.o
-RVV-OBJS += riscv/af_afir_rvv.o
+OBJS-$(CONFIG_AFIR_FILTER)                   += riscv/af_afir_init.o
+RVV-OBJS-$(CONFIG_AFIR_FILTER)               += riscv/af_afir_rvv.o
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

[J. Dekker]

Signed-off-by: J. Dekker <jdek@itanimul.li>
---
 tests/checkasm/h264dsp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c
index 0f484e3f43..5cb646ae49 100644
--- a/tests/checkasm/h264dsp.c
+++ b/tests/checkasm/h264dsp.c
@@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth)
 
 static void check_idct(void)
 {
+    static const int depths[5] = { 8, 9, 10, 12, 14 };
     LOCAL_ALIGNED_16(uint8_t, src,  [8 * 8 * 2]);
     LOCAL_ALIGNED_16(uint8_t, dst,  [8 * 8 * 2]);
     LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]);
@@ -181,10 +182,11 @@ static void check_idct(void)
     LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]);
     LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]);
     H264DSPContext h;
-    int bit_depth, sz, align, dc;
+    int bit_depth, sz, align, dc, i;
     declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, int stride);
 
-    for (bit_depth = 8; bit_depth <= 10; bit_depth++) {
+    for (i = 0; i < 5; i++) {
+        bit_depth = depths[i];
         ff_h264dsp_init(&h, bit_depth, 1);
         for (sz = 4; sz <= 8; sz += 4) {
             randomize_buffers();
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/riscv: build afir only if required

[Rémi Denis-Courmont]

Le keskiviikkona 24. huhtikuuta 2024, 17.09.43 EEST J. Dekker a écrit :
> Signed-off-by: J. Dekker <jdek@itanimul.li>
> ---
>  libavfilter/riscv/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/riscv/Makefile b/libavfilter/riscv/Makefile
> index 0b968a9c0d..277dde2aed 100644
> --- a/libavfilter/riscv/Makefile
> +++ b/libavfilter/riscv/Makefile
> @@ -1,2 +1,2 @@
> -OBJS += riscv/af_afir_init.o
> -RVV-OBJS += riscv/af_afir_rvv.o
> +OBJS-$(CONFIG_AFIR_FILTER)                   += riscv/af_afir_init.o
> +RVV-OBJS-$(CONFIG_AFIR_FILTER)               += riscv/af_afir_rvv.o

LGTM

-- 
レミ・デニ-クールモン
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

[Rémi Denis-Courmont]

Le keskiviikkona 24. huhtikuuta 2024, 17.09.44 EEST J. Dekker a écrit :
> Signed-off-by: J. Dekker <jdek@itanimul.li>
> ---
>  tests/checkasm/h264dsp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c
> index 0f484e3f43..5cb646ae49 100644
> --- a/tests/checkasm/h264dsp.c
> +++ b/tests/checkasm/h264dsp.c
> @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth)
> 
>  static void check_idct(void)
>  {
> +    static const int depths[5] = { 8, 9, 10, 12, 14 };
>      LOCAL_ALIGNED_16(uint8_t, src,  [8 * 8 * 2]);
>      LOCAL_ALIGNED_16(uint8_t, dst,  [8 * 8 * 2]);
>      LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]);
> @@ -181,10 +182,11 @@ static void check_idct(void)
>      LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]);
>      LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]);
>      H264DSPContext h;
> -    int bit_depth, sz, align, dc;
> +    int bit_depth, sz, align, dc, i;
>      declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block,
> int stride);
> 
> -    for (bit_depth = 8; bit_depth <= 10; bit_depth++) {
> +    for (i = 0; i < 5; i++) {
> +        bit_depth = depths[i];
>          ff_h264dsp_init(&h, bit_depth, 1);
>          for (sz = 4; sz <= 8; sz += 4) {
>              randomize_buffers();

Fine with me, but then again, this is not RISC-V-specific, and other people are 
ostensibly better for reviewing checkasm changes.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

[Devin Heitmueller]

On Wed, Apr 24, 2024 at 10:10 AM J. Dekker <jdek@itanimul.li> wrote:
>
> Signed-off-by: J. Dekker <jdek@itanimul.li>
> ---
>  tests/checkasm/h264dsp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c
> index 0f484e3f43..5cb646ae49 100644
> --- a/tests/checkasm/h264dsp.c
> +++ b/tests/checkasm/h264dsp.c
> @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth)
>
>  static void check_idct(void)
>  {
> +    static const int depths[5] = { 8, 9, 10, 12, 14 };
>      LOCAL_ALIGNED_16(uint8_t, src,  [8 * 8 * 2]);
>      LOCAL_ALIGNED_16(uint8_t, dst,  [8 * 8 * 2]);
>      LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]);
> @@ -181,10 +182,11 @@ static void check_idct(void)
>      LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]);
>      LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]);
>      H264DSPContext h;
> -    int bit_depth, sz, align, dc;
> +    int bit_depth, sz, align, dc, i;
>      declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, int stride);
>
> -    for (bit_depth = 8; bit_depth <= 10; bit_depth++) {
> +    for (i = 0; i < 5; i++) {
> +        bit_depth = depths[i];

Perhaps this should use FF_ARRAY_ELEMS(depths) rather than a hard-coded "5"?

Devin

-- 
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com  e: devin.heitmueller@ltnglobal.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

[J. Dekker]

Devin Heitmueller <devin.heitmueller@ltnglobal.com> writes:

> On Wed, Apr 24, 2024 at 10:10 AM J. Dekker <jdek@itanimul.li> wrote:
>>
>> Signed-off-by: J. Dekker <jdek@itanimul.li>
>> ---
>>  tests/checkasm/h264dsp.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c
>> index 0f484e3f43..5cb646ae49 100644
>> --- a/tests/checkasm/h264dsp.c
>> +++ b/tests/checkasm/h264dsp.c
>> @@ -173,6 +173,7 @@ static void dct8x8(int16_t *coef, int bit_depth)
>>
>>  static void check_idct(void)
>>  {
>> +    static const int depths[5] = { 8, 9, 10, 12, 14 };
>>      LOCAL_ALIGNED_16(uint8_t, src,  [8 * 8 * 2]);
>>      LOCAL_ALIGNED_16(uint8_t, dst,  [8 * 8 * 2]);
>>      LOCAL_ALIGNED_16(uint8_t, dst0, [8 * 8 * 2]);
>> @@ -181,10 +182,11 @@ static void check_idct(void)
>>      LOCAL_ALIGNED_16(int16_t, subcoef0, [8 * 8 * 2]);
>>      LOCAL_ALIGNED_16(int16_t, subcoef1, [8 * 8 * 2]);
>>      H264DSPContext h;
>> -    int bit_depth, sz, align, dc;
>> +    int bit_depth, sz, align, dc, i;
>>      declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *dst, int16_t *block, int stride);
>>
>> -    for (bit_depth = 8; bit_depth <= 10; bit_depth++) {
>> +    for (i = 0; i < 5; i++) {
>> +        bit_depth = depths[i];
>
> Perhaps this should use FF_ARRAY_ELEMS(depths) rather than a hard-coded "5"?

Thanks for the suggestion, pushed with this change.

-- 
jd
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".