From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] movenc: Add an option for hiding fragments at the end
Date: Fri, 31 May 2024 14:18:19 +0200
Message-ID: <290fd939-b56b-40ff-9ca6-beed19db3757@rothenpieler.org> (raw)
In-Reply-To: <20240531085358.45478-1-martin@martin.st>
On 31/05/2024 10:53, Martin Storsjö wrote:
> This allows ending up with a normal, non-fragmented file when
> the file is finished, while keeping the file readable if writing
> is aborted abruptly at any point. (Normally when writing a
> mov/mp4 file, the unfinished file is completely useless unless it
> is finished properly.)
>
> This results in a file where the mdat atom contains (and hides)
> all the moof atoms that were part of the fragmented file structure
> initially.
> ---
> This is, incidentally, how Apple devices do (or at least did, at some
> point) their writing of files when recording, at least with some
> of their userspace APIs.
> ---
> doc/muxers.texi | 7 +++++
> libavformat/movenc.c | 59 ++++++++++++++++++++++++++++++++---
> libavformat/movenc.h | 4 ++-
> libavformat/version.h | 4 +--
> tests/fate/lavf-container.mak | 3 +-
> tests/ref/lavf/mov_hide_frag | 3 ++
> 6 files changed, 71 insertions(+), 9 deletions(-)
> create mode 100644 tests/ref/lavf/mov_hide_frag
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index 6340c8e54d..e313b5e631 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -569,6 +569,13 @@ experimental, may be renamed or changed, do not use from scripts.
>
> @item write_gama
> write deprecated gama atom
> +
> +@item hide_fragments
> +After writing a fragmented file, convert it to a regular, non-fragmented
> +file at the end. This keeps the file readable while it is being
> +written, and makes it recoverable if the process of writing the file
> +gets aborted uncleanly, while still producing an easily seekable
> +and widely compatible non-fragmented file in the end.
> @end table
I somehow feel like calling the option like this would not help an
"unsuspecting user" to find it, cause it's not immediately obvious that
it solves the issue it does.
Though I don't immediately have a better idea either. Something like
"safe_recording"? "crash_resilience"?
Can't say I'm a fan of those either.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-31 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 8:53 Martin Storsjö
2024-05-31 12:18 ` Timo Rothenpieler [this message]
2024-05-31 12:38 ` Martin Storsjö
2024-06-01 12:38 ` Dennis Sädtler via ffmpeg-devel
2024-06-02 19:36 ` Martin Storsjö
2024-06-02 20:45 ` Dennis Sädtler via ffmpeg-devel
2024-06-03 7:51 ` Martin Storsjö
2024-06-03 9:38 ` Dennis Sädtler via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290fd939-b56b-40ff-9ca6-beed19db3757@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git