Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add pad_cuda filter
Date: Fri, 4 Jul 2025 00:48:49 +0200
Message-ID: <29007532-2b55-4018-9f0b-c0f6b70161a5@rothenpieler.org> (raw)
In-Reply-To: <CAHPA9KRE3pJyJHzYy+_JqR6ynSkFEOrkuVJ7QULpE5xr7yhFxg@mail.gmail.com>

On 03.07.2025 23:05, Jorge Estrada wrote:
> ping

Completely forgot about this, sorry.

Patch does not compile, cause vector_types.h does not exist.
If I remove it, it can't find uchar2, which is purely a CUDA side type.

Isn't that whole construct around there entirely unneeded?
You can always just pass &s->parsed_color[plane] in place of p_fill_val, 
and it'll always be correct.


That re-invented RGB to YUV conversion is also entirely unneccesary.
There's macros for that in colorspace.h


Also, there's A LOT of use of mixed declarations and code, though I 
think that is fine nowadays, and the warnings about it have since been 
disabled.
So it's probably fine to leave it as-is.


There's also a bit of potential to further generalize and micro-optimize 
the CUDA kernel and calling it.
Primarily moving the one extra division out of the kernel, and doing it 
in advance for it.
(There's also a tiny superfluous section that sets hsub/vsub to the same 
value again if it's NV12, which I removed).
See the second commit for what I mean.

I've pushed the necessary fixes and further optimization and 
generalization to GitHub:
https://github.com/BtbN/FFmpeg
https://github.com/BtbN/FFmpeg/commit/45e4baa3d82c6e6fffbd6c1ac8389e305a3f9137
https://github.com/BtbN/FFmpeg/commit/14cf522b51e66e65ca60e0447348f2bfbcf631ea


Works fine for me like that, if you're fine with those as well, I'll 
squash them into the main commit and merge it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-07-03 22:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 23:39 Jorge Estrada
2025-06-17 21:20 ` Timo Rothenpieler
2025-06-20  2:43   ` Jorge Estrada
2025-07-03 21:05     ` Jorge Estrada
2025-07-03 22:48       ` Timo Rothenpieler [this message]
2025-07-03 23:02         ` Jorge Estrada
2025-07-03 23:33           ` Timo Rothenpieler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29007532-2b55-4018-9f0b-c0f6b70161a5@rothenpieler.org \
    --to=timo@rothenpieler.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git