From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0937B40B8B for ; Tue, 28 Dec 2021 04:39:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D42F868AF42; Tue, 28 Dec 2021 06:39:10 +0200 (EET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B84D668AE86 for ; Tue, 28 Dec 2021 06:39:03 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640666348; x=1672202348; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=iPjWWr3aJttiNoX19Gub5o8aUPi++RePOwJ1VoG0N84=; b=YND6PKiKM8hBSHNal5URjwE4TkZLOCFV96yTW8zYLObMljm/lxR+Fai2 aa8obekY156l7BWgIRTYCDsYs46HQpnN+MPnvKYj40IfExpZqMB86P3o9 swYBNVZ5gdAH0Eg8Bc+eiYY1jWsi0zZaB9Bi8pz0dbyLsydehxGJ/VWCU vhDY1H91r8NO6bOYKUEKWT9GzdfwKXIX+dWx4WD7eGpX3iYYzvJBHOaAX uhnbs2lu9jJXT08M4Evbbg/3XoJanzXrtK1YZZLGzTai2SAS5LROie7KI C+eWwYuMIl0Uy+ZBOoODsIzewJI6BP7KjADr1vMDezdhYVNBaFjoHjwHn g==; X-IronPort-AV: E=McAfee;i="6200,9189,10210"; a="302064036" X-IronPort-AV: E=Sophos;i="5.88,241,1635231600"; d="scan'208";a="302064036" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2021 20:39:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,241,1635231600"; d="scan'208";a="665922898" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 27 Dec 2021 20:39:00 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 27 Dec 2021 20:38:59 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 27 Dec 2021 20:38:59 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 27 Dec 2021 20:38:59 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 27 Dec 2021 20:38:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wz+pQlU7ieXpQGlmT9158YBwDMInf4aEPLNDoaDgzQ90/QEFpZEI795j57syCqRx+WKCBoFSnXvh3iN6+d74BIGOl6iLzyWVkW3wD9N0JnLHMuFpBxOLB14YI/k4cufUbJgpJawtIzI1BV2Hmif+XuEeKVQC8qdc1gLvftxoXDyToe7tdoeYQT57elpa3Hf+LZbxFrUYG8yITdeSWtlLoOaGXsMV0HaQlwa2xOQBgsc5V+5fXPHcoWIUgZWFHR/Ko85dkT3mFoETay0OyHQBdh3sb1vvy1nhMtzuvCIyyPsEhQMPNKlpjohi1UwOmbIJVnsCCmTML7vEvFAUPKG/jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iPjWWr3aJttiNoX19Gub5o8aUPi++RePOwJ1VoG0N84=; b=h4YmWhxM1fWc0ffle+ZbrySvi5mQ+K48SmJOJePPWGznG6HWjHHqHYhD32zZcRYlpvhNgQqNMud7NcpEuJuJ5sipxZTAxpVKQWvJUrdNGuaGmRxgEQUStStblbunIeefpH4BmUC9ktADtSqKyJorI+qCr3BdlW0wz+n2u45a3FJwbl8nRFfj7H+2mCTtYh8TDrfk1nBcVA3kjDjd1Ci2H2u+CKzJoNUHj7aVvi3ruV3EgwskflqjKbQwPaYTWmjPgU0E3B4fsd8n9To73+BluFEe+NAhNzQuXCnszQgnsRMWN4jOH2mr7N6yojRchuQmonnBAqJyI43I0zV95oi9hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB4148.namprd11.prod.outlook.com (2603:10b6:405:81::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Tue, 28 Dec 2021 04:38:55 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4823.023; Tue, 28 Dec 2021 04:38:55 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [FFmpeg-cvslog] libavutil/hwcontext_vaapi: Add a new nv12 format map to support vulkan frame Thread-Index: AQHX+1OSk4RVkIC+1UyFJLMqlfjhNqxHR1wAgAALnoA= Date: Tue, 28 Dec 2021 04:38:55 +0000 Message-ID: <2900117a62478572b220fa81d0e82245fc6a6c31.camel@intel.com> References: <20211210160501.929C341050D@natalya.videolan.org> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37d65bf9-7c8f-4117-b18c-08d9c9bbf4dd x-ms-traffictypediagnostic: BN6PR11MB4148:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 14l9ndn7ZwhEBUf3Q+RgFLu2i9wgu0mUupTxouMUsa6pK10IA908+mbek5PQmSrCnErgDTVQVNsqvS06Eh3xkTs/QhdupKS7Tyr2RoNmF9OY2XUeePhg9efvwJz/HH//A8Zgs4bUi/Xsriqq2ME1qE/DXI1Ri1m8shguUI72/kLvEB+O/91cSiL+18PJtZaz4MLY/klEEY+8GrYZcQJOnP1L/ECDz06zndJCahKpGB9ICNF73bQOw+RAKMPGtYCopJCrxKswrXXCCmukZxiU78CYlZsQmqI03mU/zZ2qGKw5qujWUnoBMjyi9biAECqvzM0KfUk8HOD/bTPvgLLFMxaPliE80sZgoiI7r75J6aJcAl7hh9lRiRb95Ra+bsAfx6pMTzneXRu5ZO8FfJKtzUcRjkS44tFDg1aL8OCCAvTTFIm2wqBdb9OUNxp/daM0sp1h04wWdRDXykbCVRrKPlq3CdmRLaUumrH2jnYiulNrz4eod3TT9rIhf1AZpMFXvAqStvmwH43QZCofZk33SpR/oxrc2oKhy8qcrPaU7SuxJ7SCl/A2AKGlt5uuSAHxfZgqZizPNd4qbtYIGcQ9Wpw0J4CzOlvpP9MsKV4avFW47P+QmkSehazblk5zO6qyFiuXpydRkNZqsE4DTlKCc40/PAD8OMldQ4kTnvNP5eQTWf/38nmnXkjzGEOnG/3oIeIM4xoVXILaHznXMViyyQCA5bdF5xN+OLjDPGJbiuPexbDHEe6gb1jDLqgNTqNHnK6fi9efRn7gN6KWPidYcLfdTMDG0Xa5vZ0IBdpQmcYkuGgyOVGOstuiRZCgS9wT x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4001150100001)(38070700005)(36756003)(2906002)(186003)(508600001)(26005)(5660300002)(64756008)(66476007)(316002)(71200400001)(76116006)(83380400001)(2616005)(91956017)(66556008)(66446008)(6486002)(6506007)(966005)(6512007)(122000001)(38100700002)(8936002)(86362001)(6916009)(66946007)(53546011)(82960400001)(8676002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?S0gwOUtmSFZ3TktORU41dGhWN0IrbTR1S3pGQlQvbVpHUEc5Mm1JajY1M25q?= =?utf-8?B?QU90d1RmaC8xbDlWSEphSlJsbVFRMG9YNmpzM0xGOC9TUEY2WWRFNDdpQmlF?= =?utf-8?B?SUQ4Mm9FMjgyYVhYcXdFSGQ5Z1RBN2UrdFUrdkIyeUp4U3l1RlZWYVhhRUxH?= =?utf-8?B?blVCQkJESVhrODhtUWoyeHdZMUdjZG95SHorSHBIMlNZUEQvWWQ2MkJLR2hw?= =?utf-8?B?VDdybEhxdVdGWjBRWnJPZ1Z1R29wYWJXRExSdXJ6Rmpad3h4RUs0MG5BNE5D?= =?utf-8?B?S2EyQy8xYjN6SXQ3TXAxekROQ2VSdkRIVHZ0Z2U0ZlJGYnhPbFNuT2ZGcGxC?= =?utf-8?B?Q2VyN0ZINUpOVFZPSGJEd2pGbExUcmpuUFVLWUUxYmJYMm1ad1ZBRDBYdEZq?= =?utf-8?B?Uk9abXR4aE55bVFOaDRvOTJrS2J3cjhsdElYZTBGQUphWnAxcksvRjN4SVBn?= =?utf-8?B?UittZXU2bUhVKzdGRHRnOGZBb09wUnRtOXZGMTJwcndxV24xenl6WjNlbldJ?= =?utf-8?B?ejFtQ3JDbWV1cWpZbFhKWmJzL1ZGUzF3V3BGWi9JY2pXQ1ZoaWxBc0dBdmQ0?= =?utf-8?B?QSs1L1NZTVdZMTJpWmJ4MU5XRWd6ME9KT202QzZnR2ttRzhNK1FwKzI1VmxK?= =?utf-8?B?VEc5NnZlYzVUdHhMZllwc2dYMkdSamx3Vi9tRVFFQXZQSm1NSDJ5MGN1eml2?= =?utf-8?B?Q0FzV09HNko5UkxzMkJMSzNsd1VWRmZDOXNsamhiM3hxenFmOXQwenlxb1ha?= =?utf-8?B?M2wzckw1YmgrQTgzOE56OHI4ekFJaXFlUXRyQk5IUmhZcUdmRmFIQVhodlZi?= =?utf-8?B?dHJTV01KNUFxT0EwVW1GWDRLNzFkWm92Rkl0SW1uTXVLWVBpT0NmdmVRNDdH?= =?utf-8?B?Nm5zUWlSTzRBcEx4QWNWNFBzNUlwcnIzWWp5OTlka0xxWVlFZGlGUTB4L1A1?= =?utf-8?B?V1J6elZ5dWM5MDY0czhoUVVwa0ZCdWpPRjJiNzdSSjBGZEZsZXRKMHRjZVd0?= =?utf-8?B?d042QzhkOFNWYktuMy85NHlhL2V4Rmt0bENPUjl3ak0yYk5pTDdwSUhWSGgz?= =?utf-8?B?bjFOMUpldi9FSXBZY3I5YWtNZlhCVC9vK3FlOEt1Vzhla2x1TnpLbnVLZjV4?= =?utf-8?B?Wis5ckpJQTJqdTIxdTFsMkQrRlFQWnJJZHp5YVFOQ1VBN1NKdmc3cDE2NldX?= =?utf-8?B?NDdEd1pYUU5CcVpkSjJHU2JvWmtPd0RhOUhaRTV5VHdYV05sZ0JkNlkwajZy?= =?utf-8?B?V0ZKU2FOdXh4clVweGhydjRDNWJHTmVrL0NFMFlRRC9ORVRJeHZBeVhNZDA1?= =?utf-8?B?OTYyTndBY21aanhOck9ubXMyYndGN0hDV2lJS1lmV1g0SjdHU1plVXV4aTlv?= =?utf-8?B?bUFKS1d2c251azBZUUNUUnhsYWJVUXBlTTZldEVqUFVkNnVKbFpsUDVtR2Qx?= =?utf-8?B?eGE1bnZ0c3RhRGt4Z3hlS0ppZjdrakdpWHpCVkN5RXJubWdCbk9yMjVaaTQ3?= =?utf-8?B?dEtvQTI0KzhWZUlUZjhxQ1lvSm9PM3JuaUk3dzBxMDNXQ04ra1BWZVdjbVJ6?= =?utf-8?B?Y0xJRjhmYVp0TlFsRHR1RUV0UUlZZUNYdmpkSk1YZjZkOUhXa0dDWDZkTUNv?= =?utf-8?B?Y2gwcTU4aVlIbjFwcUpkT2xhVXNHNjJMSEQxQzVkZ05QcW5Ia0dZbmNlK3lv?= =?utf-8?B?eTVldFlKbTV1czR0M0RSZWNJNVZEMlE0R0diL3VDUFdtQzdzaEdITkc0RW5T?= =?utf-8?B?VHM1dXRxSnNWWjdGUUM4NDROUlZISWRoWmwxQlN0b1lsUHFXV0RZTVp0ZHA3?= =?utf-8?B?b0hYZzdoNThyR0xQMWxEYVRudy9MQ1lLb2JrbThlbU8zcDB1RU9uM2JORnNJ?= =?utf-8?B?SFpMaDZWSWxCejJvc3BFa2w2YTVyTThjT0grLzJiajNjT1BCWXVldDZvcHZI?= =?utf-8?B?WXdiNHRVdEYvVjl0RTlNUVhwazZuekt2eXJWRlk3c1I3TkxYakxRN3dYd1d3?= =?utf-8?B?VlJzS2ZlK3QwS21IK21jWWwvUks1c0RIcmlyVGtiNSt5RlhKaGM0c2VDTjd0?= =?utf-8?B?UnJreFhVcU5NYThNNG5NUFlOUGhsWXpDRmo3WXNpcFFnNTRBWFhjUnExenBT?= =?utf-8?B?ZlZXRVRVeHA3cVc4QURYSDJwKzAva1UzUW9ObEVHc1FKcnBrYjNodkwwZFlL?= =?utf-8?Q?eP2j99eg7SpXOncxepl3lWQ=3D?= Content-ID: <75C8A3A70D3944449B110B4C2E7A06FD@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37d65bf9-7c8f-4117-b18c-08d9c9bbf4dd X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2021 04:38:55.2779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YiL2uN2136E/vfT2Gb1XYKh5kCgbtEplc+UJGaFymR3QYcKPVYJksFV4zEkaPTeVRz9vB/p2FKm6nm6TpMHOFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4148 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] libavutil/hwcontext_vaapi: Add a new nv12 format map to support vulkan frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2021-12-28 at 03:57 +0000, Chen, Wenbin wrote: > > On 10/12/2021 16:05, Wenbin Chen wrote: > > > ffmpeg | branch: master | Wenbin Chen | Tue > > > > Dec 7 17:05:50 2021 +0800| [f3c9847c2754b7a43eb721c95e356a53085c2491] > > > committer: Lynne > > > > > > libavutil/hwcontext_vaapi: Add a new nv12 format map to support vulkan > > > > frame > > > > > > Vulkan will map nv12 to R8 and GR88, so add this map to vaapi to support > > > vulkan frame. > > > > > > Signed-off-by: Wenbin Chen > > > > > > > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f3c9847c2754b7a > > 43eb721c95e356a53085c2491 > > > --- > > > > > > libavutil/hwcontext_vaapi.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > > > index 75acc851d6..994b744e4d 100644 > > > --- a/libavutil/hwcontext_vaapi.c > > > +++ b/libavutil/hwcontext_vaapi.c > > > @@ -992,6 +992,7 @@ static const struct { > > > } vaapi_drm_format_map[] = { > > > #ifdef DRM_FORMAT_R8 > > > DRM_MAP(NV12, 2, DRM_FORMAT_R8, DRM_FORMAT_RG88), > > > + DRM_MAP(NV12, 2, DRM_FORMAT_R8, DRM_FORMAT_GR88), > > > #endif > > > DRM_MAP(NV12, 1, DRM_FORMAT_NV12), > > > #if defined(VA_FOURCC_P010) && defined(DRM_FORMAT_R16) > > > > This looks very shady. Shouldn't one or the other of these be NV21, with > > the > > second plane VU rather than UV? > > > > - Mark > > I add this because I see vulkan map RG88 and GR88 to the same format. > ``` > { DRM_FORMAT_GR88, VK_FORMAT_R8G8_UNORM }, > { DRM_FORMAT_RG88, VK_FORMAT_R8G8_UNORM }, > ``` > I thinks you are right. One of them should be NV21. I should switch the > position > Of GR88 and RG88 in this map table so that VK_FORMAT_R8G8_UNORM can be > mapped to DRM_FORMAT_RG88 rather than DRM_FORMAT_GR88. Changing the mapping will have other issues, e.g. another hw context supports nv21. I think the root cause is nv12 and nv21 have the same VkFormat in vk_pixfmt_map[]. { AV_PIX_FMT_NV12, { VK_FORMAT_R8_UNORM, VK_FORMAT_R8G8_UNORM }}, { AV_PIX_FMT_NV21, { VK_FORMAT_R8_UNORM, VK_FORMAT_R8G8_UNORM }}, So the pixel format should be taken into account when mapping drm format and vulkan format Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".