From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7C72A44C90 for ; Mon, 14 Nov 2022 15:23:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 669BE68BE4B; Mon, 14 Nov 2022 17:23:52 +0200 (EET) Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F28BB68BD46 for ; Mon, 14 Nov 2022 17:23:45 +0200 (EET) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-12c8312131fso12827567fac.4 for ; Mon, 14 Nov 2022 07:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/3XAHAgtiKfvEJ723Ntd7HkcboiinrvF7/GQYQS+69g=; b=XlmMsXfclTwNhAktbU4DMNnHA5Z+Cx9QeuX/Mo7afw0egW7oMbwLXkahYbUaf3EZ1p rWGRFPLZpwsPO1BA+mbbT7cU3V2Bln79E4+FvDMpyLhXFNrPGac9+IbPeg1qaHkPVqAh U5XUWlDbKI5y0VtcusWVtuWRUwUbrqbCOvZBSBhngHtkONuAxnP+UseuFGL6tm15z2ql ql55WzEcRYs84Ys+23r+5cnKYudgtuRTGpWCJg5LT/1py2iVYQBc5DikbrQSo881xZq/ uTsba9Gr6Mshv2QE72Jf2glR20vF5iVD6Qq28xjzZpCVuoOuRBTbEUuo2hESz9VmEd3d 4J1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/3XAHAgtiKfvEJ723Ntd7HkcboiinrvF7/GQYQS+69g=; b=u4PN+xCLAVw+3q/6FdjCDxOABMlnnIryW99nmD7tn4uZj0KLX0PZY5Flcj8V+GIWdx W8zV4BC1Dp8xhIc2ip68Nb4QcqKjV1BTbdCQJMJWDiqB3QrdgQ3ygeMDjDZQXCcHFv+y +NI9Wa4en1HfoRn+cjVlAZ2Rr6npEG0hIHdHSgqTqw8hlfRXNxwVPjNWBbztJu/boRJc NhN0OQce6GWyz7J5ChILN07eHE1Gu09CAeWoq7DzQbVNDEHoYl94u1tzih7mlEkra9yK SKTdiaayDB5wX+UVKrCYhkIgBiut79brftRtYvK89k4SAvMxWPUD/6SLdivezoeZztA3 evVw== X-Gm-Message-State: ANoB5plKxYj5Y46ZhSaFvBmBx9HpS2m+GE0BP2rPCEbqPvB2bH+seYbp xtV+VEF5xmVK8desQeg7t6g97Hii+BU= X-Google-Smtp-Source: AA0mqf7xagn6lfmYH/wd+Lw90/7QWfnjpJY1QcDRePu1XmVpBznx3LDAdm/gUFt0nMKUaXRi4P+4ew== X-Received: by 2002:a05:6870:4945:b0:136:8a4d:f10e with SMTP id fl5-20020a056870494500b001368a4df10emr6822350oab.243.1668439424282; Mon, 14 Nov 2022 07:23:44 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id kw12-20020a056870ac0c00b0013c8ae74a14sm5030323oab.42.2022.11.14.07.23.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 07:23:43 -0800 (PST) Message-ID: <28ff3c33-a7c4-d7a3-eaa0-0bf202d3aab5@gmail.com> Date: Mon, 14 Nov 2022 12:24:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221114143551.9740-1-bin.wang@intel.com> From: James Almer In-Reply-To: <20221114143551.9740-1-bin.wang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH v1] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/14/2022 11:35 AM, bin.wang-at-intel.com@ffmpeg.org wrote: > From: "Wang, Bin" > > Signed-off-by: Wang, Bin > --- > libavfilter/x86/vf_convolution.asm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm > index c912d56752..a6be95690b 100644 > --- a/libavfilter/x86/vf_convolution.asm > +++ b/libavfilter/x86/vf_convolution.asm > @@ -189,8 +189,8 @@ cglobal filter_sobel, 4, 15, 7, dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, > cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x > %endif > %if WIN64 > - SWAP xmm0, xmm2 > - SWAP xmm1, xmm3 > + VBROADCASTSS m0, xmm2 > + VBROADCASTSS m1, xmm3 The other two VBROADCASTSS below should be used on UNIX64 only. Otherwise they will overwrite m0 and m1 on WIN64. > mov r2q, matrixmp > mov r3q, ptrmp > DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x > @@ -281,7 +281,7 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, > fmaddss xmm4, xmm5, xmm5, xmm4 > > sqrtps xmm4, xmm4 > - fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias > + fmaddss xmm4, xmm4, xm0, xm1 ;sum = sum * rdiv + bias > cvttps2dq xmm4, xmm4 ; trunc to integer > packssdw xmm4, xmm4 > packuswb xmm4, xmm4 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".