From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 98AF34578F for ; Tue, 21 Feb 2023 08:13:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B40068C0BF; Tue, 21 Feb 2023 10:13:13 +0200 (EET) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AEC3A68BFD8 for ; Tue, 21 Feb 2023 10:13:06 +0200 (EET) Received: by mail-il1-f174.google.com with SMTP id z3so1433213ilm.0 for ; Tue, 21 Feb 2023 00:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rcombs.me; s=google; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=1Tx8ivPAC7BS55UvctQPlRPrn6To4tEFjr64Ff0Trlc=; b=Y/nggleNPVMY2Ga84nqA0U4DCiwwlG7mrBWnjr17WFOI5hGssOtPjJOY1pIC7y1CKy 4bgcqTo6jk5aPmeLIvn9UvXsd69hs7YrG9kfn7k79tVYyxPuxBaifhreM8SHd5S7c+Yv ATQM/FoXUNs71y8yC0/Rc1KJRci+IEQO/HvhreSOJEUmeK3T5NvFu8XdJpr0PP8TQcgc ywxrRzyuS2tmKHm0/5i1/uQxH6TheWyuxEvKbX2D1OrbcbJBjK0IDrLI9a8DWuF+j8oU g3KktidXmGIGF75En2Uesj0WOB8yOnIFucMa8PqlPk4JWdxZ/PotsilUn6WfooLCvBOD dRYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Tx8ivPAC7BS55UvctQPlRPrn6To4tEFjr64Ff0Trlc=; b=EE8Ank2fb9TK/jnyXyVG2jqkCRn2UWGOTz1k/3LwR8kJ/6+gOOfVb2rBgEBBossykp kfh/iSDA8j9QEjylUZGcTD/hcScU+wy18PQfMBi5UTi9ZmpL2HIVMkP/lCrlb4rcYNz8 IM+TtazAjNOQZ4A9W25zjQfwg25SBlg0jS1Qtu6mVtKu+Ni29MeM/GiiCBVxRILCB/3E N6OGNAOLre53OMWsqghpF1mN3OGvcgXceKFtyewxd86Y5xU2lAOw3m3pA/t9dNGgAa5G lLBr8adt6REIRp+fu6kLN52+2KvfeEOMHqP//731hudPX28VefAgh7WoFk2fPlyAKsH/ ynwA== X-Gm-Message-State: AO0yUKVMbSNqPE2EofxcUgdNe31KQ3lLvZeaiwDCKPMo+gBraIU/Ovvx zZBS51jL+Z+z2/LQE3quoYaLudjZQci5qzrHpQ== X-Google-Smtp-Source: AK7set+qf709IA5H0DpIkEKW6sDpEmyGDRkQuwrE6yN5mh5B6zmtox/j4UO6sBr1XZ6k15thXSD8Aw== X-Received: by 2002:a05:6e02:219c:b0:304:d0b7:e362 with SMTP id j28-20020a056e02219c00b00304d0b7e362mr4940115ila.5.1676967185079; Tue, 21 Feb 2023 00:13:05 -0800 (PST) Received: from smtpclient.apple ([2601:243:2000:5ac:5002:d39e:8443:5cd2]) by smtp.gmail.com with ESMTPSA id e7-20020a056638020700b003c4ec576030sm1064643jaq.4.2023.02.21.00.13.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Feb 2023 00:13:04 -0800 (PST) From: Ridley Combs Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Date: Tue, 21 Feb 2023 02:12:53 -0600 References: <20230221002516.25784-1-rcombs@rcombs.me> <20230221002516.25784-2-rcombs@rcombs.me> To: ffmpeg-devel In-Reply-To: Message-Id: <286B731B-06FC-43E4-9924-9C925EAA49C3@rcombs.me> X-Mailer: Apple Mail (2.3731.400.51.1.1) Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/assenc: set AV_CODEC_CAP_SINGLE_SUB_RECT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Feb 21, 2023, at 01:48, Nicolas George wrote: > > rcombs (12023-02-20): >> This already gave garbled output when multiple rects were present, >> so this is simply documenting an existing requirement. >> --- >> libavcodec/assenc.c | 2 ++ >> 1 file changed, 2 insertions(+) > > NAK: the code has provisions for multiple rectangles, if you enforce a > single rectangle you need to remove the code that is now useless. Fair enough, if we're fine with breaking the existing case further. Should I simply drop rectangles after a first, or return an error? > > But I do not think pushing the issue onto the applications is a good way > to fix the problem. Or even pushing the issue onto the framework, since > the framework does not know the specifics. Better fix the code in ASS > that handles multiple rectangles than inventing yet another annoying > flag. A single frame can be encoded into multiple packets, so that > should not be hard. This is only true for audio/video encoders; subtitle encoders still use a different API, which does not have M:N support. There's some long-ongoing work to change that, but for now, this seems like the only way to deal with this case before that API overhaul. > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".