From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C797342822 for ; Sun, 1 May 2022 21:06:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DC56068B28B; Mon, 2 May 2022 00:06:51 +0300 (EEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C69DF68B151 for ; Mon, 2 May 2022 00:06:44 +0300 (EEST) Received: by mail-wm1-f47.google.com with SMTP id o12-20020a1c4d0c000000b00393fbe2973dso8925927wmh.2 for ; Sun, 01 May 2022 14:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:references :content-language:in-reply-to:content-transfer-encoding; bh=5z/AIkZW4IkpjBEFVg1g4COAwEmNBOsK1SOyXeSTxmE=; b=W/WfpCBMiBmuNJJlYd03o3r16wI45N/yZhdJOYe1fglh8LQ5CwdX4XLVuqjU1jfSwr 3sOzC6JM2/LnkyvaEDy0yDj4tcIhUJviEEInR8u85G46BL0NybEo33FJu8cUnB/RV3/P UxHkR1dLsRUw9kknbQ7NmFBjONIBYap6Sh+ZP2fNPyFPKR5I/mlAq1H2LO7d9Xp+uGpn 67KRAaoSW++316tF+/xbGWt4ELGp5Fm7EEVv01zSEIEROFdhNmd8Yo7bh2UyIw46vYe6 AvofIpvpXir4KH5vpTh/+mFK6NSMnhzA+SMuoKu9OMYepGCCXY9oahJqZEAkxv+Edd6i fD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:references:content-language:in-reply-to :content-transfer-encoding; bh=5z/AIkZW4IkpjBEFVg1g4COAwEmNBOsK1SOyXeSTxmE=; b=bGHKy7XVFGXEfXh3RTh+GO8k1O7PyuB2KclUeT0ZLtn3kQdNU5oNMIdp5rS7ucs+u0 itVvMSV79Ki8hksKViszwIar3EH8GpWYScFYxm73DaYFVKwntWrdVtWWsCg9D1aUS/+T ox3l8ToGsVEm5kmhHsvjAluBcFs8H+NE88G2i8/JbEfNnRGvho7V8nOCQXbd7+K7Y8Kd slKyO8Ml22v6Ixt0lNAWm1dqX4Y/6e27g91EwPwTsFz+MPora8/SOF6lO76icAag0ngr Gjy0v3CT2PmTxMGnfwDtQhxIYcnrBo3yPTnn/SLYeGCt0uGs/NArM9cc6N/WxrLoPVYr F/fA== X-Gm-Message-State: AOAM533vrT0klOWdwfq067MSgf3/mZAiroxnc9GN/orr6n6qNcZBL0GG n/ZPmCzn5TkodDAoF14potuEzqxjk4iwiDUC X-Google-Smtp-Source: ABdhPJz9gkCbhpPI3u+BVeNUS9f7Ghm9jV7sI5y8Eclcbjy8W8x1OY7g0xySGZrEydFAysdPdiXpbw== X-Received: by 2002:a05:600c:190b:b0:392:95b8:5b18 with SMTP id j11-20020a05600c190b00b0039295b85b18mr12450922wmq.152.1651439204010; Sun, 01 May 2022 14:06:44 -0700 (PDT) Received: from [192.168.0.14] (cpc91222-cmbg18-2-0-cust46.5-4.cable.virginm.net. [81.106.30.47]) by smtp.gmail.com with ESMTPSA id u21-20020a7bc055000000b003942a244f46sm4792728wmc.31.2022.05.01.14.06.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 May 2022 14:06:43 -0700 (PDT) Message-ID: <28433b82-2bee-a268-16c0-7cb2a260ada8@jkqxz.net> Date: Sun, 1 May 2022 22:06:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Mark Thompson To: ffmpeg-devel@ffmpeg.org References: <20220424101409.95486-1-zane@zanevaniperen.com> <20220424101409.95486-6-zane@zanevaniperen.com> <02a9b3be-e7a0-6283-188a-6033fde862b5@jkqxz.net> <111defba-5c26-ddf6-8c50-406bc18cccd2@jkqxz.net> Content-Language: en-US In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 5/7] avcodec/cbs_sei: refactor to use avutil/uuid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 30/04/2022 21:53, Pierre-Anthony Lemieux wrote: > On Sat, Apr 30, 2022 at 12:26 PM Mark Thompson wrote: >> >> On 30/04/2022 18:53, Pierre-Anthony Lemieux wrote: >>> On Sat, Apr 30, 2022 at 10:31 AM Mark Thompson wrote: >>>> >>>> On 24/04/2022 11:14, Zane van Iperen wrote: >>>>> From: Pierre-Anthony Lemieux >>>>> >>>>> --- >>>>> libavcodec/cbs_sei.h | 3 ++- >>>>> libavcodec/vaapi_encode_h264.c | 8 ++++---- >>>>> 2 files changed, 6 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/libavcodec/cbs_sei.h b/libavcodec/cbs_sei.h >>>>> index c7a7a95be0..67c6e6cbbd 100644 >>>>> --- a/libavcodec/cbs_sei.h >>>>> +++ b/libavcodec/cbs_sei.h >>>>> @@ -23,6 +23,7 @@ >>>>> #include >>>>> >>>>> #include "libavutil/buffer.h" >>>>> +#include "libavutil/uuid.h" >>>>> >>>>> #include "cbs.h" >>>>> #include "sei.h" >>>>> @@ -41,7 +42,7 @@ typedef struct SEIRawUserDataRegistered { >>>>> } SEIRawUserDataRegistered; >>>>> >>>>> typedef struct SEIRawUserDataUnregistered { >>>>> - uint8_t uuid_iso_iec_11578[16]; >>>>> + AVUUID uuid_iso_iec_11578; >>>>> uint8_t *data; >>>>> AVBufferRef *data_ref; >>>>> size_t data_length; >>>> >>>> This feels like a step backwards? The syntax template files are explicitly relying on this being uint8_t[16], so giving it a different name is confusing. >>> >>> What/where are the syntax template files? >> >> >> >> (It's included twice by cbs_h2645.c for read/write with different macro setups.) > > Ok. Thanks. Are you concerned that the following line assumes that > uuid_iso_iec_11578 is uint8_t[16] instead of being the opaque AVUUID? > > us(8, uuid_iso_iec_11578[i], 0x00, 0xff, 1, i); Yes. > Did I get this right? If so, couple of options come to mind: > > (a) revert the change > (b) define a macro to access individual bytes of AVUUID, thereby > keeping AVUUID opaque > (c) not handle AVUUID as opaque, but instead always as uint8_t[16] > > Maybe additional options exist. > > I do not have a definitive opinion. Some folks expressed strong > interest in having a consistent scheme for manipulating UUIDs. I think for now the simplest option is just not to change the CBS header, which is completely fine with your current patch set. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".