From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62C4742293 for ; Sun, 16 Jan 2022 22:52:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D18DF68AE77; Mon, 17 Jan 2022 00:52:03 +0200 (EET) Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 858AE680814 for ; Mon, 17 Jan 2022 00:51:56 +0200 (EET) Received: by mail-oi1-f176.google.com with SMTP id t9so21000614oie.12 for ; Sun, 16 Jan 2022 14:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=yA6WF7xpapXlzhfRIhheaJ2ygZ8IccRJWg+Q3nBv5II=; b=pX/+7yUqCHTN0fqQ6hw0guNrMhB3lZZiDIc9zTYoxKrxdLH7fnlq7lA+vGeppM2a0a sxSU6+TghPC4o7wvnN16hVpDdBw9Dv/dIIy+Rlx6fIZgeuRPmv9R8HuJD0/updq+oe3D jjUeZnmfnqAU3qAT2PxX9yw6lKztbMrnBkfhiY9mZ7xVBVwLZORRerY3EKU7sLSI+iZk 5fR9n+CCA1rQ1lZ4cP9pN9M8V6QUl1ai7VKDmUWI/CVrN8RK5SjF8OFMIxlWRdVAvTJR eTp4Md9TRdYLn1qbpbHypao65IcbrpgyrXAuMyoG/MVo5jMm/5yH2htrvwd37n9lb0sT q/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=yA6WF7xpapXlzhfRIhheaJ2ygZ8IccRJWg+Q3nBv5II=; b=QZxcXsh0E7uWZuitv/m0A6tx/4EfjYYg9LF/eCsc4EomCnKMM5ME1oy7oqyt6aXa6J VvFuy25tHwZX4GTOdFd384oBDAroEgkZi5OkKxApgnBI6bOfmkfVW863MWanga58rIHy 0+0q9QeZ1X5wgaEqB1qUBpsQHztcDKCsTVif6JdzOmyTYSXdb4zwWj2dtquGeUdxDkaS sUM8WoLy5zwOZLKSJTj3JKbHcj+wyq/h/1czYlz/Jhbb2FNRwmDo6yTxpYXsIR6qGjHH ++dvqFmLglyU45Ulwp0EnzYoLbJUAwdPtY6OFvvJBE4/iB2boV6A99yMEnwix/k9Sqfm nrjQ== X-Gm-Message-State: AOAM533cS+2tha3lI9uliCXBiPLj8quFm8SyXB2aGM5SEOHB6owrA8Q+ TVhtFIwlgqjSE182nJPBKpfw2ZLGpBE= X-Google-Smtp-Source: ABdhPJyzqplOdRR7N8J+LvIWWXugdJeJVhgtHGsLlrLf0S1jykMXmo4U/LzzdtgiVuDXDH49Yepb6A== X-Received: by 2002:a05:6808:1805:: with SMTP id bh5mr18273178oib.105.1642373514581; Sun, 16 Jan 2022 14:51:54 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id c15sm4594695ooq.30.2022.01.16.14.51.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jan 2022 14:51:53 -0800 (PST) Message-ID: <28339f0f-210c-040d-5495-6f2b259b9ffc@gmail.com> Date: Sun, 16 Jan 2022 19:51:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 01/25] avformat/matroskaenc: Fix potential overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/16/2022 7:49 PM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskaenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 41b2df7dbf..1dde12a7d9 100644 > --- a/libavformat/matroskaenc.c > +++ b/libavformat/matroskaenc.c > @@ -286,7 +286,7 @@ static void put_ebml_uint(AVIOContext *pb, uint32_t elementid, uint64_t val) > static void put_ebml_sint(AVIOContext *pb, uint32_t elementid, int64_t val) > { > int i, bytes = 1; > - uint64_t tmp = 2*(val < 0 ? val^-1 : val); > + uint64_t tmp = 2 * (uint64_t)(val < 0 ? val^-1 : val); nit: 2ULL is shorter. > > while (tmp >>= 8) > bytes++; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".