From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 272AB45053 for ; Sun, 5 Mar 2023 22:13:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C43B468BA4A; Mon, 6 Mar 2023 00:13:35 +0200 (EET) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6289268A5E1 for ; Mon, 6 Mar 2023 00:13:29 +0200 (EET) Received: by mail-ot1-f49.google.com with SMTP id p13-20020a9d744d000000b0069438f0db7eso4388890otk.3 for ; Sun, 05 Mar 2023 14:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=iqwlcC61bwWTWfzHy1RWGqdKzyZBlf4R4oXz1GgJY7Q=; b=U3O7ACTFs0+xLFPqMjHAWtEScfx+auW2HYRIpyVBCB1ShrI4iZ8oI23BFjFm/xyx2F XAF2nfRWGiGkaZ6ZVUicJHEG8pJWl25XP3JUkQUF6NfVeWEwQ8eqVqlYF6G8srWjSzlk qXmUUfsXY5bOpN1G4aXbSaflGmJbxBADzZIU35FX+zpii7UyXln6/Jj1CZ3etMCIqbhy LmSVeOnCz/8DvE7XsyAcn/mR0BnPNcHB44xbCG24jNelior4sDifC8amokIr1o3E1uU8 5tF93RDsOXivWCZrj69gM3la4xlP87rXNzb7793kq7JNB21LvYCNrnzTU+adZQaixwaa hNgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iqwlcC61bwWTWfzHy1RWGqdKzyZBlf4R4oXz1GgJY7Q=; b=voPIDL9AoeIS0UEnO5odsrexN69FaLNuWE2qsDI5zmLa3W1J5sOst/KjW0fvehFjBl AmQ3ra6JMP5FASwwgPN6Eq9SKmkcgFuI8vsIYJHYATLdJ05jUNsRrjxk1bSP86PzSu5d POgYKWa7bwjRyaqqYdjhi9bVQ5mJnb/1Zn9n24xCiGfZVb3QQTp9XM6LuXhO1OGZ1ssc IdMY5GqfoU/VMIpnYptDgLK1KhSlAxkvBr8URVZ5EG3Luym6aM4kkCPBJgQPc/vDk+9F GU15k9cTSM1WpTsxkJegbuXyc8EIT6mWJdNMUdSdmWam6FbXYkyuW6QONZwZuW60U2Me WOwQ== X-Gm-Message-State: AO0yUKWeFsRwSNuZ9iAnBWtbs1c140MBW4GXp566HR7mJihz7H6Zt59Z b7xgBKc35GSl9Hmc8nnM2tDKhLVklZI= X-Google-Smtp-Source: AK7set8nxU1lngEzGzMamO5Kr0pQ+C/EGGVzaECSybdZYg8lyZTgWHFVylqElAX/0i5ind5Z0Nf0GQ== X-Received: by 2002:a05:6830:44a2:b0:690:e454:fc1e with SMTP id r34-20020a05683044a200b00690e454fc1emr5315519otv.7.1678054407428; Sun, 05 Mar 2023 14:13:27 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id x2-20020a9d6282000000b00690eeb8b436sm3432529otk.65.2023.03.05.14.13.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 14:13:26 -0800 (PST) Message-ID: <28283e38-c0c1-b3ef-5591-032abecda47d@gmail.com> Date: Sun, 5 Mar 2023 19:13:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20230302130243.202-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20230302130243.202-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/graphparser: fix filter instance name when an id is provided X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/2023 10:02 AM, James Almer wrote: > Restores the behavior of naming the instance filter@id, which was accidentally changed > to simpy id in commit f17051eaae. > > Fixes ticket #10226. > > Signed-off-by: James Almer > --- > libavfilter/graphparser.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/graphparser.c b/libavfilter/graphparser.c > index 8e12416ccb..4347131fad 100644 > --- a/libavfilter/graphparser.c > +++ b/libavfilter/graphparser.c > @@ -532,8 +532,7 @@ int avfilter_graph_segment_create_filters(AVFilterGraphSegment *seg, int flags) > for (size_t j = 0; j < ch->nb_filters; j++) { > AVFilterParams *p = ch->filters[j]; > const AVFilter *f = avfilter_get_by_name(p->filter_name); > - char inst_name[30], *name = p->instance_name ? p->instance_name : > - inst_name; > + char name[64]; > > // skip already processed filters > if (p->filter || !p->filter_name) > @@ -546,7 +545,9 @@ int avfilter_graph_segment_create_filters(AVFilterGraphSegment *seg, int flags) > } > > if (!p->instance_name) > - snprintf(inst_name, sizeof(inst_name), "Parsed_%s_%zu", f->name, idx); > + snprintf(name, sizeof(name), "Parsed_%s_%zu", f->name, idx); > + else > + snprintf(name, sizeof(name), "%s@%s", f->name, p->instance_name); > > p->filter = avfilter_graph_alloc_filter(seg->graph, f, name); > if (!p->filter) Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".