Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avcodec/mips: Fix MMI macro replaces in HEVC Decoder
@ 2022-08-18  7:15 戚铁铮
  2022-08-18  8:29 ` Hao Chen
  0 siblings, 1 reply; 4+ messages in thread
From: 戚铁铮 @ 2022-08-18  7:15 UTC (permalink / raw)
  To: ffmpeg-devel
  Cc: yinshiyou-hf, 田新超, 张志磊

The latest commit of Loongson MMI macro replaces were incorrect.
It makes a mass of green tints on HEVC videos when playing. I've
compared it with the older MMI implementation, and found out that
several lines have been replaced by wrong macros.


Signed-off-by: Qi Tiezheng <qitiezheng@360.cn>
---
 libavcodec/mips/hevcdsp_mmi.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)


diff --git a/libavcodec/mips/hevcdsp_mmi.c b/libavcodec/mips/hevcdsp_mmi.c
index 0ea88a7c08..2ded3fc0bb 100644
--- a/libavcodec/mips/hevcdsp_mmi.c
+++ b/libavcodec/mips/hevcdsp_mmi.c
@@ -80,7 +80,7 @@ void ff_hevc_put_hevc_qpel_h##w##_8_mmi(int16_t *dst, const uint8_t *_src, \
         "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
         "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
         "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
-        MMI_ULDC1(%[ftmp3], %[dst], 0x00)                                \
+        MMI_USDC1(%[ftmp3], %[dst], 0x00)                                \
                                                                          \
         "daddi        %[x],          %[x],         -0x01        \n\t"    \
         PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
@@ -178,7 +178,7 @@ void ff_hevc_put_hevc_qpel_hv##w##_8_mmi(int16_t *dst, const uint8_t *_src,\
         "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
         "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
         "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
-        MMI_ULDC1(%[ftmp3], %[tmp], 0x00)                                \
+        MMI_USDC1(%[ftmp3], %[tmp], 0x00)                                \
                                                                          \
         "daddi        %[x],          %[x],         -0x01        \n\t"    \
         PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
@@ -690,10 +690,10 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
                                                                         \
         "1:                                                     \n\t"   \
         "2:                                                     \n\t"   \
-        MMI_ULDC1(%[ftmp3], %[src], 0x00)                               \
-        MMI_ULDC1(%[ftmp4], %[src], 0x01)                               \
-        MMI_ULDC1(%[ftmp5], %[src], 0x02)                               \
-        MMI_ULDC1(%[ftmp6], %[src], 0x03)                               \
+        MMI_ULWC1(%[ftmp2], %[src], 0x00)                               \
+        MMI_ULWC1(%[ftmp3], %[src], 0x01)                               \
+        MMI_ULWC1(%[ftmp4], %[src], 0x02)                               \
+        MMI_ULWC1(%[ftmp5], %[src], 0x03)                               \
         "punpcklbh    %[ftmp2],      %[ftmp2],      %[ftmp0]    \n\t"   \
         "pmullh       %[ftmp2],      %[ftmp2],      %[ftmp1]    \n\t"   \
         "punpcklbh    %[ftmp3],      %[ftmp3],      %[ftmp0]    \n\t"   \
@@ -707,7 +707,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
         "paddh        %[ftmp2],      %[ftmp2],      %[ftmp3]    \n\t"   \
         "paddh        %[ftmp4],      %[ftmp4],      %[ftmp5]    \n\t"   \
         "paddh        %[ftmp2],      %[ftmp2],      %[ftmp4]    \n\t"   \
-        MMI_ULDC1(%[ftmp2], %[tmp], 0x00)                               \
+        MMI_USDC1(%[ftmp2], %[tmp], 0x00)                               \
                                                                         \
         "daddi        %[x],          %[x],         -0x01        \n\t"   \
         PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"   \
@@ -773,7 +773,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
         "paddw        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"   \
         "psraw        %[ftmp5],      %[ftmp5],      %[ftmp0]    \n\t"   \
         "packsswh     %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"   \
-        MMI_ULDC1(%[ftmp4], %[tmp], 0x02)                               \
+        MMI_ULDC1(%[ftmp4], %[tmp], 0x00)                               \
         "li           %[rtmp0],      0x10                       \n\t"   \
         "dmtc1        %[rtmp0],      %[ftmp8]                   \n\t"   \
         "punpcklhw    %[ftmp5],      %[ftmp2],      %[ftmp3]    \n\t"   \
--
2.25.1


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avcodec/mips: Fix MMI macro replaces in HEVC Decoder
  2022-08-18  7:15 [FFmpeg-devel] [PATCH] avcodec/mips: Fix MMI macro replaces in HEVC Decoder 戚铁铮
@ 2022-08-18  8:29 ` Hao Chen
  2022-08-18  9:17   ` 殷时友
  0 siblings, 1 reply; 4+ messages in thread
From: Hao Chen @ 2022-08-18  8:29 UTC (permalink / raw)
  To: ffmpeg-devel

There are still some bugs unresolved in HEVC decoding. The 
checkasm-hevc-pel test failed. It's suggested to repair together.

在 2022/8/18 下午3:15, 戚铁铮 写道:
> The latest commit of Loongson MMI macro replaces were incorrect.
> It makes a mass of green tints on HEVC videos when playing. I've
> compared it with the older MMI implementation, and found out that
> several lines have been replaced by wrong macros.
>
>
> Signed-off-by: Qi Tiezheng <qitiezheng@360.cn>
> ---
>   libavcodec/mips/hevcdsp_mmi.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
>
> diff --git a/libavcodec/mips/hevcdsp_mmi.c b/libavcodec/mips/hevcdsp_mmi.c
> index 0ea88a7c08..2ded3fc0bb 100644
> --- a/libavcodec/mips/hevcdsp_mmi.c
> +++ b/libavcodec/mips/hevcdsp_mmi.c
> @@ -80,7 +80,7 @@ void ff_hevc_put_hevc_qpel_h##w##_8_mmi(int16_t *dst, const uint8_t *_src, \
>           "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
>           "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
>           "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
> -        MMI_ULDC1(%[ftmp3], %[dst], 0x00)                                \
> +        MMI_USDC1(%[ftmp3], %[dst], 0x00)                                \
>                                                                            \
>           "daddi        %[x],          %[x],         -0x01        \n\t"    \
>           PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
> @@ -178,7 +178,7 @@ void ff_hevc_put_hevc_qpel_hv##w##_8_mmi(int16_t *dst, const uint8_t *_src,\
>           "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
>           "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
>           "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
> -        MMI_ULDC1(%[ftmp3], %[tmp], 0x00)                                \
> +        MMI_USDC1(%[ftmp3], %[tmp], 0x00)                                \
>                                                                            \
>           "daddi        %[x],          %[x],         -0x01        \n\t"    \
>           PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
> @@ -690,10 +690,10 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
>                                                                           \
>           "1:                                                     \n\t"   \
>           "2:                                                     \n\t"   \
> -        MMI_ULDC1(%[ftmp3], %[src], 0x00)                               \
> -        MMI_ULDC1(%[ftmp4], %[src], 0x01)                               \
> -        MMI_ULDC1(%[ftmp5], %[src], 0x02)                               \
> -        MMI_ULDC1(%[ftmp6], %[src], 0x03)                               \
> +        MMI_ULWC1(%[ftmp2], %[src], 0x00)                               \
> +        MMI_ULWC1(%[ftmp3], %[src], 0x01)                               \
> +        MMI_ULWC1(%[ftmp4], %[src], 0x02)                               \
> +        MMI_ULWC1(%[ftmp5], %[src], 0x03)                               \
>           "punpcklbh    %[ftmp2],      %[ftmp2],      %[ftmp0]    \n\t"   \
>           "pmullh       %[ftmp2],      %[ftmp2],      %[ftmp1]    \n\t"   \
>           "punpcklbh    %[ftmp3],      %[ftmp3],      %[ftmp0]    \n\t"   \
> @@ -707,7 +707,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
>           "paddh        %[ftmp2],      %[ftmp2],      %[ftmp3]    \n\t"   \
>           "paddh        %[ftmp4],      %[ftmp4],      %[ftmp5]    \n\t"   \
>           "paddh        %[ftmp2],      %[ftmp2],      %[ftmp4]    \n\t"   \
> -        MMI_ULDC1(%[ftmp2], %[tmp], 0x00)                               \
> +        MMI_USDC1(%[ftmp2], %[tmp], 0x00)                               \
>                                                                           \
>           "daddi        %[x],          %[x],         -0x01        \n\t"   \
>           PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"   \
> @@ -773,7 +773,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
>           "paddw        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"   \
>           "psraw        %[ftmp5],      %[ftmp5],      %[ftmp0]    \n\t"   \
>           "packsswh     %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"   \
> -        MMI_ULDC1(%[ftmp4], %[tmp], 0x02)                               \
> +        MMI_ULDC1(%[ftmp4], %[tmp], 0x00)                               \
>           "li           %[rtmp0],      0x10                       \n\t"   \
>           "dmtc1        %[rtmp0],      %[ftmp8]                   \n\t"   \
>           "punpcklhw    %[ftmp5],      %[ftmp2],      %[ftmp3]    \n\t"   \
> --
> 2.25.1
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avcodec/mips: Fix MMI macro replaces in HEVC Decoder
  2022-08-18  8:29 ` Hao Chen
@ 2022-08-18  9:17   ` 殷时友
  0 siblings, 0 replies; 4+ messages in thread
From: 殷时友 @ 2022-08-18  9:17 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



> 2022年8月18日 16:29,Hao Chen <chenhao@loongson.cn> 写道:
> 
> There are still some bugs unresolved in HEVC decoding. The checkasm-hevc-pel test failed. It's suggested to repair together.
> 
> 在 2022/8/18 下午3:15, 戚铁铮 写道:
>> The latest commit of Loongson MMI macro replaces were incorrect.
>> It makes a mass of green tints on HEVC videos when playing. I've
>> compared it with the older MMI implementation, and found out that
>> several lines have been replaced by wrong macros.
>> 
>> 
>> Signed-off-by: Qi Tiezheng <qitiezheng@360.cn>
>> ---
>>  libavcodec/mips/hevcdsp_mmi.c | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>> 
>> 
>> diff --git a/libavcodec/mips/hevcdsp_mmi.c b/libavcodec/mips/hevcdsp_mmi.c
>> index 0ea88a7c08..2ded3fc0bb 100644
>> --- a/libavcodec/mips/hevcdsp_mmi.c
>> +++ b/libavcodec/mips/hevcdsp_mmi.c
>> @@ -80,7 +80,7 @@ void ff_hevc_put_hevc_qpel_h##w##_8_mmi(int16_t *dst, const uint8_t *_src, \
>>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
>>          "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
>>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
>> -        MMI_ULDC1(%[ftmp3], %[dst], 0x00)                                \
>> +        MMI_USDC1(%[ftmp3], %[dst], 0x00)                                \
>>                                                                           \
>>          "daddi        %[x],          %[x],         -0x01        \n\t"    \
>>          PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
>> @@ -178,7 +178,7 @@ void ff_hevc_put_hevc_qpel_hv##w##_8_mmi(int16_t *dst, const uint8_t *_src,\
>>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
>>          "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
>>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
>> -        MMI_ULDC1(%[ftmp3], %[tmp], 0x00)                                \
>> +        MMI_USDC1(%[ftmp3], %[tmp], 0x00)                                \
>>                                                                           \
>>          "daddi        %[x],          %[x],         -0x01        \n\t"    \
>>          PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
>> @@ -690,10 +690,10 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
>>                                                                          \
>>          "1:                                                     \n\t"   \
>>          "2:                                                     \n\t"   \
>> -        MMI_ULDC1(%[ftmp3], %[src], 0x00)                               \
>> -        MMI_ULDC1(%[ftmp4], %[src], 0x01)                               \
>> -        MMI_ULDC1(%[ftmp5], %[src], 0x02)                               \
>> -        MMI_ULDC1(%[ftmp6], %[src], 0x03)                               \
>> +        MMI_ULWC1(%[ftmp2], %[src], 0x00)                               \
>> +        MMI_ULWC1(%[ftmp3], %[src], 0x01)                               \
>> +        MMI_ULWC1(%[ftmp4], %[src], 0x02)                               \
>> +        MMI_ULWC1(%[ftmp5], %[src], 0x03)                               \
>>          "punpcklbh    %[ftmp2],      %[ftmp2],      %[ftmp0]    \n\t"   \
>>          "pmullh       %[ftmp2],      %[ftmp2],      %[ftmp1]    \n\t"   \
>>          "punpcklbh    %[ftmp3],      %[ftmp3],      %[ftmp0]    \n\t"   \
>> @@ -707,7 +707,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
>>          "paddh        %[ftmp2],      %[ftmp2],      %[ftmp3]    \n\t"   \
>>          "paddh        %[ftmp4],      %[ftmp4],      %[ftmp5]    \n\t"   \
>>          "paddh        %[ftmp2],      %[ftmp2],      %[ftmp4]    \n\t"   \
>> -        MMI_ULDC1(%[ftmp2], %[tmp], 0x00)                               \
>> +        MMI_USDC1(%[ftmp2], %[tmp], 0x00)                               \
>>                                                                          \
>>          "daddi        %[x],          %[x],         -0x01        \n\t"   \
>>          PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"   \
>> @@ -773,7 +773,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
>>          "paddw        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"   \
>>          "psraw        %[ftmp5],      %[ftmp5],      %[ftmp0]    \n\t"   \
>>          "packsswh     %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"   \
>> -        MMI_ULDC1(%[ftmp4], %[tmp], 0x02)                               \
>> +        MMI_ULDC1(%[ftmp4], %[tmp], 0x00)                               \

Here should be ‘src2'
MMI_ULDC1(%[FTMP4], %[src2], 0x00)



>>          "li           %[rtmp0],      0x10                       \n\t"   \
>>          "dmtc1        %[rtmp0],      %[ftmp8]                   \n\t"   \
>>          "punpcklhw    %[ftmp5],      %[ftmp2],      %[ftmp3]    \n\t"   \
>> --
>> 2.25.1
>> 
>> 

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avcodec/mips: Fix MMI macro replaces in HEVC Decoder
@ 2022-08-18 10:26 戚铁铮
  0 siblings, 0 replies; 4+ messages in thread
From: 戚铁铮 @ 2022-08-18 10:26 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


At 2022/8/18 PM 5:18,"ffmpeg-devel"<ffmpeg-devel-bounces@ffmpeg.org> "殷时友" <yinshiyou-hf@loongson.cn> wrote:
       
    > 2022年8月18日 16:29,Hao Chen <chenhao@loongson.cn> 写道:
    > 
    > There are still some bugs unresolved in HEVC decoding. The checkasm-hevc-pel test failed. It's suggested to repair together.
    > 
    > 在 2022/8/18 下午3:15, 戚铁铮 写道:
    >> The latest commit of Loongson MMI macro replaces were incorrect.
    >> It makes a mass of green tints on HEVC videos when playing. I've
    >> compared it with the older MMI implementation, and found out that
    >> several lines have been replaced by wrong macros.
    >> 
    >> 
    >> Signed-off-by: Qi Tiezheng <qitiezheng@360.cn>
    >> ---
    >>  libavcodec/mips/hevcdsp_mmi.c | 16 ++++++++--------
    >>  1 file changed, 8 insertions(+), 8 deletions(-)
    >> 
    >> 
    >> diff --git a/libavcodec/mips/hevcdsp_mmi.c b/libavcodec/mips/hevcdsp_mmi.c
    >> index 0ea88a7c08..2ded3fc0bb 100644
    >> --- a/libavcodec/mips/hevcdsp_mmi.c
    >> +++ b/libavcodec/mips/hevcdsp_mmi.c
    >> @@ -80,7 +80,7 @@ void ff_hevc_put_hevc_qpel_h##w##_8_mmi(int16_t *dst, const uint8_t *_src, \
    >>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
    >>          "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
    >>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
    >> -        MMI_ULDC1(%[ftmp3], %[dst], 0x00)                                \
    >> +        MMI_USDC1(%[ftmp3], %[dst], 0x00)                                \
    >>                                                                           \
    >>          "daddi        %[x],          %[x],         -0x01        \n\t"    \
    >>          PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
    >> @@ -178,7 +178,7 @@ void ff_hevc_put_hevc_qpel_hv##w##_8_mmi(int16_t *dst, const uint8_t *_src,\
    >>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp4]    \n\t"    \
    >>          "paddh        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"    \
    >>          "paddh        %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"    \
    >> -        MMI_ULDC1(%[ftmp3], %[tmp], 0x00)                                \
    >> +        MMI_USDC1(%[ftmp3], %[tmp], 0x00)                                \
    >>                                                                           \
    >>          "daddi        %[x],          %[x],         -0x01        \n\t"    \
    >>          PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"    \
    >> @@ -690,10 +690,10 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
    >>                                                                          \
    >>          "1:                                                     \n\t"   \
    >>          "2:                                                     \n\t"   \
    >> -        MMI_ULDC1(%[ftmp3], %[src], 0x00)                               \
    >> -        MMI_ULDC1(%[ftmp4], %[src], 0x01)                               \
    >> -        MMI_ULDC1(%[ftmp5], %[src], 0x02)                               \
    >> -        MMI_ULDC1(%[ftmp6], %[src], 0x03)                               \
    >> +        MMI_ULWC1(%[ftmp2], %[src], 0x00)                               \
    >> +        MMI_ULWC1(%[ftmp3], %[src], 0x01)                               \
    >> +        MMI_ULWC1(%[ftmp4], %[src], 0x02)                               \
    >> +        MMI_ULWC1(%[ftmp5], %[src], 0x03)                               \
    >>          "punpcklbh    %[ftmp2],      %[ftmp2],      %[ftmp0]    \n\t"   \
    >>          "pmullh       %[ftmp2],      %[ftmp2],      %[ftmp1]    \n\t"   \
    >>          "punpcklbh    %[ftmp3],      %[ftmp3],      %[ftmp0]    \n\t"   \
    >> @@ -707,7 +707,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
    >>          "paddh        %[ftmp2],      %[ftmp2],      %[ftmp3]    \n\t"   \
    >>          "paddh        %[ftmp4],      %[ftmp4],      %[ftmp5]    \n\t"   \
    >>          "paddh        %[ftmp2],      %[ftmp2],      %[ftmp4]    \n\t"   \
    >> -        MMI_ULDC1(%[ftmp2], %[tmp], 0x00)                               \
    >> +        MMI_USDC1(%[ftmp2], %[tmp], 0x00)                               \
    >>                                                                          \
    >>          "daddi        %[x],          %[x],         -0x01        \n\t"   \
    >>          PTR_ADDIU    "%[src],        %[src],        0x04        \n\t"   \
    >> @@ -773,7 +773,7 @@ void ff_hevc_put_hevc_epel_bi_hv##w##_8_mmi(uint8_t *_dst,              \
    >>          "paddw        %[ftmp5],      %[ftmp5],      %[ftmp6]    \n\t"   \
    >>          "psraw        %[ftmp5],      %[ftmp5],      %[ftmp0]    \n\t"   \
    >>          "packsswh     %[ftmp3],      %[ftmp3],      %[ftmp5]    \n\t"   \
    >> -        MMI_ULDC1(%[ftmp4], %[tmp], 0x02)                               \
    >> +        MMI_ULDC1(%[ftmp4], %[tmp], 0x00)                               \
    
    Here should be ‘src2'
    MMI_ULDC1(%[FTMP4], %[src2], 0x00)
    
    
    
    >>          "li           %[rtmp0],      0x10                       \n\t"   \
    >>          "dmtc1        %[rtmp0],      %[ftmp8]                   \n\t"   \
    >>          "punpcklhw    %[ftmp5],      %[ftmp2],      %[ftmp3]    \n\t"   \
    >> --
    >> 2.25.1
    >> 
    >> 


Thanks for the review and pointing the flaw. I will resend the patch.    

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-18 10:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18  7:15 [FFmpeg-devel] [PATCH] avcodec/mips: Fix MMI macro replaces in HEVC Decoder 戚铁铮
2022-08-18  8:29 ` Hao Chen
2022-08-18  9:17   ` 殷时友
2022-08-18 10:26 戚铁铮

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git