From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2791A42B3C for ; Thu, 26 May 2022 00:39:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C2E568B583; Thu, 26 May 2022 03:39:36 +0300 (EEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A7708680075 for ; Thu, 26 May 2022 03:39:23 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653525574; x=1685061574; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Qu5d57BWTRIu78rIES9OdHIeFoU/5KYTEIblgBQKlKs=; b=NP8HVBOv2dxub63c+fVfsXvzwUmDtEmKgdWDp3TxpMwWakKpkYv8sWA8 83sk9JnPSvWkTkVqMYGAxp4K4KEpK0yGMavHdHJF3BPxuAZya8930eqA3 xy8wCus0uJTN9TdbGKBHmJg3ILj5IEk1qZ9bb3CoxUhjFmmjBIYiihG14 NH+X4Tx8Br9DFwwNQjyoUNo5oZ60bZKQ9IUcBgQoqCHTW4DdZtbzhDHWa AQjR5Dbm5Do6095wQxk1o/vNix7PJV8icb9mjOUt49bdVLO8ZsR7FiT76 q+vOlpxTUU0DOAcqTuFq/Ej7dDyOUc9f3RfkX02iz8IpsG8pp7P9uiGxk g==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="273979791" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="273979791" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2022 17:39:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="820979267" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 25 May 2022 17:39:19 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 17:39:18 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 25 May 2022 17:39:18 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 25 May 2022 17:39:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zj/LWachb1TtA7pUGJX8kbtb5zQyiRwdqmwSw9xbwczfPFPwQGUbxqS4+iDWeJrn42p4/pjbHXpCMOk8M9iN88MQAnnQypOLoQFLYNxpIJ6++pmkBf825BwE9NRe3QcyamOLRv0sRxwCnCUwfS5MYo67UzY9voW4woEsZsU/u4T++zpJnmOxSMN4O70lZ0XjH6LkYkb87UpTM2YiYASeFYMWJVeqz7Hlw8JGDdsUeKegjdEfs7HxCpMUdbpSNi7MLOhH4jQxkcDBXLye//ZFzMfH20Tg7XPGc5l8wKOQtOJYOlyR7DtPdQNohERDVeHBYnc+ZvhnFTtqECZjsICi6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qu5d57BWTRIu78rIES9OdHIeFoU/5KYTEIblgBQKlKs=; b=IApQKxHBsgQPNrx0SsCdj8CyKQwRgmaR24cohOGRANvhHGQo3X9Z+n2cujRvH/X7EpGIpdDoZaj1Fc68lkwsFV1vpu+OeZQ5/Pn7GuIWx3nluDEelEuUwftkJtJw5oJ6B4q9gySvG9GAoOeq7obWLi0NeIWIwXlMRCfZCoNKemxWE/XKJjjevIZYPEVUODBs5rDdMBozWbyJjbUFuCe0ftCaKti8adKgb19U1j4VLKdRJSiACGIJrlGbbdKML128PFjzVU5B2/CaPy8i+JHbcNMtz+qG0l7khNvjoRPz9EkavxgABPXHlrOq6jpq4mNbvMJE6wgCkdvgUQi7/tr3Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CY4PR11MB1256.namprd11.prod.outlook.com (2603:10b6:903:25::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 00:39:16 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73%6]) with mapi id 15.20.5293.013; Thu, 26 May 2022 00:39:16 +0000 From: "Xiang, Haihao" To: "timo@rothenpieler.org" , "ffmpeg-devel@ffmpeg.org" , "haihao.xiang-at-intel.com@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx Thread-Index: AQHYcFF7XU3XidBeXUO3iRXKqD8oE60wUWqA Date: Thu, 26 May 2022 00:39:16 +0000 Message-ID: <2814a72206b3bf8cc13326ef48ca8059540f6950.camel@intel.com> References: <20220522121911.10993-1-haihao.xiang@intel.com> <167a0f90-1d7e-1d42-85f7-5cc301faa17a@rothenpieler.org> In-Reply-To: <167a0f90-1d7e-1d42-85f7-5cc301faa17a@rothenpieler.org> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16bdeb8a-8df3-45c1-000e-08da3eb02a20 x-ms-traffictypediagnostic: CY4PR11MB1256:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y6irtEHI1stCWZf2fHzBgFgobHj6t31p9iPasUJvyBpWwTH8XT0OXLeEGTOrHnX/H9I2fGMh0GZNZnCBSmAyj+TgPgqqLSmIX8S36PvXCEmp+YWOLNuBKwRdPyK8J5lbdT49ACUYiIED9JFCmdNwYKeLSeBMFLpK3N5sVJZRyIEzlamACbk6TftkhAeIDX6JJ23Ds+euUvcpzNY5IcsMZz2olgzTULUviE7xH+EFAJXgg8CSCZFgJD/7gOdaoKDVOpLgGk6pwHE7XcIor43noTAra6IIJGmPg5hUVEdojRsOx33lI/8LBTzvXXmg3boMA3nFT1fHi6YSS8YsPPNwbIDmQEOnRwJawYzLi94CBGUjSXfA571nF/1A5aQAT88na/DuY2hoqrt76sxojZBq8/VaPuqlnl+Vnc6PhOH0D1+sIHYZWF0VJGSefhGpxFKulax3P8oXXek48EC3YeuITiiVo5bIXpFVoDo+M/mkjjtu2TYGwFi75rmRmPf4j3SN/7P0OSJWYqvKlcWbPYyNyPTgftkOb7heCZqkkVJrkfePljXTn0t+aEAVMFzxtBC6pmpAoNT5KiX9YhXco5uGg7dlzndHf6aPTbp52Jf37HQJfCA2M03Q9hmrmPTj1T3xXi6qMB99U74JjO4fShc2oBeG6ruL4YJYhCxOFZgLu2rvGu9xYJcLjHWHaNj7eqaLA/hvZPa0FmpCM/TIHf2tNEodFwFWHHCFAyxsFIMaVvRHkKPfneyMXxw+L3chfdHOiLAR6tio3hwd5+ZrVQsuQEWllSwIJtBQaI5p0nckSZJKpeADSoQDlXfCiMvDrfeN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(8936002)(122000001)(6486002)(186003)(83380400001)(966005)(5660300002)(2906002)(53546011)(71200400001)(26005)(316002)(6512007)(2616005)(110136005)(36756003)(38070700005)(82960400001)(91956017)(66446008)(8676002)(66946007)(64756008)(66556008)(66476007)(76116006)(38100700002)(86362001)(6506007)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T3l0ZEhxcThwR0xjTHdMaFZuVCs2Qm12WTV1Y3UzZVNuUTdmaCtXTys2Nmx4?= =?utf-8?B?MzNBT2dqSC9uZHdJU0hBYzAzNlFzOEg3UyszL2R1L3RqM3d4QmlPVnJRUDJM?= =?utf-8?B?dlA5MDVoZTlkaHo5OG9VYnBLMFR3RlRML0dIZ2N1dHJjdCszYUZoZk1FYkFl?= =?utf-8?B?b2FheG9IWTRQS200NWM1Z1dkT3M2enpERGo1Y2x3SjZZOFlSSElRZkRET0pp?= =?utf-8?B?NkhnT0pOWk9ySElIQzdRejYzSHhhVzNFM3Vrd0VXYTBuTDN1UllvVkZDQ1hP?= =?utf-8?B?WC82dFV3NGVmU3RmWlJTSVJvUmNNSzhybHM4ZnNlN2hickxHOXZqWjdFVWNT?= =?utf-8?B?aUdpVmFheDk3eFFQM2NTU1QyNWtVRWJ6cDBOYThkK2gvMi9FYnpCblBVVThE?= =?utf-8?B?RFptQnNhazNkV1l4QytmdnRzSEZJVWs2cWlFbWJDeTVGakJhYUhLeWRIS21M?= =?utf-8?B?L2swVUhSYUxZSjVCY01QQlRRWi9qWUsxbitZL0NsSzJ1Qlp3REthNUdQQ3RI?= =?utf-8?B?V2t6WmYxTWZiQW1YZEw1Q2JQN2hVR1NoMWRJUExHUFdkUDRKTGZta2dCeG5n?= =?utf-8?B?NmYxNm9tY05mUE9CcldQUGd5Y1UvK2xDNVVzQXN6c1lFSmRwUGwzL2VndnBL?= =?utf-8?B?Skg1d3ZsWHhsazE0SEZUUmpvb3JtWFhlNkZmZzFzbTl5aEY0ZDFscWtDNjRw?= =?utf-8?B?Y2NXeTNOS2FJZ0ZWcW9wQ1A4QTNBUnkrVkxFdmZob05IWmlzaGlmNUF0djlq?= =?utf-8?B?cVcwRnV6Y2RINGszc0sxbG5sb0RaTlBRRmZoNEhLNTh4TUowWGhyTndkckZU?= =?utf-8?B?REpLcFhqNGtiRDZvbWNSRzkrTmoxbU8wTVkra1FEQWI2U2hSVm1QK01GV1pL?= =?utf-8?B?Yk0yT3lRR0NIeGM5T3FCZHNhNFAyY3ppSCs3UEhvMzg1TCtUdHJmaDlKOTd6?= =?utf-8?B?emJxaW0rNDZUR21UNHEyQW5WcmV5SGgwdGE4akFETzZsYVF3V0Z3cXFGNjVH?= =?utf-8?B?WHMrR0dYcVpjN2lWTXF6Q25OTGUzWmlORHBWTm9qQ1hOTDF2cy9RMEczUnpN?= =?utf-8?B?ak1ZVWM5VFU5cmZkM3R0RG1oT1pUTVNhMFdWS284N2dmL2ZtWGo2bzdNeStz?= =?utf-8?B?dzRweDQwWW0xOWZVM05KZXowR3dMenlQOE1DOFJtRndTdElNUEMvMlFWZ0pu?= =?utf-8?B?dUh3Q1p4enZPWHBhaTZBU1BWR1hCZnlJT25VWVU3cFkxR1BFYUNjbWZVK2tC?= =?utf-8?B?WUxidE9vbHkyZERVdG9vV1poWERia1JKQ3J0R1k3L0RxVGJrWDJ3bTFBaVhR?= =?utf-8?B?c1Fmb1ZDSmR0OVgwZkN3UUsvUHpBS2pNcnk5bVBmbmhIVUVnTWZ5dG1JZUlV?= =?utf-8?B?bzYwUzlYSkNGSUxXS1RKeS9BWDlJNDBxTWpidWxxSTRJbUVCMVEwTCtMTldY?= =?utf-8?B?MW9GcDdFWnJYNHQvekR2QlNwT1hqUGp6b1R2ekx3YjZWSlhTWEJtR2RKNElk?= =?utf-8?B?cW5lbC9Yejk0Q3ZlbTR0THd2eGFzUmZPZTB3ajJCVWtoR1ByODFyYXk0cTV1?= =?utf-8?B?T1FSeEVzSEJjNi8waHVrZTZwZkxVWkVQeG80OVhnbEh0TmdmSit2VE9DTWM0?= =?utf-8?B?RUNQQlEvMGM0VXJaZFFQSWxXWFU2SVY0S3hMQ0xFR1VTb3RUTmxEVkd2ZW9B?= =?utf-8?B?K2RwSWFUQ3ZOMEFmekI4Z2FxUGcrN01GcncrWUlZclZsdFZGaE5nMXZHWFpw?= =?utf-8?B?Mk9XMnJoYXdRenZaWi9xWUJYYXlyRjdrZm5HTmJhdWNsVUxBMllKL2Y3Z0ov?= =?utf-8?B?TjVwNGhhSDJPUSs4L3RjN1dDeklHL1VuSEhLV2NJRllLYnUxTGVIbDViNnh3?= =?utf-8?B?NEtnVWp0bEFOWHhrN1dvdFlNSWtDdlJQT0ZPb2pLNk0ycEc3OExwdkQ1Q0t6?= =?utf-8?B?VjNTZC9vbG5BVTJsR3B3cnFBNmgzWC91Tm5TeXdNUmFvOFBaL3R1empCVWNC?= =?utf-8?B?QWhBYlJtWDFob2xjQm9PU2svcGR4TVd5c29yTThEelByek5vVTBweHNLL2Y1?= =?utf-8?B?OEkxY2FmQUt3TEkwSlJTajFXWDhrSm1oY2dVZVZsNGM5aUFoS1pwd05nclBD?= =?utf-8?B?UlNpYVlZc2lCZGNxNnJOdFpSLzA0TkdiWGV4VWRqRDhpQ21sWWhydnFQNm9E?= =?utf-8?B?VkkrTDJGK2lkdUh3U1Uwc2pNSXFTYmZEQ1FIVytFVmdpQk5Ua2pyays2aWF4?= =?utf-8?B?a2RVOWl2RllLQ0U4aUs4QTJ1YkFlK2ZrQUg4UlQrdG80VkZ6dngvUDA4REs2?= =?utf-8?B?OXNUaURGcFZHTEFtNDlkWDZ3Nmx5K1BJU3VMU1dtZGd0bzVoUFlDeDRxNnhS?= =?utf-8?Q?ZjIfssDInFNzwIvI=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16bdeb8a-8df3-45c1-000e-08da3eb02a20 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 00:39:16.8096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uwOKSIaXlIBrWeRL1c5Atqs74mNINwMuFp50TioXXl82js17+TRg1epjJc8jbCxoCuN2fnubpa6aRhdRXRuYXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1256 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-05-25 at 18:05 +0200, Timo Rothenpieler wrote: > > On 22/05/2022 14:19, Haihao Xiang wrote: > > libmfx 1.28 was released 3 years ago, it is easy to get a greater > > version than 1.28. We may remove lots of compile-time checks if adding > > the requirement for the minimal version in the configure script. > > --- > > configure | 7 +- > > libavcodec/qsv.c | 24 -- > > libavcodec/qsvenc.c | 471 +++++++++++++------------------------ > > libavcodec/qsvenc.h | 51 +--- > > libavcodec/qsvenc_h264.c | 6 - > > libavcodec/qsvenc_hevc.c | 10 - > > libavfilter/vf_scale_qsv.c | 13 +- > > libavfilter/vf_vpp_qsv.c | 143 ++++++----- > > libavutil/hwcontext_qsv.c | 2 - > > 9 files changed, 249 insertions(+), 478 deletions(-) > > > > diff --git a/configure b/configure > > index f115b21064..2337f0a8f2 100755 > > --- a/configure > > +++ b/configure > > @@ -6566,8 +6566,11 @@ enabled liblensfun && require_pkg_config > > liblensfun lensfun lensfun.h lf_ > > # Media SDK or Intel Media Server Studio, these don't come with > > # pkg-config support. Instead, users should make sure that the build > > # can find the libraries and headers through other means. > > -enabled libmfx && { check_pkg_config libmfx libmfx > > "mfx/mfxvideo.h" MFXInit || > > - { require libmfx "mfx/mfxvideo.h" MFXInit "- > > llibmfx $advapi32_extralibs" && warn "using libmfx without pkg-config"; } } > > +enabled libmfx && { check_pkg_config libmfx "mfx >= 1.28" > > "mfx/mfxvideo.h" MFXInit || > > + { require libmfx "mfx/mfxvideo.h > > mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && > > This broke build with mfx_dispatch. Before this, it checked for > libmfx.pc. Now it checks for mfx.pc, which is not installed by it. > > Which of those is correct? It should definitely not drop support for > libmfx.pc, which was checked before this. Sorry for this issue caused to you. The mfx dispatcher installed from https://github.com/Intel-Media-SDK/MediaSDK has both mfx.pc and libmfx.pc, but definitely it should check for libmfx.pc here. I'll fix it ASAP. BRs Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".