From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/6] checkasm/takdsp: add decorrelate_sm test
Date: Fri, 22 Dec 2023 11:49:39 +0200 (EET)
Message-ID: <27cca083-9783-67cc-b81f-b29b2b1c3a5d@martin.st> (raw)
In-Reply-To: <CAEa-L+vamksy3_ndECce4Fv=cBC11doiL=vaTCDXKfSOXazWRg@mail.gmail.com>
On Mon, 18 Dec 2023, flow gg wrote:
>
> +static void test_decorrelate_sm(TAKDSPContext *s) {
> +#define BUF_SIZE 1024
> + declare_func(void, int32_t *, int32_t *, int);
> +
> + if (check_func(s->decorrelate_sm, "decorrelate_sm")) {
> + LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
> +
> + randomize(p1, BUF_SIZE);
> + memcpy(p1, p1_2, BUF_SIZE);
p1 is the one that is filled with initialized data here, not the other way
around. Clang optimizes out this memcpy since it's copying uninitialized
data.
> + randomize(p2, BUF_SIZE);
> + memcpy(p2_2, p2, BUF_SIZE);
> +
> + call_ref(p1, p2, BUF_SIZE);
> + call_new(p1_2, p2_2, BUF_SIZE);
> +
> + if (memcmp(p2, p2_2, BUF_SIZE) != 0){
As this function mutates both p1 and p2, we need to check both of them.
Also *sizeof().
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-22 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:15 flow gg
2023-12-22 9:49 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27cca083-9783-67cc-b81f-b29b2b1c3a5d@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git