From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vc1dsp: R-V V inv_trans
Date: Tue, 05 Dec 2023 18:41:36 +0200
Message-ID: <2772910.fE53gIofYm@basile.remlab.net> (raw)
In-Reply-To: <CAEa-L+tn5tA9sLW7O_c1dW8m-K+6Gmr6-qD1etzyHdKWn3QkKA@mail.gmail.com>
Hi,
> diff --git a/libavcodec/riscv/Makefile b/libavcodec/riscv/Makefile
> index 2d0e6c19c8..442c5961ea 100644
> --- a/libavcodec/riscv/Makefile
> +++ b/libavcodec/riscv/Makefile
> @@ -39,5 +39,7 @@ OBJS-$(CONFIG_PIXBLOCKDSP) += riscv/pixblockdsp_init.o \
> RVV-OBJS-$(CONFIG_PIXBLOCKDSP) += riscv/pixblockdsp_rvv.o
> OBJS-$(CONFIG_UTVIDEO_DECODER) += riscv/utvideodsp_init.o
> RVV-OBJS-$(CONFIG_UTVIDEO_DECODER) += riscv/utvideodsp_rvv.o
> +OBJS-$(CONFIG_VC1DSP) += riscv/vc1dsp_init.o
> +RVV-OBJS-$(CONFIG_VC1DSP) += riscv/vc1dsp_rvv.o
> OBJS-$(CONFIG_VORBIS_DECODER) += riscv/vorbisdsp_init.o
> RVV-OBJS-$(CONFIG_VORBIS_DECODER) += riscv/vorbisdsp_rvv.o
> diff --git a/libavcodec/riscv/vc1dsp_init.c b/libavcodec/riscv/vc1dsp_init.c
> new file mode 100644
> index 0000000000..6a04bea6d6
> --- /dev/null
> +++ b/libavcodec/riscv/vc1dsp_init.c
> @@ -0,0 +1,47 @@
> +/*
> + * Copyright (c) 2023 Institue of Software Chinese Academy of Sciences
> (ISCAS).
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
> USA
> + */
> +
> +#include <stdint.h>
> +
> +#include "libavutil/attributes.h"
> +#include "libavutil/cpu.h"
> +#include "libavutil/riscv/cpu.h"
> +#include "libavcodec/vc1.h"
> +
> +void ff_vc1_inv_trans_8x8_dc_rvv(uint8_t *dest, ptrdiff_t stride, int16_t
> *block);
> +void ff_vc1_inv_trans_4x8_dc_rvv(uint8_t *dest, ptrdiff_t stride, int16_t
> *block);
> +void ff_vc1_inv_trans_8x4_dc_rvv(uint8_t *dest, ptrdiff_t stride, int16_t
> *block);
> +void ff_vc1_inv_trans_4x4_dc_rvv(uint8_t *dest, ptrdiff_t stride, int16_t
> *block);
> +
> +av_cold void ff_vc1dsp_init_riscv(VC1DSPContext *dsp)
> +{
> +#if HAVE_RVV
> + int flags = av_get_cpu_flags();
> +
> + if ((flags & AV_CPU_FLAG_RVV_I64) && ff_get_rv_vlenb() >= 16) {
> + dsp->vc1_inv_trans_8x8_dc = ff_vc1_inv_trans_8x8_dc_rvv;
> + dsp->vc1_inv_trans_8x4_dc = ff_vc1_inv_trans_8x4_dc_rvv;
> + }
This block can be folded into the next. You don't need to check VLENB twice.
> + if ((flags & AV_CPU_FLAG_RVV_I32) && ff_get_rv_vlenb() >= 16) {
> + dsp->vc1_inv_trans_4x8_dc = ff_vc1_inv_trans_4x8_dc_rvv;
> + dsp->vc1_inv_trans_4x4_dc = ff_vc1_inv_trans_4x4_dc_rvv;
> + }
> +#endif
> +}
> diff --git a/libavcodec/riscv/vc1dsp_rvv.S b/libavcodec/riscv/vc1dsp_rvv.S
> new file mode 100644
> index 0000000000..b865bd2cbc
> --- /dev/null
> +++ b/libavcodec/riscv/vc1dsp_rvv.S
> @@ -0,0 +1,114 @@
> +/*
> + * Copyright (c) 2023 Institue of Software Chinese Academy of Sciences
> (ISCAS).
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
> USA
> + */
> +
> +#include "libavutil/riscv/asm.S"
> +
> +func ff_vc1_inv_trans_8x8_dc_rvv, zve64x
> + lh t2, (a2)
> + sh1add t2, t2, t2
> + addi t2, t2, 1
> + srai t2, t2, 1
> + sh1add t2, t2, t2
> + addi t2, t2, 16
> + srai t2, t2, 5
> + vsetivli zero, 8, e8, mf2, ta, ma
> + vlse64.v v0, (a0), a1
> + li t0, 8*8
> + vsetvli zero, t0, e16, m8, ta, ma
Instruction scheduling could be better, especially on in-order CPUs.
> + vzext.vf2 v8, v0
> + vadd.vx v8, v8, t2
> + vmax.vx v8, v8, zero
> + vsetvli zero, t0, e8, m4, ta, ma
You don't need to reset the AVL here, just pass zero.
> + vnclipu.wi v0, v8, 0
> + vsetivli zero, 8, e8, mf2, ta, ma
> + vsse64.v v0, (a0), a1
> + ret
> +endfunc
> +
> +func ff_vc1_inv_trans_4x8_dc_rvv, zve32x
> + lh t2, (a2)
> + slli t1, t2, 4
> + add t2, t2, t1
> + addi t2, t2, 4
> + srai t2, t2, 3
> + sh1add t2, t2, t2
> + slli t2, t2, 2
> + addi t2, t2, 64
> + srai t2, t2, 7
> + vsetivli zero, 8, e8, mf2, ta, ma
> + vlse32.v v0, (a0), a1
> + li t0, 4*8
> + vsetvli zero, t0, e16, m4, ta, ma
> + vzext.vf2 v4, v0
> + vadd.vx v4, v4, t2
> + vmax.vx v4, v4, zero
> + vsetvli zero, t0, e8, m2, ta, ma
> + vnclipu.wi v0, v4, 0
> + vsetivli zero, 8, e8, mf2, ta, ma
> + vsse32.v v0, (a0), a1
> + ret
> +endfunc
> +
> +func ff_vc1_inv_trans_8x4_dc_rvv, zve64x
> + lh t2, (a2)
> + sh1add t2, t2, t2
> + addi t2, t2, 1
> + srai t2, t2, 1
> + slli t1, t2, 4
> + add t2, t2, t1
> + addi t2, t2, 64
> + srai t2, t2, 7
> + vsetivli zero, 8, e8, mf2, ta, ma
> + vlse64.v v0, (a0), a1
> + li t0, 8*4
> + vsetvli zero, t0, e16, m4, ta, ma
> + vzext.vf2 v4, v0
> + vadd.vx v4, v4, t2
> + vmax.vx v4, v4, zero
> + vsetvli zero, t0, e8, m2, ta, ma
> + vnclipu.wi v0, v4, 0
> + vsetivli zero, 8, e8, mf2, ta, ma
> + vsse64.v v0, (a0), a1
> + ret
> +endfunc
> +
> +func ff_vc1_inv_trans_4x4_dc_rvv, zve32x
> + lh t2, (a2)
> + slli t1, t2, 4
> + add t2, t2, t1
> + addi t2, t2, 4
> + srai t2, t2, 3
> + slli t1, t2, 4
> + add t2, t2, t1
> + addi t2, t2, 64
> + srai t2, t2, 7
> + vsetivli zero, 4, e8, mf2, ta, ma
> + vlse32.v v0, (a0), a1
> + li t0, 4*4
> + vsetvli zero, t0, e16, m2, ta, ma
vsetivli
> + vzext.vf2 v2, v0
> + vadd.vx v2, v2, t2
> + vmax.vx v2, v2, zero
> + vsetvli zero, t0, e8, m1, ta, ma
> + vnclipu.wi v0, v2, 0
> + vsetivli zero, 4, e8, mf2, ta, ma
> + vsse32.v v0, (a0), a1
> + ret
> +endfunc
> diff --git a/libavcodec/vc1dsp.c b/libavcodec/vc1dsp.c
> index 62c8eb21fa..2caa3c6863 100644
> --- a/libavcodec/vc1dsp.c
> +++ b/libavcodec/vc1dsp.c
> @@ -1039,6 +1039,8 @@ av_cold void ff_vc1dsp_init(VC1DSPContext *dsp)
> ff_vc1dsp_init_arm(dsp);
> #elif ARCH_PPC
> ff_vc1dsp_init_ppc(dsp);
> +#elif ARCH_RISCV
> + ff_vc1dsp_init_riscv(dsp);
> #elif ARCH_X86
> ff_vc1dsp_init_x86(dsp);
> #elif ARCH_MIPS
> diff --git a/libavcodec/vc1dsp.h b/libavcodec/vc1dsp.h
> index 7ed1776ca7..e3b90d2b62 100644
> --- a/libavcodec/vc1dsp.h
> +++ b/libavcodec/vc1dsp.h
> @@ -89,6 +89,7 @@ void ff_vc1dsp_init(VC1DSPContext* c);
> void ff_vc1dsp_init_aarch64(VC1DSPContext* dsp);
> void ff_vc1dsp_init_arm(VC1DSPContext* dsp);
> void ff_vc1dsp_init_ppc(VC1DSPContext *c);
> +void ff_vc1dsp_init_riscv(VC1DSPContext *c);
> void ff_vc1dsp_init_x86(VC1DSPContext* dsp);
> void ff_vc1dsp_init_mips(VC1DSPContext* dsp);
> void ff_vc1dsp_init_loongarch(VC1DSPContext* dsp);
--
Rémi Denis-Courmont
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-05 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 14:40 flow gg
2023-12-03 17:17 ` Rémi Denis-Courmont
2023-12-04 8:48 ` flow gg
2023-12-04 15:15 ` Rémi Denis-Courmont
2023-12-04 21:14 ` flow gg
2023-12-05 5:25 ` flow gg
2023-12-05 16:41 ` Rémi Denis-Courmont [this message]
2023-12-05 19:25 ` flow gg
2023-12-05 20:10 ` Rémi Denis-Courmont
2023-12-05 23:50 ` flow gg
2023-12-06 2:23 ` flow gg
2023-12-08 7:31 ` flow gg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2772910.fE53gIofYm@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git