From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 02B3E4490D
	for <ffmpegdev@gitmailbox.com>; Tue, 27 Sep 2022 12:40:35 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 905D968B9BF;
	Tue, 27 Sep 2022 15:40:33 +0300 (EEST)
Received: from out0.migadu.com (out0.migadu.com [94.23.1.103])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D8EA68096A
 for <ffmpeg-devel@ffmpeg.org>; Tue, 27 Sep 2022 15:40:27 +0300 (EEST)
Message-ID: <275e4cfb-7d05-542a-3275-e7e75bd14a7a@zanevaniperen.com>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com;
 s=key1; t=1664282424;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=dDK5SviRWvcVpkPBmh2up4/rTkl+SvOW4mZ1qIcDZtc=;
 b=cHN/L5f53RdZ16zJBY6W7pELsU+BNkUDCo29bOY+2y9nm8rEOtC+qCoBKnohwvIt1s+auo
 Dttvr4lktknuizpgMgbjcAMVZ8LL39X3mZnXfNMZ4g0P1tR+iB3UC4KRh6WhXjWaNbAYMS
 AOf/tzQkgzJsbSKu9txSdyfbEtLMXUJE1uf90+9H/ZVQT2vAkS6rWG2qe4ueuaZY1jlcKN
 +k/sGlJDzqBUCt+13OZQ5Fzg9Ro0qhYSsHOKkjJjgZzogkTAYGYnUTac1S8XtRsXShU6iU
 EYDpY4GTnxgR4RrgOg+Hk6yZKzG+WyDzstdkR05HxCM7rEsCkSydDG7v1qiNoQ==
Date: Tue, 27 Sep 2022 22:40:22 +1000
MIME-Version: 1.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20220823051050.3515-1-pal@sandflow.com>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and
 include these headers.
From: Zane van Iperen <zane@zanevaniperen.com>
In-Reply-To: <20220823051050.3515-1-pal@sandflow.com>
X-Migadu-Flow: FLOW_OUT
Subject: Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start
 timecode if available
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/275e4cfb-7d05-542a-3275-e7e75bd14a7a@zanevaniperen.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Looks mostly ok from a cursory glance, just one minor nit.

On 23/8/22 15:10, pal@sandflow.com wrote:
>
> +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value)
> +{
> +    xmlChar *element_text = NULL;
> +    int ret = 0;
> +
> +    element_text = xmlNodeListGetString(element->doc, element->xmlChildrenNode, 1);
> +

No need for "element_text = NULL".

>   
> +static int digit_to_int(char digit)
> +{
> +    if (digit >= '0' && digit <= '9')
> +        return digit - '0';
> +    return -1;
> +}
> +

I feel like there should be a av_* helper for this, but apparently there isn't.
Maybe it's worth adding one in a future patch? av_isdigit() is in avstring.h, so
perhaps there?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".