From: Zane van Iperen <zane@zanevaniperen.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available
Date: Tue, 27 Sep 2022 22:40:22 +1000
Message-ID: <275e4cfb-7d05-542a-3275-e7e75bd14a7a@zanevaniperen.com> (raw)
In-Reply-To: <20220823051050.3515-1-pal@sandflow.com>
Looks mostly ok from a cursory glance, just one minor nit.
On 23/8/22 15:10, pal@sandflow.com wrote:
>
> +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value)
> +{
> + xmlChar *element_text = NULL;
> + int ret = 0;
> +
> + element_text = xmlNodeListGetString(element->doc, element->xmlChildrenNode, 1);
> +
No need for "element_text = NULL".
>
> +static int digit_to_int(char digit)
> +{
> + if (digit >= '0' && digit <= '9')
> + return digit - '0';
> + return -1;
> +}
> +
I feel like there should be a av_* helper for this, but apparently there isn't.
Maybe it's worth adding one in a future patch? av_isdigit() is in avstring.h, so
perhaps there?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-27 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 5:10 pal
2022-08-23 5:10 ` [FFmpeg-devel] [PATCH v1 2/2] avformat/tests/imf: add CPL timecode test pal
2022-09-05 18:06 ` [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available Pierre-Anthony Lemieux
2022-09-27 12:40 ` Zane van Iperen [this message]
2022-10-02 16:43 ` Pierre-Anthony Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=275e4cfb-7d05-542a-3275-e7e75bd14a7a@zanevaniperen.com \
--to=zane@zanevaniperen.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git