From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5387240412 for ; Sun, 13 Jul 2025 17:11:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 51B9468E101; Sun, 13 Jul 2025 20:11:55 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D0D6368DD77 for ; Sun, 13 Jul 2025 20:11:47 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 9CD52EBD17 for ; Sun, 13 Jul 2025 19:09:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ppPvJcKxHu47 for ; Sun, 13 Jul 2025 19:09:14 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 0E9A5EBD0F for ; Sun, 13 Jul 2025 19:09:14 +0200 (CEST) Date: Sun, 13 Jul 2025 19:09:13 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20250711211733.GT29660@pb2> Message-ID: <26fb4b10-b69e-31a5-e2ae-c787395f7e48@passwd.hu> References: <20250707103102.3477457-1-michael@niedermayer.cc> <20250707103102.3477457-2-michael@niedermayer.cc> <20250707145833.GG29660@pb2> <20250707200731.GH29660@pb2> <20250710233654.GS29660@pb2> <20250711211733.GT29660@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 11 Jul 2025, Michael Niedermayer wrote: > On Fri, Jul 11, 2025 at 10:29:30AM +0200, Nicolas George wrote: >> Michael Niedermayer (HE12025-07-11): >>> ok, chanegd it to AVERROR_INVALIDDATA >> >> Thanks. >> >>> Yes >>> but this also affects releases, and adding a field to AVFormatContext >>> is an issue for releases as it changes ABI >>> >>> So the concat patch would go into old release branches and the >>> AVFormatContext one into master >>> Unless someone has a better idea ... >> >> What happened to being able to add fields at the end? > > a release branch might have a libavformat with version > 1.2.3 > > the next release branch might have a libavformat with version > 1.5.2 > > The problem is if we add a field to 1.2.3 (which would become 1.3.0) > ABI/API requires that field to be in 1.5.2, but it is not > > Also besides this problem, 1.3.0 on git masters history likely > added something thats not on the release branches 1.3.0 > > So, adding at the end is perfectly fine on the linear history > on git master but our release branches, branch off that. > > so we would have to hack around things if we really needed to > add a field, we could try to use 1.2.4 or even 1.2.3 with a new field > but this is wrong. I always assumed that the whole point of bumping minor versions both before and after the release is to be able to bump micro in release branches if new option or a new public field is added in the release branch. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".