* [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag
@ 2024-02-27 3:48 tong1.wu-at-intel.com
2024-02-27 3:48 ` [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: " tong1.wu-at-intel.com
2024-03-05 7:30 ` [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: " Xiang, Haihao
0 siblings, 2 replies; 5+ messages in thread
From: tong1.wu-at-intel.com @ 2024-02-27 3:48 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Tong Wu
From: Tong Wu <tong1.wu@intel.com>
This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill
the reference_pic_flag with is_reference variable instead of 0 for B
frames.
Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
libavcodec/vaapi_encode_h264.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c
index 37df9103ae..4a738215c1 100644
--- a/libavcodec/vaapi_encode_h264.c
+++ b/libavcodec/vaapi_encode_h264.c
@@ -759,7 +759,7 @@ static int vaapi_encode_h264_init_picture_params(AVCodecContext *avctx,
vpic->frame_num = hpic->frame_num;
vpic->pic_fields.bits.idr_pic_flag = (pic->type == PICTURE_TYPE_IDR);
- vpic->pic_fields.bits.reference_pic_flag = (pic->type != PICTURE_TYPE_B);
+ vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
return 0;
}
--
2.41.0.windows.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag
2024-02-27 3:48 [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag tong1.wu-at-intel.com
@ 2024-02-27 3:48 ` tong1.wu-at-intel.com
2024-03-05 7:29 ` Xiang, Haihao
2024-03-05 7:30 ` [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: " Xiang, Haihao
1 sibling, 1 reply; 5+ messages in thread
From: tong1.wu-at-intel.com @ 2024-02-27 3:48 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Tong Wu
From: Tong Wu <tong1.wu@intel.com>
This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill
reference_pic_flag with pic->is_reference.
Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
libavcodec/vaapi_encode_h265.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c
index c4aabbf5ed..b5d3468152 100644
--- a/libavcodec/vaapi_encode_h265.c
+++ b/libavcodec/vaapi_encode_h265.c
@@ -949,22 +949,22 @@ static int vaapi_encode_h265_init_picture_params(AVCodecContext *avctx,
case PICTURE_TYPE_IDR:
vpic->pic_fields.bits.idr_pic_flag = 1;
vpic->pic_fields.bits.coding_type = 1;
- vpic->pic_fields.bits.reference_pic_flag = 1;
+ vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
break;
case PICTURE_TYPE_I:
vpic->pic_fields.bits.idr_pic_flag = 0;
vpic->pic_fields.bits.coding_type = 1;
- vpic->pic_fields.bits.reference_pic_flag = 1;
+ vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
break;
case PICTURE_TYPE_P:
vpic->pic_fields.bits.idr_pic_flag = 0;
vpic->pic_fields.bits.coding_type = 2;
- vpic->pic_fields.bits.reference_pic_flag = 1;
+ vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
break;
case PICTURE_TYPE_B:
vpic->pic_fields.bits.idr_pic_flag = 0;
vpic->pic_fields.bits.coding_type = 3;
- vpic->pic_fields.bits.reference_pic_flag = 0;
+ vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
break;
default:
av_assert0(0 && "invalid picture type");
--
2.41.0.windows.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag
2024-02-27 3:48 ` [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: " tong1.wu-at-intel.com
@ 2024-03-05 7:29 ` Xiang, Haihao
2024-03-05 8:06 ` Wu, Tong1
0 siblings, 1 reply; 5+ messages in thread
From: Xiang, Haihao @ 2024-03-05 7:29 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Wu, Tong1
On Di, 2024-02-27 at 11:48 +0800, tong1.wu-at-intel.com@ffmpeg.org wrote:
> From: Tong Wu <tong1.wu@intel.com>
>
> This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill
> reference_pic_flag with pic->is_reference.
>
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
> libavcodec/vaapi_encode_h265.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c
> index c4aabbf5ed..b5d3468152 100644
> --- a/libavcodec/vaapi_encode_h265.c
> +++ b/libavcodec/vaapi_encode_h265.c
> @@ -949,22 +949,22 @@ static int
> vaapi_encode_h265_init_picture_params(AVCodecContext *avctx,
> case PICTURE_TYPE_IDR:
> vpic->pic_fields.bits.idr_pic_flag = 1;
> vpic->pic_fields.bits.coding_type = 1;
> - vpic->pic_fields.bits.reference_pic_flag = 1;
> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
> break;
> case PICTURE_TYPE_I:
> vpic->pic_fields.bits.idr_pic_flag = 0;
> vpic->pic_fields.bits.coding_type = 1;
> - vpic->pic_fields.bits.reference_pic_flag = 1;
> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
> break;
> case PICTURE_TYPE_P:
> vpic->pic_fields.bits.idr_pic_flag = 0;
> vpic->pic_fields.bits.coding_type = 2;
> - vpic->pic_fields.bits.reference_pic_flag = 1;
> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
> break;
> case PICTURE_TYPE_B:
> vpic->pic_fields.bits.idr_pic_flag = 0;
> vpic->pic_fields.bits.coding_type = 3;
> - vpic->pic_fields.bits.reference_pic_flag = 0;
> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
Better to move the assignment out of the switch statement.
Thanks
Haihao
> break;
> default:
> av_assert0(0 && "invalid picture type");
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag
2024-02-27 3:48 [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag tong1.wu-at-intel.com
2024-02-27 3:48 ` [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: " tong1.wu-at-intel.com
@ 2024-03-05 7:30 ` Xiang, Haihao
1 sibling, 0 replies; 5+ messages in thread
From: Xiang, Haihao @ 2024-03-05 7:30 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Wu, Tong1
On Di, 2024-02-27 at 11:48 +0800, tong1.wu-at-intel.com@ffmpeg.org wrote:
> From: Tong Wu <tong1.wu@intel.com>
>
> This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill
> the reference_pic_flag with is_reference variable instead of 0 for B
> frames.
>
> Signed-off-by: Tong Wu <tong1.wu@intel.com>
> ---
> libavcodec/vaapi_encode_h264.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c
> index 37df9103ae..4a738215c1 100644
> --- a/libavcodec/vaapi_encode_h264.c
> +++ b/libavcodec/vaapi_encode_h264.c
> @@ -759,7 +759,7 @@ static int
> vaapi_encode_h264_init_picture_params(AVCodecContext *avctx,
> vpic->frame_num = hpic->frame_num;
>
> vpic->pic_fields.bits.idr_pic_flag = (pic->type ==
> PICTURE_TYPE_IDR);
> - vpic->pic_fields.bits.reference_pic_flag = (pic->type != PICTURE_TYPE_B);
> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
>
> return 0;
> }
LGTM,
Thanks
Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag
2024-03-05 7:29 ` Xiang, Haihao
@ 2024-03-05 8:06 ` Wu, Tong1
0 siblings, 0 replies; 5+ messages in thread
From: Wu, Tong1 @ 2024-03-05 8:06 UTC (permalink / raw)
To: Xiang, Haihao, ffmpeg-devel
>Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use
>is_reference to fill reference_pic_flag
>
>On Di, 2024-02-27 at 11:48 +0800, tong1.wu-at-intel.com@ffmpeg.org wrote:
>> From: Tong Wu <tong1.wu@intel.com>
>>
>> This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill
>> reference_pic_flag with pic->is_reference.
>>
>> Signed-off-by: Tong Wu <tong1.wu@intel.com>
>> ---
>> libavcodec/vaapi_encode_h265.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavcodec/vaapi_encode_h265.c
>b/libavcodec/vaapi_encode_h265.c
>> index c4aabbf5ed..b5d3468152 100644
>> --- a/libavcodec/vaapi_encode_h265.c
>> +++ b/libavcodec/vaapi_encode_h265.c
>> @@ -949,22 +949,22 @@ static int
>> vaapi_encode_h265_init_picture_params(AVCodecContext *avctx,
>> case PICTURE_TYPE_IDR:
>> vpic->pic_fields.bits.idr_pic_flag = 1;
>> vpic->pic_fields.bits.coding_type = 1;
>> - vpic->pic_fields.bits.reference_pic_flag = 1;
>> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
>> break;
>> case PICTURE_TYPE_I:
>> vpic->pic_fields.bits.idr_pic_flag = 0;
>> vpic->pic_fields.bits.coding_type = 1;
>> - vpic->pic_fields.bits.reference_pic_flag = 1;
>> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
>> break;
>> case PICTURE_TYPE_P:
>> vpic->pic_fields.bits.idr_pic_flag = 0;
>> vpic->pic_fields.bits.coding_type = 2;
>> - vpic->pic_fields.bits.reference_pic_flag = 1;
>> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
>> break;
>> case PICTURE_TYPE_B:
>> vpic->pic_fields.bits.idr_pic_flag = 0;
>> vpic->pic_fields.bits.coding_type = 3;
>> - vpic->pic_fields.bits.reference_pic_flag = 0;
>> + vpic->pic_fields.bits.reference_pic_flag = pic->is_reference;
>
>Better to move the assignment out of the switch statement.
Sorry I misunderstood. Please see patch V3.
>
>Thanks
>Haihao
>
>> break;
>> default:
>> av_assert0(0 && "invalid picture type");
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-05 8:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 3:48 [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag tong1.wu-at-intel.com
2024-02-27 3:48 ` [FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: " tong1.wu-at-intel.com
2024-03-05 7:29 ` Xiang, Haihao
2024-03-05 8:06 ` Wu, Tong1
2024-03-05 7:30 ` [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: " Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git