Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product - Rémi Denis-Courmont

From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product
Date: Wed, 29 May 2024 18:51:59 +0300
Message-ID: <2666279.WWoxFUQ57l@basile.remlab.net> (raw)
In-Reply-To: <AS8P250MB07447A88AD48647941569F288FF22@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit 
:
> > +static double ff_scalarproduct_double_c(const double *v1,

> Don't use an ff_ prefix for a static function.

I can see over 300 such identifiers in the code base (many but not all inline), 
and I don't see why that would be a problem.

> > +
> > +    /**
> > +     * Calculate the scalar product of two vectors of doubles.
> > +     *
> > +     * @param v1  first vector
> > +     * @param v2  second vector
> 
> Are these supposed to obey additional alignment beyond that imposed by
> double?

The C and RISC-V implementations require the natural alignment of double, 64-
bit. If somebody wants to increase the required alignment(s), they are free to 
audit the call sites and update the comments accordingly, since this won't be 
an ABI break.

> (Does your RISC-V implementation require it?)

-- 
Rémi Denis-Courmont
http://www.remlab.net/

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".