From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5F9DB4306D for ; Tue, 19 Jul 2022 07:19:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9663068B54C; Tue, 19 Jul 2022 10:19:06 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AAA7E68B58D for ; Tue, 19 Jul 2022 10:18:59 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658215144; x=1689751144; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XoftS4dByiBWgv95FX56y7CrumAHP99DrLGET6HzMQA=; b=lNthtldqYnd1Pwui/Q0yGPu+dt3nbW6crb/Tu9WYk/Sg+S+ZHGcgDqoL T7QjaKBBZauvA3IX71iuqWfJ7OYuYLv/z+6kmCYKYTkAT/1wO8OfTp/9m AaD+ligWsOYEw1jpaZ/M+XD8vd83tV/ZnpKd3ZskQxHfuJMlfPf3P30Vu 4b/zgADD2IzkU/aUw7OS6yNdfRXMVAhtQn/LdbUrneucfB+2thBk+0ANR Xko8Bhi6KsEUA5q+jr/7tIvhahr1KomXv4SEPeLs1hyy8uI5WCegTt72p NzavHIkbIvjmSwHrMvHglNNXLvytLsF27O3g4mOs2qljZZJ2ECSWsFEjF w==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="287161330" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="287161330" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 00:18:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="687020575" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jul 2022 00:18:57 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 00:18:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Jul 2022 00:18:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 00:18:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ewAti+XecLBbHc/2bYjTOkdnzYIgaIw3TtM6zWgIyDzWT3EIINkVt7dBVPGj7/vx0PLPPzfQU50p5YABgqE1EZlnb46k1W+IHoWPS5NJJWDpbLgdJGxAN4d1wgzfwFPyJMWM9swfN8oCR4S4jKBqpPuwsGhGdFeC7ZCkleSbbodWIbhh23UBvYgF+y1f2TqM8b2jx8Ho6EEGW/WEmFeV2k8tZk1N8EDe1bZ0gaUe+8ZG72l8rCf7DXvG2+vK6s8W6oFdeID/EDPcoJaJ2IL8Q7ZPV9uF8hHMoKbOCJPQNuf7Cb10/mr/SqkQRNLHZut1NEu82BV94FK+oSpW/Q5buA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XoftS4dByiBWgv95FX56y7CrumAHP99DrLGET6HzMQA=; b=Or/J+cCgolerDaGo12kF8iFuiO2SlBuGdtb32HgaD6ZSAyFYHSXpcssbpFa2hhx+sWKcH+Wt5PflVBFfo+7hEApT66JcuJy51nXyD37+mJfNvlkIuV6dWUMpPZK5NkOPcS49VD8FIC8E5OjyEkj5B1T0oXVNsLS37uq1sozYkI9MZgINFiV2aWgXii6pJ3yt06y6UOhW0DpJoG/MHTrOT/FTJK9PYqe0HBvd0NS74eXnmps/XqDQAWj0cirrnFvgUE52e1ECs4Hy/oQy1bUjdyiMNA47iHECAhJ09kFzigkvU+mrSX6BPsRm3XOVGKgUtptUxQA/mZjEGTDnlgqHgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5548.namprd11.prod.outlook.com (2603:10b6:408:105::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 07:18:54 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce%5]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:18:54 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL Thread-Index: AQHYlbiWkh+MsRsxrU+Jvg1jZyJRRq2EIewAgAEyPIA= Date: Tue, 19 Jul 2022 07:18:54 +0000 Message-ID: <265318ba163c41537a8a0ad57e7b57671e4211f0.camel@intel.com> References: <20220712062735.20339-1-haihao.xiang@intel.com> <20220712062735.20339-11-haihao.xiang@intel.com> <165814937028.25016.15272296385260114959@lain.khirnov.net> In-Reply-To: <165814937028.25016.15272296385260114959@lain.khirnov.net> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1b8cd72f-350f-4d0b-0698-08da6956f036 x-ms-traffictypediagnostic: BN9PR11MB5548:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mm5wXhHlrM2+8N0/NttxaDyGt/K9dKuREgI4GHJOD4PU7+9GcPB0sVQBFX0wTVecW72wr8vkYVYoLGNxcpnLbzszSa1Lwce4Asd9l/FN+CjBJHY1ZG4LI73UHXDB+KlGpBRPHkQ0pxPxwnIux1s4J8TLXLmKHJYpoDT9JOXUiMUZZRGBWvTzWIy3X4yWGFBnpJ1/OpDMzI2nlCyFcoMX3YpcHihvUdSuTMLmJCm+slx0ohYMxorbZ+R/VMH7JymaJDsPpsu+Bky6w+3MEEskSeEHmNCD3bpht9uFUjrzwBUbxnQjp67lYpxmvnNOY1YjvnpKxeVahpekbcHdT1oNrZ01xEFc81Udzsz4Jgi9KrfJlUZUGHmlEedt3F9ewTlrnH2liZ4YZfc4ZFCunQzDjsszu3tkdBdXka/w9nfY8NWvaDOcwiNzkm8cY0eOPC+qgFg1GFoEWVQn3S8tyxhw5pFKfsHxso13N+l6Fbgifsamcv0N/QCL+RaRVxQITca4OTXiPi0dDJD0HH0xT3RSFtBdSQfVUlUpQb4IgurMTSx4t0xIhvKzDcaLa2fC5/0I9tZEneFUUvOl940yYJyytJWHW+88XjLquAVUA9F0VGGBCK9my3Hpi/MH8Te2R8tbfeTEwC9yyEtIv5PDGBvNLBEVWo2jT/QUSmwsHaZ/JHLmSofmCwGvhWljSRL3tsIs/FKDnhXF8sqd38jfHIKJe7NviUHKiiF9hM+HxGCcrbbF8E/mJiJ/ig1bUMEO723DSOs1MlwKf1yPb6Wq6YJ2uO1G3gLzvJVkxgALLzyR/kCp7I3i9URBs5VUDLnfmv8vR/zcvCzZJ4XyV3gE6rTGoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(346002)(136003)(366004)(39860400002)(376002)(122000001)(107886003)(2616005)(83380400001)(6486002)(6512007)(38100700002)(478600001)(41300700001)(91956017)(186003)(6506007)(71200400001)(38070700005)(64756008)(66946007)(26005)(82960400001)(2906002)(86362001)(36756003)(76116006)(5660300002)(8936002)(8676002)(110136005)(316002)(66556008)(19627235002)(66446008)(66476007)(4326008)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dWVEb3pHTGlRaGxtd1phYVQxZXJ1QnVJTTcyQWo1Q2U1am9zUTFVOTFPSjNS?= =?utf-8?B?alJWQUtqQ3FkSE14OG12dlpFRk1jYzBvamE2bnhPZFNJcmUzM0VhYUcyYmxm?= =?utf-8?B?UGNNQnhFU1Q0RFZPTCtFRlNqVlNlRjhPU2RDbUJ4QUNPbFN5OEhBNW1CdVVh?= =?utf-8?B?eEs1N0dPWEJnbms0M0xYaWlWd1VFbnRuWmJUOVA4TW9aOUVvV3pDSGJZV2dj?= =?utf-8?B?NGs1VmhFNDhySGJBd0Z4TUxGQ1ZoaW5wcnJuTXNjNHYwS012Nnk1aTFiZnAv?= =?utf-8?B?N25SNE0ySjBhTDk2U252UUJzYTMzT0l0OG1aS01taEI2NFk0TndKSGFTSHZ2?= =?utf-8?B?WnUxaTRlT1VsK0s2bkNXSVRIZXVXdlJldDMzaE9WN29xTG5KUFQ2bDRJM0NU?= =?utf-8?B?VjRSQnJ6WkhGNEpqL24yM3hrcU9rb01uSVQ5a3JxTlFWZ2ZiRkMxOHhWZm5T?= =?utf-8?B?QVFGdHZWZ0NUUXlacUlSSVdXMTlYQlVtQTFTOTFuSS92R3JBWHNoNHlHM3RS?= =?utf-8?B?L0R2N3hoTTVNVDdzVUdtTnZKZHAxYXNFSnVmQURrLzVHV2FjdGhqcXBscTNy?= =?utf-8?B?U2RvbFZidG4xN3FDOXFaMHFxaEhBQy9LaHBTcytnYjVteGZoR21qTWNqRjFV?= =?utf-8?B?bWRFektUTEZLdWR4SzFRbjJZZE91ZGNoMWlHMEpTdTgrbmVWUVM1dWxWUlVO?= =?utf-8?B?eFlmQ2U3VU42bWNQYlRQRkM3cU9WbDVaUnhuWk0yOHZnYzRwK2JoZVlrOUxi?= =?utf-8?B?b1VNeWhNQmp5K0Jnbjg2TWl5c09MOGdhK215RU5ySVFuaUZNQjhDdkNKV3pj?= =?utf-8?B?bG9RRStjKzkvVUp3S0k1bmJvdGJjOXQ1OUtuN1FQUERnWm1xVG4rQ25GTzBK?= =?utf-8?B?UUJTRkMrdjlhU3YzVGZSMTJ3WXhSWFRrK01UR0Nqb3VlV2RFSVgxZVZUVE9C?= =?utf-8?B?N1hBS2hWd1lxSm9NVmNWbEIxTW0vbEl3TE91NFZiRjV1VDBDUGhUd0xSZWlV?= =?utf-8?B?N3MwazFQT29FaEk5bjIyRFZpMzgzdTRkZ0xITWUyUEhTd1FEaU5nS0ZHM3Ft?= =?utf-8?B?ZXdhM0F2Wk0raUNPdGkzUzNVOCtpcTdPZ2tzQkZtLzFFdGl5cHl1U0tqSVJM?= =?utf-8?B?ZCt4Z3QvVTRvOEswK1BDYUJ6MlVDOFlpOEhXWWsveDZFY1dPN1hGMDVvZWtu?= =?utf-8?B?a2t0YTRBd1MrTDNvU25pbkxsdldPR2QrcC9jSm40YVZDcnpGQjc2OG5nL09M?= =?utf-8?B?ak1icGRqREtOUURjalc4YWZoa214VC90Z2s4ZDB5NitxelVxUHkvVC9mWW1T?= =?utf-8?B?NTZmc2xXdW5PNDhQV2d3MnZFYjFyQWVHQjMvKy9TdnQ0RHdHakhxY09SczRF?= =?utf-8?B?WFRUSE1jZVJYQ0hWU1QxL1FnR3hvM28xS0lBVGhBcVVlODRNVXlyTVZuV2tn?= =?utf-8?B?c0hqZ0pCZGxZd3NIeUpVMUV2aXYrcUREUlREcHdlcFhJcTc2MkMxL29TT2hv?= =?utf-8?B?dkNUcGZhWlJrTzNNNDdzazRWb080MVg3NGlYd2RGUVpMMis0V1QvQzA2aDdz?= =?utf-8?B?VytsRWRJNnNwS2FLNDhGS2R1ZFZTZkJCT0ZWSy9nMG9kV0hJRmNBQ2p4TFpi?= =?utf-8?B?ckUxMlEzM0tHdjJVM3U3MGRjelBJNUF3Rnl1blRaOUlVUng0Z25hMTdNbkVU?= =?utf-8?B?cmRQcGJmQ1BwUVRvb2FPQTFQSnpZNXZzS0F0c2dWUUE0T2s0VUswZTRoV2pW?= =?utf-8?B?bUFPNlVjV0FoTG0rdjhEaHQ1MXNKMVZjV0hQanhueFk1VkdIdFR0dER4N1Rp?= =?utf-8?B?a3VxaTRJMndTSnBBcGFzSkJSWGM5T0IwaktMenVqeDcrb0NjRm1yYjMwTGJn?= =?utf-8?B?TmN2MnhFR3R1YkhVMmpKaGtJUWFZN1JzLzUyYW5heFNKQ1pDMll3b01tM25O?= =?utf-8?B?QUIzYldpSGhzTUFzOEZoM2FKSDVpY0gzaXJlaFEvdWMzWExlNE0xbXdBazlx?= =?utf-8?B?RHhHbnl5VitUZUxTVmVMdTFjWmpYbXNXYlNJNkVaQlhmRXVERGxyTFNicHEw?= =?utf-8?B?WDZmZ3RqMWtQZS9qUGVRTmdkSVdlRndPcmVNMXhNazB0aHJ1UGd2SG8xNElI?= =?utf-8?B?cXc3UXBDakFLeC91bmtqUlloVjdEVW1XdzRtRkd3ZG1XNTFMNFF6STZGZTQ2?= =?utf-8?B?RVE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b8cd72f-350f-4d0b-0698-08da6956f036 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 07:18:54.4366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n2uQjGxuICo1PyPeYqoJMbO4v82slGdKlnLpnQISgtXMqK3upy0c9d5dW7eXmGCjkaSg6F80TWZ8FyOmIMqNSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5548 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Galin, Artem" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-07-18 at 15:02 +0200, Anton Khirnov wrote: > Quoting Xiang, Haihao (2022-07-12 08:27:32) > > +static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) > > +{ > > +#if CONFIG_VAAPI > > +#if VA_CHECK_VERSION(1, 5, 0) > > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > > +#else > > +#define LOCAL_VADISPLAYPCIID 21 > > +#endif > > + mfxStatus sts; > > + VADisplay dpy = handle; > > + VAStatus vas; > > + VADisplayAttribute attr = { > > + .type = LOCAL_VADISPLAYPCIID > > + }; > > + mfxVariant impl_value; > > + > > + vas = vaGetDisplayAttributes(dpy, &attr, 1); > > + if (vas == VA_STATUS_SUCCESS && attr.flags != > > VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { > > + impl_value.Type = MFX_VARIANT_TYPE_U16; > > + impl_value.Data.U16 = (attr.value & 0xFFFF); > > + sts = MFXSetConfigFilterProperty(cfg, > > + (const mfxU8 > > *)"mfxExtendedDeviceId.DeviceID", impl_value); > > + if (sts != MFX_ERR_NONE) { > > + av_log(ctx, AV_LOG_ERROR, "Error adding a MFX configuration" > > + "DeviceID property: %d.\n", sts); > > + goto fail; > > + } > > + } else > > + av_log(ctx, AV_LOG_WARNING, "Cannot get device id from the driver, > > the default " > > + "MFX implementation will be loaded for this device. Please > > consider to " > > + "upgrade the driver to support VAAPI 1.5.0. \n"); > > I would still prefer to fail here. The user requested a specific device, > disregarding that request is evil. Thanks for the comment. There is only one available device for most users, so the default one and the given one from user should be the same, otherwise it won't work. I don't want to make them in trouble if they don't have a driver to support the new interface. However I agree with you it is a little evil to ignore the request. I'll update the patch to return error here. Regards Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".