From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DA6B749A5F for ; Mon, 26 Feb 2024 21:50:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC79D68C7E5; Mon, 26 Feb 2024 23:50:16 +0200 (EET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E352968AAC3 for ; Mon, 26 Feb 2024 23:50:09 +0200 (EET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d918008b99so27836025ad.3 for ; Mon, 26 Feb 2024 13:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708984206; x=1709589006; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M3ZhhiTdArDY8NLwYJD76AjQDkKc8oaqF0dWDQ+O6bA=; b=Panjd0a3dbMC48UXxrrlEKM999wr7k4jSK6mwNn9ZclBtCVVrFqRwLZ421P/bJfyW7 QPMseHKDtXcJ1O3YS5679UzPVNWXl3OMaDSILzlYGl0Id1/Iju5CfS//sH1AtgpWWS+t I6Cyn5H2RLtf4fIur5u8EG5khILvvjMlEE1/giy/q3pSAPOExCcU74Fdw6lcINObLmwe Tf+iMfNCXtOoQZOY7eyOA9pICNA3Ad4svf72xK81n8dXxGC7RocC/qgG2LcPutSaJd4O bhNwHds2d8D+ZchYP6k/CPuwZqUs2OYuSGMOPrqyR6U5XWHk9xHoDuSXQij6R3jhnK1S ElYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708984206; x=1709589006; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M3ZhhiTdArDY8NLwYJD76AjQDkKc8oaqF0dWDQ+O6bA=; b=pEl9TdLD7fTsaa/AYo39apDEBl6iEyWhuYz0ps2kuBg4fmWej6KPEzQURtIRS7j1V6 15YWs79b1YuFdEDh+xPu8B+32KW7oS8i/rShuy6/E/YdtOBbvnyCIXI/mdgTs5A5xbY4 esVr+6dw/e0i8aVqxyVLXivfqR65S9t9iX7t3jjfd1h7KV3fwueB+zsCUdE/zE+V62+/ rzaYOF0m/UB2jLm40DcLAV505HWyiOh774wnQzploSxrvnMahxknNSW+bKVOGYjst8MJ J1rQwq1ljXKjuIiDQnZlWRe65Ccgp1eYG3AurIHSDg88EUKKLoHdC1I8N8A4AVDE7PhG nC+Q== X-Gm-Message-State: AOJu0YwtbeI1fhuF3DGjOTXezamAsvPp+UBhhHHGFdns0THjs5dwIDf8 XFYF+s0tiLQYu87dKs1jIAikkG0roUNX0m1hInw45RT8QQadcKsPGFk40yoB X-Google-Smtp-Source: AGHT+IFt69L8fJpltrzRHq49nERBmhd/pTDPEqoAlIkcrVh5JJQ2IBKPuxIe4zZgHR0SfrQsKPI9aw== X-Received: by 2002:a17:903:453:b0:1db:3a22:1fd6 with SMTP id iw19-20020a170903045300b001db3a221fd6mr6182039plb.66.1708984205982; Mon, 26 Feb 2024 13:50:05 -0800 (PST) Received: from [192.168.0.11] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id v11-20020a170902d68b00b001dca9b21267sm147879ply.186.2024.02.26.13.50.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 13:50:05 -0800 (PST) Message-ID: <25fa6188-32a3-48d8-8ede-97ccba5f759e@gmail.com> Date: Mon, 26 Feb 2024 18:50:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Don't zero twice X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/26/2024 6:45 PM, Andreas Rheinhardt wrote: > Redundant since eee3b7e2fb0664b889e58c03f76e19ef23e4d1d8. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mov.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index effa46120f..d81e34d100 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -4287,10 +4287,6 @@ static void mov_fix_index(MOVContext *mov, AVStream *st) > av_free(ctts_data_old); > av_freep(&frame_duration_buffer); > > - // Null terminate the index ranges array > - current_index_range++; > - current_index_range->start = 0; > - current_index_range->end = 0; > msc->current_index = msc->index_ranges[0].start; > } If zeroing the buffer proved to not be beneficial, then maybe it's best to revert said commit (or replace av_calloc with av_malloc_array to keep the integer overflow checks). It will prevent writing to the same memory twice, and allow us to detect unintended access to uninitialized bytes. Either way lgtm. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".