From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 85FC546EE3 for ; Thu, 24 Aug 2023 20:06:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E54F668C5CE; Thu, 24 Aug 2023 23:06:24 +0300 (EEST) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF13D68C50B for ; Thu, 24 Aug 2023 23:06:18 +0300 (EEST) Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6bca857accbso204005a34.0 for ; Thu, 24 Aug 2023 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692907577; x=1693512377; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gIkFVs8X2UOy376mtqM4LVnmaq88h3vpr0uCb73kIU4=; b=Xrec4KP3ykGutpz1BNLOi3iwi1/qeU2ts8iZkbN/gelc/ZT6c/RAWVIexymfn0UhDt UZ82V2vKLJ67bv62LS+mjHxo+btJetiEU2aaogWUTA846L30CjS2z4CAaA+GyUwThDnG k9Lya2lijTwRS5erXZbAuZ/ds9L53BN2M7dEyfBw+hHpqxddS0rUF988F1rE/Bn0YX6b mTu9zHtDXoji0JyFckCIC2yN6I0rQWjntkA4s53l2XbIDOzERVt9jopfxRMfqPLUnw9g Uqn1GnREE3Z24QWuul6ZvpaVve17Aoxf4i49pqDCz79OjYOWocx7C5GhCq5DVyeaihLv jotw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692907577; x=1693512377; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gIkFVs8X2UOy376mtqM4LVnmaq88h3vpr0uCb73kIU4=; b=cNRjlWQ1wuUt2oTvF9sb5Q4GyMspczo+V+ftsiVtWbsdlZaqrCgslfJlkhN4Ul7Mvj gAZZ6q87M95RFd5oPezzw0vMx5Z3yuRU/xfigWekiQ4c4QX2KUSZUisUn2Nu1SiebADc uzXV9heaaj5VB7YTHjLKsGh/2KbVihLjluB+duK5GuUsz8g3IYsg4zqWTXh2aiVBd7nz 3ve+soqdEee6g7jdpqBdPlP0E/IrbH1Htl05G3X3W6WexxJ4XpuRDqP+rpiwl7iRrn05 UZFYpiOBy8Q2mybe0syNAIJIgSE9IzI3HoBwA6Vi2owUGF6DRRKPgjymezZZ9Cpjm9pV zkwA== X-Gm-Message-State: AOJu0Yx/G1D5Pmom+sd7yQB35XjTvbINIVMab5tQfQJY7fZoFvA2yECL 3RVXjqSiDEVuWAXDtlzZShf04uMVaDE= X-Google-Smtp-Source: AGHT+IFspvyEh5MZU9woV4hKtIlrzTmkUCGtfqZWSmWmW1MaccgfNrVdI3rv6hE64mRcBTtwKGcOzA== X-Received: by 2002:a9d:7694:0:b0:6bc:8cd2:dd97 with SMTP id j20-20020a9d7694000000b006bc8cd2dd97mr3064867otl.29.1692907576642; Thu, 24 Aug 2023 13:06:16 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id m8-20020a9d73c8000000b006b8a959ac32sm170694otk.48.2023.08.24.13.06.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 13:06:16 -0700 (PDT) Message-ID: <25cb7b68-493e-52dd-179a-58d817734906@gmail.com> Date: Thu, 24 Aug 2023 17:06:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230824195615.19017-1-michael@niedermayer.cc> <20230824195615.19017-3-michael@niedermayer.cc> From: James Almer In-Reply-To: <20230824195615.19017-3-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/2] doc/developer: Code pushed without patches on ffmpeg-devel must be announced on the ML X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/24/2023 4:56 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 383120daaa..1c0091fc74 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -856,6 +856,15 @@ way to get everyone's patches reviewed sooner. > Reviews must be constructive and when rejecting a patch the reviewer must explain > their reasons and ideally suggest an alternative approach. > > +If a change is pushed without being sent to ffmpeg-devel, the developer > +pushing it must annouce doing so on the ffmpeg-devel mailing list immedeatly. immediately. This chunk is ok, but... > +@example > +forgot a semicolon in this patch, pushed a seperate fix > +pushed my new autograd engine and stable diffusion filter. Didnt want to > +go through the bikeshed if that belongs in FFmpeg, go to the GA if you want > +it removed. Otherwise Just tell me what i should improve and ill look into it. > +@end example ...this one isn't. It's very passive aggressive and not informative at all. This instead should state that patches pushed without passing through the ML have to either be trivial, to push fixes to mistakes in recently pushed changes that did go through the ML, or for code you maintain. > + > @anchor{Regression tests} > @chapter Regression tests > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".