From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A038F4B641 for ; Wed, 10 Jul 2024 18:08:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE3D168DB75; Wed, 10 Jul 2024 21:08:37 +0300 (EEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3981268D691 for ; Wed, 10 Jul 2024 21:08:31 +0300 (EEST) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-367993463b8so4420987f8f.2 for ; Wed, 10 Jul 2024 11:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720634910; x=1721239710; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZxYaVDyG68LzV8jrdYbag4wNaqzJTvgphn2t1ymjUQU=; b=MtJp2MhnowNa6XnIpTYRzrPPXnbL82i+CVkA/LEmQlN7NdxIOTF+lWjou5y3HKG9N/ B5vDBQ8bxIG2s/VA8VEw02xOtuiu2X8oRbIWB60PCJnLUNn5sGLGKlRLRHO4i4LAMmcz OE1TYllq4nvvSWjDIXVgqkSc9vQrBrf5Gvg+K390Qv/O0zcvbZC8qee86eD/vN4VO6lN s0icHj6eaaG9UHVlUFYih6TDJTDHDfhRWxDoVf4DycnOl2maBERZGsWwzIxLWOGxnlTz KNC37XEAwoaAIeU22bVGToaHGI5rhyMXRyQstox4HCRzcoBYmIX8ATDzT7LSNCZDV+Gi uGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720634910; x=1721239710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZxYaVDyG68LzV8jrdYbag4wNaqzJTvgphn2t1ymjUQU=; b=oNka//EvvZFJtQ2l/ONWDjTqEwteJvRllAzvhCWsZXR7MFJw1SWqkluhf0EU31+aoV 7QoW/a3M61FmhsrkABV3XlWcHi/QOkZrTLeKGJavl/MPIeT6nF0B4u8z7VBmzPm3ry6w hxj4FKD4P5fiyEvukB5TA6oeJLX/Pgnq28fxa6IHZ6WIRvKaq2FUUh5mrqElxaURq0fH MUnopP5r3Sl4ISkcib4Nduda+uKzUx0fF+dEAymK9dmfxOhMpYmCr6UqYiAXtTxjFbQe m/cT0C8VKdvg5H4chwK7qo6aoziNdPuMGGWiV7pJ9jfAKkTfpC7wfe9avedDiw0Tur5E WyIw== X-Gm-Message-State: AOJu0YwGE86PPXBq06aC4Viuc9bjsxHaufx/gjXikwJa3VyK+K9NsBr9 farrsrbub/GpLFFwaeFg/FRZq5Op2lt+9poAV/dl0LORCyyRt0EqKM3Ylw== X-Google-Smtp-Source: AGHT+IGXsmv0pnklBmw8BL3msYgIizGXoAnG/gBiDCOx+K1Hr3kw00AFqERLuvdcTWW1ogddtvmSRg== X-Received: by 2002:adf:eb81:0:b0:367:9ce3:167a with SMTP id ffacd0b85a97d-367ceadb3e7mr4048463f8f.64.1720634910310; Wed, 10 Jul 2024 11:08:30 -0700 (PDT) Received: from [192.168.0.104] (p50907095.dip0.t-ipconnect.de. [80.144.112.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa067dsm5897327f8f.78.2024.07.10.11.08.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2024 11:08:29 -0700 (PDT) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Wed, 10 Jul 2024 20:08:28 +0200 X-Mailer: MailMate (1.14r6022) Message-ID: <2533FA87-C2CC-4128-A33B-A6CFF8F3DEB9@gmail.com> In-Reply-To: <1de99f92-a58d-4707-8113-2ab4fb83ad4f@gmail.com> References: <1de99f92-a58d-4707-8113-2ab4fb83ad4f@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10 Jul 2024, at 19:26, James Almer wrote: > On 7/9/2024 5:43 AM, epirat07@gmail.com wrote: >> >> >> On 8 Jul 2024, at 8:30, Zhao Zhili wrote: >> >>> From: Zhao Zhili >>> >>> --- >>> libavutil/hwcontext_videotoolbox.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c >>> index 953155ce32..dd89edfa08 100644 >>> --- a/libavutil/hwcontext_videotoolbox.c >>> +++ b/libavutil/hwcontext_videotoolbox.c >>> @@ -588,7 +588,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx, >>> } else >>> CVBufferRemoveAttachment(pixbuf, kCVImageBufferGammaLevelKey); >>> >>> - if (__builtin_available(macOS 10.8, iOS 10, *)) { >>> + if (__builtin_available(macOS 12.0, iOS 15.0, *)) { >>> CFDictionaryRef attachments = CVBufferCopyAttachments(pixbuf, kCVAttachmentMode_ShouldPropagate); >>> if (attachments) { >>> colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments); >>> -- >>> 2.42.0 >> >> LGTM. Sorry for breaking this. > > http://fate.ffmpeg.org/log.cgi?time=20240710170512&slot=aarch64-osx-clang-1200.0.32.29&log=compile > > Looks like it's not enough. See my patch from yesterday, should fix it. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".