From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 327F249228 for ; Tue, 6 Feb 2024 10:25:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 753F468D154; Tue, 6 Feb 2024 12:25:03 +0200 (EET) Received: from sender21-mail.zoho.eu (sender11-op-o12.zoho.eu [31.186.226.226]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 423BB68CC2B for ; Tue, 6 Feb 2024 12:24:56 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; t=1707215095; cv=none; d=zohomail.eu; s=zohoarc; b=i6iRHSZ2ueP5EANXOUodgAabExgSsdW3gFHnz01oPe/h1Z+NJHrO4J9NOEXRhZAFfg7AEqkNldadx7TLs8JS5lXVHOe5b1l18pl/obbzdHUQPLvXajTe3NmA7jaocqq6CjbXgzm54nwNrhxys1YOJWdnOitqdDJPW9XHthEdDjY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1707215095; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4mc3QYZGf2kKzkmO1kkzkSqR1xWkGfkqKRR0vbRnjBw=; b=fFjPdx99i6ve3qzUmMS2hUjjbOzpTv3b4YQSzxzzU4m8piCAuYmnhk5zVLKEg5GCeU9Yjdft92zfP+RGV4/cRo6poYzOzImIFX8YJ4A6yfOoU4gU88yXU/NXsOgyRourJXuLUK14raTteUZkxnFXpMSBPbJWLE11Ua2artO7tys= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=frankplowman.com; spf=pass smtp.mailfrom=post@frankplowman.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1707215095; s=zmail; d=frankplowman.com; i=post@frankplowman.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=4mc3QYZGf2kKzkmO1kkzkSqR1xWkGfkqKRR0vbRnjBw=; b=BulQDh9TvWUP0cSFEMNKCCZnrRoMed0w0XwWCJUcr3Wx+JpqjWliBYO+OFWkdm7B CSzL6m+VBM6j5zzXodd761gDjbtbNrCOvH+jt7JAa9cRDIaL+YoKBpz2YKc52SFAeAg 0cWyp/BvW2rAl9ri0KP6Ln2CTREVDwD1fVvaANWw= Received: from [10.0.0.6] (frankplowman.com [51.89.148.29]) by mx.zoho.eu with SMTPS id 170721509290939.15558819914281; Tue, 6 Feb 2024 11:24:52 +0100 (CET) Message-ID: <251006d7-8ac4-45f7-bea9-86548bf9212e@frankplowman.com> Date: Tue, 6 Feb 2024 10:24:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20240206101552.28897-1-post@frankplowman.com> From: Frank Plowman In-Reply-To: X-ZohoMailClient: External Subject: Re: [FFmpeg-devel] [PATCH] lavu/thread: Check HAVE_PTHREAD_SET_?NAME_NP is defined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 06/02/2024 11:23, Andreas Rheinhardt wrote: > post@frankplowman.com: >> From: Frank Plowman >> >> Check HAVE_PTHREAD_SETNAME_NP and HAVE_PTHREAD_SET_NAME_NP are defined >> before using them in macro conditions. Gets rid of lots of -Wundef >> warnings present when building on MacOS since >> fd16d8c68cd7b820eda76c407b0645b7cf470efd. >> >> Signed-off-by: Frank Plowman >> --- >> libavutil/thread.h | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/libavutil/thread.h b/libavutil/thread.h >> index 2c00c7cc35..0200b7b511 100644 >> --- a/libavutil/thread.h >> +++ b/libavutil/thread.h >> @@ -26,7 +26,9 @@ >> >> #if HAVE_PRCTL >> #include >> -#elif (HAVE_PTHREAD_SETNAME_NP || HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_NP_H >> +#elif ((defined(HAVE_PTHREAD_SETNAME_NP) && HAVE_PTHREAD_SETNAME_NP) \ >> + || (defined(HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_SET_NAME_NP)) \ >> + && HAVE_PTHREAD_NP_H >> #include >> #endif >> >> @@ -219,7 +221,7 @@ static inline int ff_thread_setname(const char *name) >> >> #if HAVE_PRCTL >> ret = AVERROR(prctl(PR_SET_NAME, name)); >> -#elif HAVE_PTHREAD_SETNAME_NP >> +#elif defined(HAVE_PTHREAD_SETNAME_NP) && HAVE_PTHREAD_SETNAME_NP >> #if defined(__APPLE__) >> ret = AVERROR(pthread_setname_np(name)); >> #elif defined(__NetBSD__) >> @@ -227,7 +229,7 @@ static inline int ff_thread_setname(const char *name) >> #else >> ret = AVERROR(pthread_setname_np(pthread_self(), name)); >> #endif >> -#elif HAVE_PTHREAD_SET_NAME_NP >> +#elif defined(HAVE_PTHREAD_SET_NAME_NP) && HAVE_PTHREAD_SET_NAME_NP >> pthread_set_name_np(pthread_self(), name); >> #else >> ret = AVERROR(ENOSYS); > > You need to rerun configure. Since > fd16d8c68cd7b820eda76c407b0645b7cf470efd running configure will add > HAVE_PTHREAD_SET_NAME_NP and HAVE_PTHREAD_SETNAME_NP to your config.h file. Ah, I see thanks. Sorry for the noise! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".