From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 84701442E6 for ; Mon, 5 Sep 2022 06:05:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2EA868B779; Mon, 5 Sep 2022 09:05:28 +0300 (EEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA5D868B56D for ; Mon, 5 Sep 2022 09:05:16 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662357927; x=1693893927; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=pTSwLehqQft9TCYPYWfMKj2Gg3nFxaAArorjI9LLhaE=; b=Kxmvm+AcPPKmHQ2iTJ2spui0QpjR5bnL5ik3hq4HYatf6Cgf0+u1qGED lqiLunBChUSngLjn+KNCgFtYo9fA16UHxzXyvSv5tP1UXfH5j+Y5BQ8G/ AfgFU6KmX/1cRxc5TxO9PH2jrTZ4zKX40Ta32QBA2XND6Q16Y7ajQYB/4 dQjQwwKjFFj3KcitxPK9FQFE9JHXTfmrJ1L/d9MKgRfr0O6xspGIFFcK6 SOKfn1h2LwWkaghGT7QVFFQBR38H34Q0OIxUsnh9F0uWQvLs8rQT/4j4F +DlUvt/5MnSheB2d+CKJzByXnHqKb15yKH5SBakx3DPHb0+dtvdv3e+V+ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10460"; a="382613596" X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="382613596" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2022 23:05:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="789274588" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 04 Sep 2022 23:05:14 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 4 Sep 2022 23:05:14 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 4 Sep 2022 23:05:13 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 4 Sep 2022 23:05:13 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 4 Sep 2022 23:05:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHWoRwr1loQRPZ8E5L/hf8kN/un4iwB5IIjN+CQua+98wzXJxGbVB96MuR248UoMBJwdBashYgx9xxJxFmewJXACMdGOAwISvpCvWXMiXxAyzMMCNGmjJpHFSv9XpSirL2pbyElETKDLuLwE9wOKJMZyCdDyfbHiN6/lZ+CubuiZY80SRmxSUl/4uuzlhyRvrW7RKwXA1+omdWAW0hCgkXZWEDxqe6tX07K+NamXaRyOWYJTPD0wD5AEYzxV2vZeNR5kAyMq55H7zz8QMWdnJd4dHJnCqaF/pC+TezJxyscgiewYi0ZR5Igi2AeEzqA7Q8sDPkcVq8R272XUldBCYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pTSwLehqQft9TCYPYWfMKj2Gg3nFxaAArorjI9LLhaE=; b=mqfYMiGD0bSles/VEhCevm/T1J3T70KJ/EsHzVs5r7Bcy1GklBRDiFiNGOKgAURyT0VgbfiOiQvJz0/xAShVxa3C3yiLFKVnmIbT+XG/coGKD5EspsATnnU4yHYFiMmt2M73lk0+s3ornxRv4vsVVvSlE84urStcI3Z40E/vOcxof7LWpmDQDXi3PsdnshueXt+sLR/U5aJ7Hwz4gWeJhfgte0GlffIJgYVv+Q4mjjirRixpOT81zLh8Z9qXeL0pFHQP9lkI6T0sJTSuXNr6es6ft6RzEeJ0tHX6KBp2QAkroUsEpJFYKJ/KhCtVSCJ0kWZJquJLMTVTvuaYduvzpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB4068.namprd11.prod.outlook.com (2603:10b6:405:7c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Mon, 5 Sep 2022 06:05:12 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5588.012; Mon, 5 Sep 2022 06:05:12 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "haihao.xiang-at-intel.com@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 1/2] lavu/hwcontext_qsv: add support for AV_PIX_FMT_VUYX Thread-Index: AQHYu5kOmk+o01FBFEqSCxkvkQhNOK3F6FkAgApEMoCAACZQAIAAENsA Date: Mon, 5 Sep 2022 06:05:12 +0000 Message-ID: <24cc30ca1a53dddcbd7eba1451a3fa12160faf08.camel@intel.com> References: <20220829072751.22395-1-haihao.xiang@intel.com> <20220904220450.706688ba@fido7> In-Reply-To: <20220904220450.706688ba@fido7> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a5261ed-efc3-4ebe-0187-08da8f04982b x-ms-traffictypediagnostic: BN6PR11MB4068:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 32dpA8X0XIUSuhsSiRl0gFQEjUh8DUOhV04/LZBrDsPs4gY67Y+zORmAMfFy7pLSzeE2glIDCKgQnF5+9kw3tERJjD7tUenNHXQB2ADleczK4T4uwZQzvDuFqn5ztp/t1bVIzjPYfDmclhyI0iGF2Hknp6IKs23URffH/jEc1vQS7wSqKc1pgfVQsJk5R89dR025jd22MQOIFoAKGJIHa1V2rjdolb9jz6vO94/ANSplvFaClqv0ZOLcPua8DXPTR9pkuP6/tUzsSJS616LgBB24EFi33kdQ/6LmJxE69g1bvSvSf9Mx//Nna1+3Ucj479geugI966gbVeFhRvgixayiqpyVk1ci1vNi3qTfQ5JeTHgAp4eqJpmhvUKyUxe0D8FLCGkME/1hKmlmDkoKuoqh18jPYw/M8Ro8HN5r7KW8m7b85vwQlR8hZlkyNfai5eeWXKGbEFY/kB8vEnYlR+FNiKkqdeIczYqxrUAuHEJzMOOcXpk8ovYIS2j8YzRMLdDbvqs1gvW1rFNnEcGbE1WTA5nq/kc4OPvNQdI2qC3qQKTEQ5B0VSaGYRi27PTWJYAM8wxUXMhGOzgMhUmJqR6v6XjgYxwYShkaslaQdz7I0P9cie4hOQXFD1F3IIRmxnULHQpUDxrA5zgWMq89FCD6JrrjvcOVoPWLMwMDcLLmdJo8AV9nm+55Kjm6V8OQcAIARXH+hDMERfBOgyRr20Mdqa2pzb/s7vkgGFGMk+fgVucPd5A+aQUAGmZkK9idaOL8KbBnfcMS0Yz6gO2NnoYLbPzhEve/O18J5ssTSqc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(346002)(366004)(39860400002)(376002)(136003)(41300700001)(53546011)(6506007)(91956017)(71200400001)(86362001)(8936002)(2906002)(26005)(6512007)(5660300002)(82960400001)(122000001)(38100700002)(38070700005)(2616005)(66946007)(76116006)(186003)(66556008)(66446008)(45080400002)(110136005)(64756008)(36756003)(6486002)(66476007)(316002)(8676002)(478600001)(450100002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OWVMU2h4WmFVMTBFSkFIZXRNSXNwOFJ6KzlCREJSa1ZmRysxT2N1MXhaOFNG?= =?utf-8?B?RDJYNGpXbU1oN3hmejhIQzhHQWVYQkF6SWwvWDQrT2FrYXA2a1F0bGRiMTF3?= =?utf-8?B?VlJPU0d4QTBxTk9kZWc2bWdFL2NmTm43Mm5kZnpBZjlpallCazl2Y1N2ZVlk?= =?utf-8?B?bEYzek8xUXBlYUJPRXVKRUtna2tWV3ZURmFCNEhTTUl1T2JDOXVGQllsamFO?= =?utf-8?B?WTRHTFhWSVZ3a2JmVE5BMjVkaGVFZzBtTWVQWnZDdUp2eWNwd3lnbmV6T21H?= =?utf-8?B?TnRVRkdkOHU0V2J3a2RMRm1oVWpTT05RT2ZJZXU5Q2plMFNrWHJLWUJGc1Rx?= =?utf-8?B?T3RjMFJuaGhKSkU2cHVSWUdzZnduK3EvcmhRMm11aDJvTjJhbENIQzNCK3B4?= =?utf-8?B?WlhYVEdIbzFTY2t1cnlGa3IwS04rdTZTamxWT2V2SlVacXAvWGxpb3owSFAy?= =?utf-8?B?dkUzbklZZ0NlWGx3aTcvWlhXbTlsa25JQ1dEdmtTMkk2M0dHc0lCZXVORmx1?= =?utf-8?B?ajBiOS9FMzRmRTZraU5WWWo2a3FEWCs1NThiT3JZVE1qQ2ovWWtSdDRQQllv?= =?utf-8?B?dXROWGkwWXhabURzVEJXQjFmU3YvVE1NM0E0ZUt4ZDZzbjNweG0ybjVFWVRH?= =?utf-8?B?dFcvbnd1ZDlyV2RRSEpUeWJ2YTk0OVNVRVpQVFlaNzZhWnA4ZXlvUmU2R2Vn?= =?utf-8?B?SWlvTjJrUFdyUGtEODRJUWtFeWtwUlhVUVJmclNCbTZVNzgyS3h2RkpHSkww?= =?utf-8?B?dWNVZVQ3SGRBQmhTR05GL3JyS0lsVDY0enJUU3lEVGp0WUJNdUJjUUhTSFpE?= =?utf-8?B?QnVUUVEzL2dzNkRzYnU5YUtDS1VEWEg1SksvVGpHVEM2NUZxUG45dDFvLy9j?= =?utf-8?B?ZEJlMzdzTTI1MGdZenl5VktsVzlVM2paeWZCUTVNcVlsdmc0dE56eEE0cTlE?= =?utf-8?B?NzcrdlFHMnpJRktOUWVLZEUzQUxldzJOby9Ramp1TU9rVUkrTGZMV0YwL2ZO?= =?utf-8?B?WldTcnA2QkphcnRnUXFLK3hIWkpaN2ZrTDZjcmVod3RUaGQzbm5Gc045RDhp?= =?utf-8?B?KzNJUzljOVJGY0NGWTFzQVNBbFJjSlBBY2oyQWFhSitjZlpQV1pFU2l5MHlB?= =?utf-8?B?MmNHUWxHakRKOEw2L0xRd0QwMjdsQnJ3bWd2aU1GTHNhbU5nb3M3ODUwU1Bn?= =?utf-8?B?RlBRam5vUndsK2RCMVBPZFpPbS8yODNmbTFUeU1pRVE4blRqTW9CQzZpbVQz?= =?utf-8?B?ZktnZG10MmFpMStyMDl5YlBRcCsxTHlFdUtBbk1nNWJDcERWeW0yME9WODVr?= =?utf-8?B?QTUzRi82WjVwRmIvQ1lMSkcxZnJ6c0loVDRZTzNrSjkxUTZ6ZnpsbFFVeEpW?= =?utf-8?B?V3FvT0piaWZCVXNuWXU3T29XUnVkN2xpdEh0Q2NucVQ1aFp5V3B1TE8wUjJk?= =?utf-8?B?SEMrOTFNdW1kMHcwY2UvQUN0UHJoYmpCK3V6eTUyc084dFpGci9VN3pOVWVZ?= =?utf-8?B?THNoalF0by9UN1U2SXYyN0xlZGJCMFdaUlRGQ1FmUUhYc1U4RWt5VEFoL3RH?= =?utf-8?B?Y3VuMkJhNHZ3ZWNZNHZ6Zm1kc1FCMklPelBoNEx1MXdKb1ZPeEFnazlRMDFY?= =?utf-8?B?bE0vWlF6SjdUVk1jT0ZWei9CZFBkZTJTSDdud0FMWTI2dmpkcUdhMWRNRFlE?= =?utf-8?B?SlFOM3ZHWEU3OFB4eG9pUHhpanJoUTdnRVB1aUJhWHk3VW5IVTE0d3VqMzZt?= =?utf-8?B?Mkw3SmJUMDlITEdXWVQvTWcrdEtSUHFnRFBQWlpXS1FXanJ0TW9qdHFsVnRJ?= =?utf-8?B?dTh6b2F4TmJ2MWVsNzZqQnIraHdxbWNHT096MXYwZFVNVjZRYklkZGNYVHU2?= =?utf-8?B?K3JnM002SmtoL1NueXpqRTZzdmhtUmlQb2UvTU5LblFaUldGdWRqYm01SUhI?= =?utf-8?B?VkgwTTJGVE5qTUZqY3VSY3JBaVNVbXpScUNERnMxNWhYT2FHR3BRODZrUXhG?= =?utf-8?B?ZktBWU9UenNBRVNOSFZFK3FGeUh3NWhNTzlLdncwWlZReCtiWGlLdFBnM01x?= =?utf-8?B?dXNmYXV0Z3BPYWdvRDUrdFdlVDQ5WUYxOTkyRW1NNmlScFNUVmI1VDhTYnlQ?= =?utf-8?B?U0hHZFJuQ0w4YXFGMmRhTmhKNk9XN09QVk9TUlJ6NkN6NWVLaW04ODBwZGxL?= =?utf-8?B?OHc9PQ==?= Content-ID: <1E4EB58297533F4090000C7A5C56E3C2@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a5261ed-efc3-4ebe-0187-08da8f04982b X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2022 06:05:12.1786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z1xVEeb9DVGpTe0FD4dmE0l8cHeGas1aQZtDSzeRKuxa7wytNh7fi7C/HEHedRyjTBsUY2WqKa80PTDJ5Fh01A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4068 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/hwcontext_qsv: add support for AV_PIX_FMT_VUYX X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2022-09-04 at 22:04 -0700, Philip Langdale wrote: > On Mon, 5 Sep 2022 02:47:44 +0000 > "Xiang, Haihao" wrote: > > > On Mon, 2022-08-29 at 14:01 +0000, Xiang, Haihao wrote: > > > On Mon, 2022-08-29 at 08:17 -0300, James Almer wrote: > > > > On 8/29/2022 4:27 AM, Xiang, Haihao wrote: > > > > > From: Haihao Xiang > > > > > > > > > > AV_PIX_FMT_VUYX is used in FFmpeg for 8bit 4:4:4 content on > > > > > Intel HW, and MFX_FOURCC_AYUV is used in the SDK > > > > > > > > Sounds like you want the VUYA pixfmt instead. > > > > > > AV_PIX_FMT_VUYX is used for 4:4:4 content in the VAAPI path, > > > AV_PIX_FMT_VUYX is > > > expected when creating vaapi urface. QSV is based on > > > VAAPI under Linux, so AV_PIX_FMT_VUYX is expected too in the QSV > > > path when creating vaapi surface. > > > > > > > > > > > > --- > > > > > libavutil/hwcontext_qsv.c | 8 ++++++++ > > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > diff --git a/libavutil/hwcontext_qsv.c > > > > > b/libavutil/hwcontext_qsv.c index 510f422562..a3350eae0f 100644 > > > > > --- a/libavutil/hwcontext_qsv.c > > > > > +++ b/libavutil/hwcontext_qsv.c > > > > > @@ -119,6 +119,8 @@ static const struct { > > > > > MFX_FOURCC_YUY2 }, > > > > > { AV_PIX_FMT_Y210, > > > > > MFX_FOURCC_Y210 }, > > > > > + { AV_PIX_FMT_VUYX, > > > > > + MFX_FOURCC_AYUV }, > > > > > #endif > > > > > }; > > > > > > > > > > @@ -1502,6 +1504,12 @@ static int map_frame_to_surface(const > > > > > AVFrame *frame, > > > > > mfxFrameSurface1 *surface) > > > > > surface->Data.U16 = (mfxU16 *)frame->data[0] + 1; > > > > > surface->Data.V16 = (mfxU16 *)frame->data[0] + 3; > > > > > break; > > > > > + case AV_PIX_FMT_VUYX: > > > > > + surface->Data.V = frame->data[0]; > > > > > + surface->Data.U = frame->data[0] + 1; > > > > > + surface->Data.Y = frame->data[0] + 2; > > > > > + surface->Data.A = frame->data[0] + 3; > > > > > > > > This will go wrong with VUYX. You need to use AV_PIX_FMT_VUYA. > > > > > > frame->data[0] + 3 is valid even if alpha channel is ignored in > > > VUYX. Intel HW doesn't use the data in alpha channel actually, but > > > the SDK uses Microsoft pixel > > > format AYUV which is the alpha version, here set a valid address to > > > alpha channel when mapping a VUYX AVFrame to a AYUV mfx surface. > > > > > > > Is there more comment about this patch ? > > Wouldn't it be more correct to fill the Data.A with 0xFF rather than > using the undefined value from the frame? I assume that the encoder > actually drops the value completely so it ultimately doesn't matter, > but it makes it clear that there is no alpha and if the encoder was to > start preserving it, it would preserve the desired value. Yes, you're right that the encoder drops the value. I'll add some comment in the patch. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".