From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 268C04B771 for ; Wed, 17 Jul 2024 23:24:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 785E868DA0B; Thu, 18 Jul 2024 02:24:24 +0300 (EEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5022768D8A6 for ; Thu, 18 Jul 2024 02:24:18 +0300 (EEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7163489149eso136213a12.1 for ; Wed, 17 Jul 2024 16:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721258656; x=1721863456; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=HZNtjfXhMtBo3Q0Dn9DFgdm0vvQ0sT7AO75mkEmqxuw=; b=WDL27FkUNfsO0G41OFOeyWoN08iWqdWMEyBW5J3HBjZiEDyEiO/6T58CBxMAf2HsSU D6XS/9syt7BHVbr/OV3Wi95yWM0Yg9Af80IUrP5b1G27e94H7SPWx/2W+pSgv9RcxTvu 2j89MY7HD2a4z99P8g7Tmu0y1n9I7KDqytymAfCM64UfT0QrgKvOzNWDhEIPPf0rhjcm VWTtveQblh5wRGH5VkwIGSHQmuUtM/KpuRxf6p6Tw8hLeIw2EqPDjlq31O1niqsWx7vV g1WvHp6J4KogXMcXCC1/GOlRQvQiRFo+qvkcEo3SOo8SHy4eZ8oHspUYpJpG0gziZcOG QiSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721258656; x=1721863456; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HZNtjfXhMtBo3Q0Dn9DFgdm0vvQ0sT7AO75mkEmqxuw=; b=ldGcxuLvnNXt3GXmPDwALdaNk5tx6hlFQbVSopQR6JXT2HAQRZJYwO0n5zaz3NSq42 MXEdTZe3XEofalKiPAKkQjWSpuDiW+v9+w3eJMFVKcnwxc+kla2Bz6vwYGobPcsVdvTf x5BerP77KXUz/Sd6GFipH/78hcB+NBzZtuRf+hH+slO0BTB43dgnKmXczeAMDR0eHVuT 9MYDI4VOvlz7k+YRzQtAG781ljlb5wz1XapTSKWDa6XfEoA7AcK5pyTYBIV9yAvQgpZx iU0sGfSCOvVjBVhfB5pPZ8vss36Xz4PlZIdTAXkSFPPZ+JDU6EohhlHCFwmShpMNsUvi SvOw== X-Gm-Message-State: AOJu0YwkfpyAUZFXc/cjh6jcIhxGH7zlEnva72CvU21oYzQh4VKBO86g KwVr3tsQiwI3p3L7UVTFo7koyPnkiYqId+b9DOfPUv9AYPEfdR2Iy/66dQ== X-Google-Smtp-Source: AGHT+IF8LqpGFmYLaQjihvmdqfdxUhgJV2pIYidy7aqhqalEsOqDTR/ZIexO7DJp8lYAWu4/lU4F7w== X-Received: by 2002:a05:6a21:6d95:b0:1c3:b144:2ee1 with SMTP id adf61e73a8af0-1c3fddaa532mr4728590637.44.1721258655455; Wed, 17 Jul 2024 16:24:15 -0700 (PDT) Received: from [192.168.0.12] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7eccc496sm8681023b3a.191.2024.07.17.16.24.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 16:24:15 -0700 (PDT) Message-ID: <24b4dabc-a7c7-4ffb-9d69-827244461754@gmail.com> Date: Wed, 17 Jul 2024 20:24:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-12-anton@khirnov.net> <20240717223725.GX4991@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20240717223725.GX4991@pb2> Subject: Re: [FFmpeg-devel] [PATCH 12/39] lavc/ffv1: drop redundant FFV1Context.quant_table X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/17/2024 7:37 PM, Michael Niedermayer wrote: > On Tue, Jul 16, 2024 at 07:11:27PM +0200, Anton Khirnov wrote: >> In all cases except decoding version 1 it's either not used, or contains >> a copy of a table from quant_tables, which we can just as well use >> directly. >> >> When decoding version 1, we can just as well decode into >> quant_tables[0], which would otherwise be unused. >> --- >> libavcodec/ffv1.h | 1 - >> libavcodec/ffv1dec.c | 10 +++++++--- >> libavcodec/ffv1enc.c | 6 ++---- >> 3 files changed, 9 insertions(+), 8 deletions(-) > > the code is 1 line longer and using the first entry as a special Two lines are comments... > case doesnt seem simpler > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".