From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 9D23044F11
	for <ffmpegdev@gitmailbox.com>; Wed,  8 Feb 2023 15:01:05 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C23768BECE;
	Wed,  8 Feb 2023 17:01:02 +0200 (EET)
Received: from mailrelay.ngus.net (mailrelay.ngus.net [109.237.26.52])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B5E068B75F
 for <ffmpeg-devel@ffmpeg.org>; Wed,  8 Feb 2023 17:00:56 +0200 (EET)
Received: from cpc102338-sgyl38-2-0-cust655.18-2.cable.virginm.net
 ([77.102.34.144] helo=zebop)
 by mailrelay.ngus.net with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)
 (envelope-from <tim@ngus.net>) id 1pPlwM-00DPtg-PF
 for ffmpeg-devel@ffmpeg.org; Wed, 08 Feb 2023 15:00:54 +0000
Received: from [192.168.101.3]
 by zebop with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
 (Exim 4.95) (envelope-from <tim@ngus.net>) id 1pPlwK-00AmEg-LO
 for ffmpeg-devel@ffmpeg.org; Wed, 08 Feb 2023 15:00:54 +0000
Message-ID: <2484c8b0-e8ad-dc0e-72fa-65c50cae19ec@ngus.net>
Date: Wed, 8 Feb 2023 15:00:46 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20230127172047.1024276-2-tim@ngus.net>
From: Tim Angus <tim@ngus.net>
In-Reply-To: <20230127172047.1024276-2-tim@ngus.net>
X-Spam-Score: -4.0 (----)
Subject: Re: [FFmpeg-devel] [PATCH 1/1] avformat/assenc: avoid incorrect
 copy of null terminator
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/2484c8b0-e8ad-dc0e-72fa-65c50cae19ec@ngus.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 27/01/2023 17:20, Tim Angus wrote:
> When writing a subtitle SSA/ASS subtitle file, the
> AVCodecParameters::extradata buffer is written directly to the output.
> In the case where the buffer is filled from a matroska source file
> produced by some older versions of Handbrake, this buffer ends with a
> null terminating character, which is then erroneously copied into the
> middle of the output file. The refactoring here avoids this problem by
> copying the source buffer, manually null terminating it, then treating
> it as a string rather than a raw buffer. This way it is agnostic as to
> whether the source buffer was null terminated or not.
>
Could somebody give this a look please? Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".