From: Tim Angus <tim@ngus.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/1] avformat/assenc: avoid incorrect copy of null terminator
Date: Wed, 8 Feb 2023 15:00:46 +0000
Message-ID: <2484c8b0-e8ad-dc0e-72fa-65c50cae19ec@ngus.net> (raw)
In-Reply-To: <20230127172047.1024276-2-tim@ngus.net>
On 27/01/2023 17:20, Tim Angus wrote:
> When writing a subtitle SSA/ASS subtitle file, the
> AVCodecParameters::extradata buffer is written directly to the output.
> In the case where the buffer is filled from a matroska source file
> produced by some older versions of Handbrake, this buffer ends with a
> null terminating character, which is then erroneously copied into the
> middle of the output file. The refactoring here avoids this problem by
> copying the source buffer, manually null terminating it, then treating
> it as a string rather than a raw buffer. This way it is agnostic as to
> whether the source buffer was null terminated or not.
>
Could somebody give this a look please? Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-02-08 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 17:20 [FFmpeg-devel] [PATCH 0/1] Handle ASS format subtitle encoding ambiguity Tim Angus
2023-01-27 17:20 ` [FFmpeg-devel] [PATCH 1/1] avformat/assenc: avoid incorrect copy of null terminator Tim Angus
2023-02-08 15:00 ` Tim Angus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2484c8b0-e8ad-dc0e-72fa-65c50cae19ec@ngus.net \
--to=tim@ngus.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git