From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 856B54859F for ; Fri, 8 Dec 2023 12:00:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0467068CFFE; Fri, 8 Dec 2023 14:00:23 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4691B68CF6D for ; Fri, 8 Dec 2023 14:00:16 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3B8C0Fxn000957-3B8C0Fxo000957; Fri, 8 Dec 2023 14:00:15 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 24A58A1428; Fri, 8 Dec 2023 14:00:14 +0200 (EET) Date: Fri, 8 Dec 2023 14:00:14 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Kalev Lember In-Reply-To: Message-ID: <24756b4e-64cb-bde0-86c8-6ad6ffd93889@martin.st> References: <20231208081536.14141-1-klember@redhat.com> <606f7cbb-a8a-4f37-6f62-89bf645fc813@martin.st> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 8 Dec 2023, Kalev Lember wrote: > As for dlopening, I think instead of version checks, it would make sense to > try to dlsym() all of the actual required symbols, and error out in init if > anything is missing. That should make it all super flexible and resilient to > e.g. struct size changes that would normally be an ABI change. How would that help, if e.g. the SEncParamExt struct in svc_encode_init would change layout/size - which part would notice that change? > In Fedora, we are planning on changing things up a bit and starting to build > packages that link with openh264 against the "noopenh264" stub > implementation and replacing it at runtime with the actual openh264 library > downloaded directly from Cisco. Flathub flatpak runtimes already use that > approach and it seems to work well there. This should hopefully let us take > advantage of the Cisco patent grant and fit well in the build system > architecture that we have. Ah, interesting, that sounds like a reasonable way to take advantage of that patent grant without having everybody to do the dlopening. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".