Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: Kalev Lember <klember@redhat.com>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks
Date: Fri, 8 Dec 2023 14:00:14 +0200 (EET)
Message-ID: <24756b4e-64cb-bde0-86c8-6ad6ffd93889@martin.st> (raw)
In-Reply-To: <CAHjaNbpwOMwgWaEG1t4xRPdO66qPm5Yzm_shPZ1Mg4E=gm13vg@mail.gmail.com>

On Fri, 8 Dec 2023, Kalev Lember wrote:

> As for dlopening, I think instead of version checks, it would make sense to
> try to dlsym() all of the actual required symbols, and error out in init if
> anything is missing. That should make it all super flexible and resilient to
> e.g. struct size changes that would normally be an ABI change.

How would that help, if e.g. the SEncParamExt struct in svc_encode_init 
would change layout/size - which part would notice that change?

> In Fedora, we are planning on changing things up a bit and starting to build
> packages that link with openh264 against the "noopenh264" stub
> implementation and replacing it at runtime with the actual openh264 library
> downloaded directly from Cisco. Flathub flatpak runtimes already use that
> approach and it seems to work well there. This should hopefully let us take
> advantage of the Cisco patent grant and fit well in the build system
> architecture that we have.

Ah, interesting, that sounds like a reasonable way to take advantage of 
that patent grant without having everybody to do the dlopening.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-12-08 12:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  8:15 Kalev Lember
2023-12-08  8:39 ` Martin Storsjö
2023-12-08 11:49   ` Kalev Lember
2023-12-08 12:00     ` Martin Storsjö [this message]
2023-12-08 12:11       ` Kalev Lember
2023-12-08 12:17         ` Martin Storsjö
2023-12-08 15:48 ` Neal Gompa
2023-12-08 15:58 ` James Almer
2023-12-08 19:07   ` Kalev Lember
2023-12-08 19:12     ` James Almer
     [not found]     ` <66731BE2-B56B-4F28-80D6-D5599C76CD04@cosmin.at>
2023-12-08 19:12       ` Cosmin Stejerean via ffmpeg-devel
2023-12-08 20:03         ` Kalev Lember
2023-12-08 20:34           ` Martin Storsjö
2023-12-09 21:03             ` Kalev Lember
2023-12-09 21:07 Kalev Lember
2023-12-18 22:15 ` Martin Storsjö

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24756b4e-64cb-bde0-86c8-6ad6ffd93889@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=klember@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git