From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CC3314B8DA for ; Tue, 18 Jun 2024 18:56:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 674EE68D748; Tue, 18 Jun 2024 21:56:32 +0300 (EEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 28A0168D4BA for ; Tue, 18 Jun 2024 21:56:26 +0300 (EEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-70630cf1fd4so7918b3a.1 for ; Tue, 18 Jun 2024 11:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718736983; x=1719341783; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=fpJ6TVan+Q0/elfhkl7CV+mAwX2RAwQQjW5YOTTPMOs=; b=i0hxl0vksREdWmgk0kLOp7Ht01ENEjKspicdsc2tNoeOsZagkFvcy0zBcGzBJhOGzl 2MXWKNYzpxPiMP2eTO2guoQCOVTQYsKYprOkRLTSSaiYLu2fJJyJZd0wWvrbIjwvFJkf g9vzH36GVLxot7KvwbTvTqdarhTED1GgM5J0BDmq8m6IH4VipXFAScqrC3hHEG/bP+70 JEqZNDdCAlXpTVZD+2mUMu9IQMYMh4ws630fWhvzy3gArysV5M0fB1dp7+VFYBC8RFwB Y6p1qSh/kZDw5MrUJ5XFlXYVMtdrWaP6zS09wlGWrGfbnDji6EilYnJreFx4W+2Fdkiv FSTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718736983; x=1719341783; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fpJ6TVan+Q0/elfhkl7CV+mAwX2RAwQQjW5YOTTPMOs=; b=hnF554FDSboKHWQgT2xHkAtVg5+0+EgycWMhQ2EOmepUGYZisYIKbJp6zQAO57f1wb ROUiqq9FWVE09DKNkNiiowsd1NYjpjJlh7OUyAIWNgZuHd9nyslUcbHXcCRQbIEIU6lL l/IdvMHz56+2SpjiA2y4YNNnqDPkB9WEO2KCJ8Qg9AuHiqGp3EhaJSJVNVM/iDFJ8yRW 5DJZh57Ow4MwVd1DEgC99FZSs+s8XAVUXWjHYa51vqytUdckI1soJPz5uaAhqrKf5+P+ AXFc8ktLhaUwVay57D6aXFffDkGPLwAPBTdSqkE7+hlTMDgtS9Q+j97aC34FFurcd3Di +CJA== X-Gm-Message-State: AOJu0Yzl6hqoBBIALoBN58CWXbxoAkFIlFndwfmbf/5qj4lUgZ3Wcakq DJ8VMeVm3Aa7i1OfO961oHJ7JkJvLQiigKuS+4iuBZJIzTJKFynJwgHkOg== X-Google-Smtp-Source: AGHT+IGeBnTwb24rksXK1xbJIMB5WTYikqRfx/hXHHWolC9g7hxWM8SoymvHkOKD0qMajoTvz1XDCg== X-Received: by 2002:a05:6a20:24a8:b0:1b5:cf26:ed09 with SMTP id adf61e73a8af0-1bcbb45166dmr418409637.7.1718736983177; Tue, 18 Jun 2024 11:56:23 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc91e13esm9615503b3a.11.2024.06.18.11.56.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 11:56:22 -0700 (PDT) Message-ID: <246e98b6-018e-40a3-ad64-cde64dd13732@gmail.com> Date: Tue, 18 Jun 2024 15:56:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240618185502.680197-1-derek.buitenhuis@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: <20240618185502.680197-1-derek.buitenhuis@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/dump: Print all possible Stereo3D info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/18/2024 3:55 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/dump.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 059fb84522..61a2c6a29f 100644 > --- a/libavformat/dump.c > +++ b/libavformat/dump.c > @@ -259,7 +259,16 @@ static void dump_stereo3d(void *ctx, const AVPacketSideData *sd, int log_level) > > stereo = (const AVStereo3D *)sd->data; > > - av_log(ctx, log_level, "%s", av_stereo3d_type_name(stereo->type)); > + av_log(ctx, log_level, "%s, view: %s, primary eye: %s", > + av_stereo3d_type_name(stereo->type), av_stereo3d_view_name(stereo->view), > + av_stereo3d_primary_eye_name(stereo->primary_eye)); > + if (stereo->baseline) > + av_log(ctx, log_level, ", baseline: %"PRIu32"", stereo->baseline); > + if (stereo->horizontal_disparity_adjustment.num && stereo->horizontal_disparity_adjustment.den) > + av_log(ctx, log_level, ", horizontal_disparity_adjustment: %d/%d", > + stereo->horizontal_disparity_adjustment.num, stereo->horizontal_disparity_adjustment.den); > + if (stereo->horizontal_field_of_view) > + av_log(ctx, log_level, ", horizontal_field_of_view: %"PRIu32"", stereo->horizontal_field_of_view); > > if (stereo->flags & AV_STEREO3D_FLAG_INVERT) > av_log(ctx, log_level, " (inverted)"); LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".